Build status: Build succeeded!
Worker used: bb_worker2_ubuntu
URL: https://ci2.apache.org/#builders/112/builds/316
Blamelist: Christopher Schultz
Build Text: build successful
Status Detected: restored build
Build Source Stamp: [branch main] 624ccecf1a6c76773a339eaac940907c7b767565
Steps:
work
ebourg commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513834050
Suggested fix, test case to follow
https://github.com/ebourg/tomcat-jakartaee-migration/commit/4d8457d3658bff94510e6b215707e172493f0b71
--
This is an automated me
markt-asf commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513823210
Excellent. We can always check if the size > 4GB and log a warning in that
case.
--
This is an automated message from the Apache Git Service.
To respond to the me
ebourg commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513807408
Digging further... my initial intuition of removing the ZIP64 extra field
does really work, I just didn't implement it correctly (I added it only to the
STORED branch
This is an automated email from the ASF dual-hosted git repository.
schultz pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 624ccecf1a Fix typo
624ccecf1a is described below
ChristopherSchultz closed pull request #610: Enhance PEMFile to load from an
inputstream too
URL: https://github.com/apache/tomcat/pull/610
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specif
ChristopherSchultz commented on PR #610:
URL: https://github.com/apache/tomcat/pull/610#issuecomment-1513785961
I've merged this separately, including a changelog entry.
Thanks for the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
This is an automated email from the ASF dual-hosted git repository.
schultz pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new 7a2f3ece0d Enhance PEMFile to load from an InputS
Build status: BUILD FAILED: failed compile (failure)
Worker used: bb_worker2_ubuntu
URL: https://ci2.apache.org/#builders/112/builds/315
Blamelist: Christopher Schultz
Build Text: failed compile (failure)
Status Detected: new failure
Build Source Stamp: [branch main] 433b5b5e84309c83ba81abae883790
This is an automated email from the ASF dual-hosted git repository.
schultz pushed a change to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
from ccbeef9f6d Add 9.0.74 release date
new 1afac1b166 Enhance PEMFile to load from an InputStream.
new 192ad2d2d
This is an automated email from the ASF dual-hosted git repository.
schultz pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 192ad2d2d43c3f11c667c62822e67cf4a5d65009
Author: Christopher Schultz
AuthorDate: Tue Apr 18 16:37:49 2023 -0400
Fix
This is an automated email from the ASF dual-hosted git repository.
schultz pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 1afac1b166beaea0aa4a73a9817543462498b75b
Author: Christopher Schultz
AuthorDate: Tue Apr 18 16:33:41 2023 -0400
Enh
This is an automated email from the ASF dual-hosted git repository.
schultz pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit ffafc9c7e86035ed4fe817c9678248a82e806ff0
Author: Christopher Schultz
AuthorDate: Tue Apr 18 16:33:41 2023 -0400
En
This is an automated email from the ASF dual-hosted git repository.
schultz pushed a change to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
from 44bb41ac80 Fix missing IllegalArgumentException
new ffafc9c7e8 Enhance PEMFile to load from an InputStream.
This is an automated email from the ASF dual-hosted git repository.
schultz pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 2518a0c97c4daa20c646e8142d117a02d01dfca0
Author: Christopher Schultz
AuthorDate: Tue Apr 18 16:37:49 2023 -0400
Fi
This is an automated email from the ASF dual-hosted git repository.
schultz pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 433b5b5e84 Enhance PEMFile to load from an InputStr
eirbjo commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513716893
> If Tomcat does not want to produce such files, you could always overide
the `zip64Mode` option to `never`, instead of the default `as-needed`.
Note that the `j
eirbjo commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513675091
> Could this be summarized to Java inability to read zip files using ZIP64
fields and streaming data headers?
That sounds right. `java.util.ZipInputStream` curre
ebourg commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513668571
Could this be summarized to Java inhability to read zip files using ZIP64
fields and streaming data headers? If so, this means tomcat-jakartaee-migration
could simply
eirbjo commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513655682
> It is also post-processed by BND.
Commenting out the `add-graal` call makes the ZIP64 extra fields disappear.
I have debugged the `zip` call, and `zip` in this
Am 14.04.23 um 22:08 schrieb Christopher Schultz:
The proposed Apache Tomcat 10.1.8 release is now available for
voting.
The notable changes compared to 10.1.7 are:
- Reduce the default value of maxParameterCount from 10,000 to 1,000.
- Correct a regression in the fix for bug 66442 that meant
markt-asf commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513626451
It is also post-processed by BND.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
ChristopherSchultz commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513599230
Sorry @eirbjo I wasn't sure if you meant the JAR file before or after
migration. Apache ant produces the original, and commons-compress produces the
migrat
ebourg commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513597387
> From the OpenJDK side it would be interesting to learn which tool or API
produced the tomcat-embed-10.1.7.jar file.
It was produced by Ant, which has its own z
ChristopherSchultz commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513596335
The code is on GH, here:
https://github.com/apache/tomcat-jakartaee-migration/blob/main/src/main/java/org/apache/tomcat/jakartaee/Migration.java
Look
https://bz.apache.org/bugzilla/show_bug.cgi?id=66569
--- Comment #2 from Emmanuel Bourg ---
What file captures this log?
--
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-un
https://bz.apache.org/bugzilla/show_bug.cgi?id=66569
--- Comment #1 from Remy Maucherat ---
https://github.com/apache/tomcat/blob/main/java/org/apache/catalina/core/StandardContext.java#L4450
?
--
You are receiving this mail because:
You are the assignee for the bug.
---
eirbjo commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513584043
From the OpenJDK side it would be interesting to learn which tool or API
produced the `tomcat-embed-10.1.7.jar` file.
--
This is an automated message from the Apache
ChristopherSchultz commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513581200
I'm happy to have this investigated if it improves our migration tool, but
I'm curious as to why the tomcat-embed-10.1.7.jar file is even being migrated.
T
ebourg commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513568182
zipdetails 2.104 gives me a different output:
```
00 LOCAL HEADER #1 04034B50
04 Extract Zip Spec 0A '1.0'
05 Extract OS
eirbjo commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513560520
There is something funny going on with the source file being migrated here,
[tomcat-embed-core-10.1.7.jar](https://repo1.maven.org/maven2/org/apache/tomcat/embed/tomcat
eirbjo commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513489596
Another exotic feature of this ZIP is that it has CEN ZIP64 extended
information fields with no content (0 bytes). I don't think I've ever seen that
before.
--
This
eirbjo commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513487060
> It is the JRE that is in the wrong:
https://bugs.openjdk.org/browse/JDK-8303866
Hi. I contributted JDK-8303866 and the associated PR which is currently
under
https://bz.apache.org/bugzilla/show_bug.cgi?id=66569
Bug ID: 66569
Summary: ServletContextListener errors are not reported
Product: Tomcat 9
Version: 9.0.73
Hardware: All
OS: All
Status: NEW
Severity: enha
All,
FYI: Because I called for a vote on late Friday afternoon, I plan to
leave the vote open for another day or two before closing.
-chris
On 4/14/23 15:30, Christopher Schultz wrote:
All,
On 4/13/23 10:14, Christopher Schultz wrote:
VirtualBox is giving me a headache again. I'll roll the
markt-asf commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513471359
It is the JRE that is in the wrong:
https://bugs.openjdk.org/browse/JDK-8303866
--
This is an automated message from the Apache Git Service.
To respond to the mes
markt-asf commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513451186
Progress. The field shadowing was a red herring. The Eclipse IDE was
providing misleading information.
I think I am seeing a similar root cause to you. The ne
Mark,
On 4/18/23 03:21, Mark Thomas wrote:
On 17/04/2023 23:04, Christopher Schultz wrote:
Mark,
On 4/17/23 05:07, Mark Thomas wrote:
On 16/04/2023 18:59, Mark Thomas wrote:
On 14/04/2023 21:38, Christopher Schultz wrote:
The proposed 8.5.88 release is:
[ ] Broken - do not release
[X] Stab
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new 53931c7ceb Fix missing IllegalArgumentException
5393
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new a5e0e42101 Fix missing IllegalArgumentException
a5e0
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new ccbeef9f6d Add 9.0.74 release date
ccbeef9f6d is des
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 676b3926ae Fix missing IllegalArgumentException
676b39
https://bz.apache.org/bugzilla/show_bug.cgi?id=66567
Remy Maucherat changed:
What|Removed |Added
Resolution|--- |FIXED
Status|NEW
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.1.x by this push:
new 44bb41ac80 Fix missing IllegalArgumentException
44
ebourg commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513306019
My test was flawed, removing the zip64 field has no effect actually :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please
ebourg commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513245658
In `Migration.migrateArchiveStreaming()`, if the zip64 field is removed with
`destZipEntry.removeExtraField(new ZipShort(0x0001));` the file generated
becomes parseabl
ebourg commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513198356
Something weird I noticed, commons-compress thinks the entries of the
original jar have the zip64 field (`ZipArchiveOutputStream.hasZip64Extra()`
returns true), and th
ebourg commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513182991
If that helps, this is the difference between the two jar files for the
first entry (as seen by diffoscope):
```
¦ End-of-central-directory record:
¦ ---
markt-asf commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513051774
I was testing `ZipFile` which fails with Java 8 but works with Java 11.
I do see issues with `ZipInputStream`. It is failing on the very first entry
and in Ja
ebourg commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1513023104
The file is unreadable using a ZipInputStream with OpenJDK 11.0.18 and
17.0.6 (tested with ZuluJDK on Windows). Are you sure it works with Java 11?
I agree this
Hello,
For some reason there are no binary artifacts here:
https://archive.apache.org/dist/tomcat/tomcat-9/v9.0.74 :(
from mobile (sorry for typos ;)
On Tue, Apr 18, 2023, 15:55 Rémy Maucherat wrote:
> The Apache Tomcat team announces the immediate availability of Apache
> Tomcat 9.0.74.
>
>
markt-asf commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1512882338
The root cause is a Java bug. If I open the converted file with Java 8, I
get the `invalid CEN header (bad signature)`. If I switch to Java 11, it opens
as expected
markt-asf closed issue #46: "java.util.zip.ZipException: invalid CEN header
(bad signature)" when opening migrated jar with `java.util.zip.ZipFile`
URL: https://github.com/apache/tomcat-jakartaee-migration/issues/46
--
This is an automated message from the Apache Git Service.
To respond to th
ebourg commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1512841690
I think that was for performance. Maybe we should make it the default when
processing jar files.
--
This is an automated message from the Apache Git Service.
To resp
rmannibucau opened a new pull request, #610:
URL: https://github.com/apache/tomcat/pull/610
The file abstraction is sometimes bothering (tomcat embedded to mention it)
so enable to use PEMFile logic without having to dump a temp file.
--
This is an automated message from the Apache Git Se
The Apache Tomcat team announces the immediate availability of Apache
Tomcat 9.0.74.
Apache Tomcat 9 is an open source software implementation of the Java
Servlet, JavaServer Pages, Java Unified Expression Language, Java
WebSocket and JASPIC technologies.
Apache Tomcat 9.0.74 is a bugfix and feat
Author: remm
Date: Tue Apr 18 08:51:37 2023
New Revision: 1909214
URL: http://svn.apache.org/viewvc?rev=1909214&view=rev
Log:
Update website for 9.0.74 release
Modified:
tomcat/site/trunk/build.properties.default
tomcat/site/trunk/docs/doap_Tomcat.rdf
tomcat/site/trunk/docs/download-9
Author: remm
Date: Tue Apr 18 08:35:47 2023
New Revision: 1909212
URL: http://svn.apache.org/viewvc?rev=1909212&view=rev
Log:
Update javadoc for 9.0.74
Added:
tomcat/site/trunk/docs/tomcat-9.0-doc/api/org/apache/catalina/authenticator/DigestAuthenticator.AuthDigest.html
tomcat/site/trun
Author: remm
Date: Tue Apr 18 08:32:46 2023
New Revision: 1909210
URL: http://svn.apache.org/viewvc?rev=1909210&view=rev
Log:
Update javadoc for 9.0.74
[This commit notification would consist of 82 parts,
which exceeds the limit of 50 ones, so it was shortened to the summary.]
markt-asf commented on issue #46:
URL:
https://github.com/apache/tomcat-jakartaee-migration/issues/46#issuecomment-1512675348
Use -zipInMemory to avoid this error. I need to remind myself what it was
about some zips that meant we needed to introduce this option.
--
This is an automated m
Author: remm
Date: Tue Apr 18 08:26:29 2023
New Revision: 61338
Log:
Drop 9.0.72 from mirrors
Removed:
release/tomcat/tomcat-9/v9.0.72/
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-
Author: remm
Date: Tue Apr 18 08:24:11 2023
New Revision: 61337
Log:
Release Apache Tomcat 9.0.74
Added:
release/tomcat/tomcat-9/v9.0.74/
- copied from r61336, dev/tomcat/tomcat-9/v9.0.74/
Removed:
dev/tomcat/tomcat-9/v9.0.74/
--
The following votes were cast:
Binding:
+1: lihan, jfclere, markt, funkman, remm
No other votes were cast. The vote therefore passes.
Thanks to everyone who contributed to this release.
Rémy
-
To unsubscribe, e-mail: dev-unsub
On Thu, Apr 13, 2023 at 10:42 AM Rémy Maucherat wrote:
>
> The proposed Apache Tomcat 9.0.74 release is now available for voting.
>
> The notable changes compared to 9.0.73 are:
>
> - Reduce the default value of maxParameterCount from 10,000 to 1,000.
>
> - Correct a regression in the fix for bug
https://bz.apache.org/bugzilla/show_bug.cgi?id=66567
--- Comment #4 from Remy Maucherat ---
(In reply to Han Li from comment #3)
> (In reply to Remy Maucherat from comment #2)
> > Note: Instead of catching IllegalArgumentException, I think checking
> > isAbsolute (and doing nothing, since it shou
https://bz.apache.org/bugzilla/show_bug.cgi?id=66567
--- Comment #3 from Han Li ---
(In reply to Remy Maucherat from comment #2)
> Note: Instead of catching IllegalArgumentException, I think checking
> isAbsolute (and doing nothing, since it should always be another code path)
> is nicer.
+1
In
On 17/04/2023 23:04, Christopher Schultz wrote:
Mark,
On 4/17/23 05:07, Mark Thomas wrote:
On 16/04/2023 18:59, Mark Thomas wrote:
On 14/04/2023 21:38, Christopher Schultz wrote:
The proposed 8.5.88 release is:
[ ] Broken - do not release
[X] Stable - go ahead and release as 8.5.88 (stable)
https://bz.apache.org/bugzilla/show_bug.cgi?id=66567
--- Comment #2 from Remy Maucherat ---
Note: Instead of catching IllegalArgumentException, I think checking isAbsolute
(and doing nothing, since it should always be another code path) is nicer.
--
You are receiving this mail because:
You are
https://bz.apache.org/bugzilla/show_bug.cgi?id=66567
--- Comment #1 from Remy Maucherat ---
There was a refactoring to change new URL -> (new URI).toURL. Unfortunately,
this allows some new exceptions such as URISyntaxException, which have been
added. However, it turns out IllegalArgumentExceptio
69 matches
Mail list logo
