[GitHub] [tomcat] aooohan commented on a diff in pull request #607: Added RateLimitFilter

2023-03-29 Thread via GitHub
aooohan commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1152661197 ## java/org/apache/catalina/filters/RateLimitFilter.java: ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor l

[Bug 66533] Wrapping Requests or Responses in Valves is not possible

2023-03-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66533 --- Comment #3 from Christopher Schultz --- (In reply to Mark Thomas from comment #1) > Tomcat's internal architecture hasn't changed that much since that bug. API instability! (I say while smiling and glancing sidelong at Rémy.) While I am s

[GitHub] [tomcat] isapir commented on a diff in pull request #607: Added RateLimitFilter

2023-03-29 Thread via GitHub
isapir commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1152128204 ## java/org/apache/catalina/filters/RateLimitFilter.java: ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor li

[GitHub] [tomcat] funkman commented on a diff in pull request #607: Added RateLimitFilter

2023-03-29 Thread via GitHub
funkman commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1151886616 ## java/org/apache/catalina/filters/RateLimitFilter.java: ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor l

A Message from the Board to PMC members

2023-03-29 Thread Rich Bowen
Dear Apache Project Management Committee (PMC) members, The Board wants to take just a moment of your time to communicate a few things that seem to have been forgotten by a number of PMC members, across the Foundation, over the past few years. Please note that this is being sent to all projects -

[GitHub] [tomcat] rmaucher commented on a diff in pull request #607: Added RateLimitFilter

2023-03-29 Thread via GitHub
rmaucher commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1151854974 ## java/org/apache/catalina/filters/RateLimitFilter.java: ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

[GitHub] [tomcat] funkman commented on a diff in pull request #607: Added RateLimitFilter

2023-03-29 Thread via GitHub
funkman commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1151844920 ## java/org/apache/catalina/filters/RateLimitFilter.java: ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor l

[tomcat] branch main updated (a6339b1405 -> ffb5ef2de0)

2023-03-29 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git from a6339b1405 Fix BZ 66542 - Update references to JavaMail to use Jakarta Mail add ffb5ef2de0 Refactor AmbiguousBean t

[tomcat] branch 8.5.x updated: Change how the reduced default for maxParameterCount is implemented

2023-03-29 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 2d6592dbba Change how the reduced default for maxPa

[tomcat] branch 9.0.x updated: Change how the reduced default for maxParameterCount is implemented

2023-03-29 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 4867e4e028 Change how the reduced default for maxPa

[tomcat] branch 10.1.x updated: Change how the reduced default for maxParameterCount is implemented

2023-03-29 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.1.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.1.x by this push: new c88552bb1b Change how the reduced default for max

[GitHub] [tomcat] aooohan commented on a diff in pull request #607: Added RateLimitFilter

2023-03-29 Thread via GitHub
aooohan commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1151651401 ## java/org/apache/catalina/util/TimeBucketCounter.java: ## @@ -0,0 +1,217 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor li

[GitHub] [tomcat] aooohan commented on a diff in pull request #607: Added RateLimitFilter

2023-03-29 Thread via GitHub
aooohan commented on code in PR #607: URL: https://github.com/apache/tomcat/pull/607#discussion_r1151643999 ## java/org/apache/catalina/filters/RateLimitFilter.java: ## @@ -0,0 +1,230 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor l

[Bug 66545] StandardRoot.createMainResourceSet() doesn't report permission issues

2023-03-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66545 Remy Maucherat changed: What|Removed |Added OS||All --- Comment #1 from Remy Mauchera