https://bz.apache.org/bugzilla/show_bug.cgi?id=66533
--- Comment #3 from Christopher Schultz <ch...@christopherschultz.net> --- (In reply to Mark Thomas from comment #1) > Tomcat's internal architecture hasn't changed that much since that bug. API instability! (I say while smiling and glancing sidelong at Rémy.) While I am still convinced that RequestWrapper and ResponseWrapper classes would be a good inclusion to Tomcat, I am not convinced that changing the Valve interface to use some other classes or interfaces makes much sense. Switching to HttServletRequest (and response) is too limiting, and extracting an IRequest interface (and similar with response) is just busy-work. Extending Request (and response) to override capability is just as easy as implementing the dozens of methods from Request (and response) in a custom class. Using my unofficial wrappers cuts-out some of the busy-work, but it's all currently doable. A Valve is not a Filter. Let's not pretend that it is. Valves exist to do /very specific things/ that cannot be done as Filters, and the power to do that comes directly from explicit access to internal classes such as Request (and response). -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
