[Bug 65975] CLIENT-CERT authentication does not request cert from client and always denies access (401)

2022-03-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65975 --- Comment #2 from Martin Stangl --- Tried some other things with the same result: - Tested with Apache Tomcat 9 on Windows Server - Removed LockOutRealm and used UserDatabaseRealm directly - Used MemoryRealm instead of UserDatabaseRealm - Use

[GitHub] [tomcat] volosied opened a new pull request #488: Donating EL Translations

2022-03-23 Thread GitBox
volosied opened a new pull request #488: URL: https://github.com/apache/tomcat/pull/488 Open Liberty uses Tomcat's EL API, but, since some of the property file translations were missing, IBM completed them and created new files for other languages. We'd like to contribute these back to To

[Bug 65975] CLIENT-CERT authentication does not request cert from client and always denies access (401)

2022-03-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65975 Martin Stangl changed: What|Removed |Added OS||All --- Comment #1 from Martin Stangl

[Bug 65975] CLIENT-CERT authentication does not request cert from client and always denies access (401)

2022-03-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65975 Martin Stangl changed: What|Removed |Added OS||Windows 10 -- You are receiving this

[Bug 65975] New: CLIENT-CERT authentication does not request cert from client and always denies access (401)

2022-03-23 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65975 Bug ID: 65975 Summary: CLIENT-CERT authentication does not request cert from client and always denies access (401) Product: Tomcat 9 Version: 9.0.60 Hardware: PC

Re: [tomcat] 01/02: PR #487: Improve logging of unknown settings frames

2022-03-23 Thread Rémy Maucherat
On Wed, Mar 23, 2022 at 10:01 PM Christopher Schultz wrote: > > Rémy, > > On 3/23/22 16:10, r...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > > > remm pushed a commit to branch 10.0.x > > in repository https://gitbox.apache.org/repos/asf/tomcat.git

Re: [tomcat] 01/02: PR #487: Improve logging of unknown settings frames

2022-03-23 Thread Christopher Schultz
Rémy, On 3/23/22 16:10, r...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit a82ddf0fc42c960f224e7d23eaa90df272de3559 Author: remm AuthorDate: Wed Ma

[tomcat] 02/02: Remove check disabling logging

2022-03-23 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 07ba9a8ed457598a3ef4e6bdb463248524abc419 Author: remm AuthorDate: Wed Mar 23 21:03:44 2022 +0100 Remove check disablin

[tomcat] 01/02: PR #487: Improve logging of unknown settings frames

2022-03-23 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 42b83ee1db5337ca6756681c90cfecad885a122f Author: remm AuthorDate: Wed Mar 23 21:00:41 2022 +0100 PR #487: Improve logg

[tomcat] branch 8.5.x updated (811e085 -> 07ba9a8)

2022-03-23 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 811e085 65959: Serialize Function as String[] rather Class[] new 42b83ee PR #487: Improve logging of unknown sett

[tomcat] 02/02: Remove check disabling logging

2022-03-23 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit cb070df1ed877cc2025a483c73a01c69d3c4b4f9 Author: remm AuthorDate: Wed Mar 23 21:03:44 2022 +0100 Remove check disablin

[tomcat] 01/02: PR #487: Improve logging of unknown settings frames

2022-03-23 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit a3d0dc2e33019bf94edb2992d178fe06b25b8d6a Author: remm AuthorDate: Wed Mar 23 21:00:41 2022 +0100 PR #487: Improve logg

[tomcat] branch 9.0.x updated (11ec974 -> cb070df)

2022-03-23 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a change to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 11ec974 65959: Serialize Function as String[] rather Class[] new a3d0dc2 PR #487: Improve logging of unknown sett

[tomcat] 01/02: PR #487: Improve logging of unknown settings frames

2022-03-23 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit a82ddf0fc42c960f224e7d23eaa90df272de3559 Author: remm AuthorDate: Wed Mar 23 21:00:41 2022 +0100 PR #487: Improve log

[tomcat] 02/02: Remove check disabling logging

2022-03-23 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit e186391dc9973e922424193baab46e0c520ac359 Author: remm AuthorDate: Wed Mar 23 21:03:44 2022 +0100 Remove check disabli

[tomcat] branch 10.0.x updated (5563753 -> e186391)

2022-03-23 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a change to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 5563753 65959: Serialize Function as String[] rather Class[] new a82ddf0 PR #487: Improve logging of unknown set

[tomcat] branch main updated: Remove check disabling logging

2022-03-23 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 3bcbd5a Remove check disabling logging 3bcbd5a is des

Re: [tomcat] branch main updated: PR #487: Improve logging of unknown settings frames

2022-03-23 Thread Rémy Maucherat
On Wed, Mar 23, 2022 at 9:04 PM Mark Thomas wrote: > > On 23/03/2022 20:01, r...@apache.org wrote: > > > > > diff --git a/java/org/apache/coyote/http2/Http2Parser.java > > b/java/org/apache/coyote/http2/Http2Parser.java > > index 5875e28..8c67d84 100644 > > --- a/java/org/apache/coyote/http2/Htt

Re: [tomcat] branch main updated: PR #487: Improve logging of unknown settings frames

2022-03-23 Thread Mark Thomas
On 23/03/2022 20:01, r...@apache.org wrote: diff --git a/java/org/apache/coyote/http2/Http2Parser.java b/java/org/apache/coyote/http2/Http2Parser.java index 5875e28..8c67d84 100644 --- a/java/org/apache/coyote/http2/Http2Parser.java +++ b/java/org/apache/coyote/http2/Http2Parser.java @@ -337,

[GitHub] [tomcat] HoffmannTom commented on pull request #487: Improved logging of unknown http2 settings

2022-03-23 Thread GitBox
HoffmannTom commented on pull request #487: URL: https://github.com/apache/tomcat/pull/487#issuecomment-1076767607 Thank you for the quick response and help! My second pull request in future will hopefully improve. -- This is an automated message from the Apache Git Service. To respond

Re: Repeatable builds

2022-03-23 Thread Mark Thomas
On 23/03/2022 17:20, Christopher Schultz wrote: Mark, On 3/22/22 13:12, Mark Thomas wrote: Finally, I have some minor modifications to buidl.xml that will enable repeatable builds. Once everything is in place the build process will look like: - prepare for tagging as currently (update versio

[tomcat] branch main updated: PR #487: Improve logging of unknown settings frames

2022-03-23 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 23a92d7 PR #487: Improve logging of unknown settings

[GitHub] [tomcat] rmaucher commented on pull request #487: Improved logging of unknown http2 settings

2022-03-23 Thread GitBox
rmaucher commented on pull request #487: URL: https://github.com/apache/tomcat/pull/487#issuecomment-1076764682 Oh, actually, this has the key -> id change, but it should still do Integer.toString(id). -- This is an automated message from the Apache Git Service. To respond to the message

[GitHub] [tomcat] rmaucher closed pull request #487: Improved logging of unknown http2 settings

2022-03-23 Thread GitBox
rmaucher closed pull request #487: URL: https://github.com/apache/tomcat/pull/487 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@

[GitHub] [tomcat] rmaucher commented on pull request #487: Improved logging of unknown http2 settings

2022-03-23 Thread GitBox
rmaucher commented on pull request #487: URL: https://github.com/apache/tomcat/pull/487#issuecomment-1076761134 Closing since the patch is wrong and I'm already about to commit it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

[GitHub] [tomcat] HoffmannTom opened a new pull request #487: Improved logging of unknown http2 settings

2022-03-23 Thread GitBox
HoffmannTom opened a new pull request #487: URL: https://github.com/apache/tomcat/pull/487 The logging of unknown http2 settings should contain the key and the value of the setting. The key is currently converted into a setting object. Unknown keys are mapped to Integer.MAX_VALUE Thu

Re: Repeatable builds

2022-03-23 Thread Christopher Schultz
Mark, On 3/22/22 13:12, Mark Thomas wrote: Finally, I have some minor modifications to buidl.xml that will enable repeatable builds. Once everything is in place the build process will look like: - prepare for tagging as currently (update version in   build.properties.default and edit changel

Re: Repeatable builds

2022-03-23 Thread Christopher Schultz
Mark, On 3/23/22 12:18, Mark Thomas wrote: On 23/03/2022 16:11, Christopher Schultz wrote: ?? $ ant javadoc Dumps everything into output/dist/webapps/docs/, no ZIP files. The "javadoc" target executes tasks and that's it. What am I missing? Look in the individual Javadoc directories. Eac

Re: Repeatable builds

2022-03-23 Thread Mark Thomas
On 23/03/2022 16:11, Christopher Schultz wrote: Mark, On 3/22/22 15:30, Mark Thomas wrote: On 22/03/2022 19:06, Christopher Schultz wrote: On 3/22/22 13:12, Mark Thomas wrote: The JSign Ant task that adds the detached signature doesn't close the signed file. This causes problems for Ant.

Re: Repeatable builds

2022-03-23 Thread Christopher Schultz
Mark, On 3/22/22 15:30, Mark Thomas wrote: On 22/03/2022 19:06, Christopher Schultz wrote: On 3/22/22 13:12, Mark Thomas wrote: The JSign Ant task that adds the detached signature doesn't close the signed file. This causes problems for Ant. I've opened a JSign issue [2] for this. I have a