On Wed, Mar 23, 2022 at 10:01 PM Christopher Schultz <ch...@christopherschultz.net> wrote: > > Rémy, > > On 3/23/22 16:10, r...@apache.org wrote: > > This is an automated email from the ASF dual-hosted git repository. > > > > remm pushed a commit to branch 10.0.x > > in repository https://gitbox.apache.org/repos/asf/tomcat.git > > > > commit a82ddf0fc42c960f224e7d23eaa90df272de3559 > > Author: remm <r...@apache.org> > > AuthorDate: Wed Mar 23 21:00:41 2022 +0100 > > > > PR #487: Improve logging of unknown settings frames > > > > Pull request by Thomas Hoffmann. > > --- > > java/org/apache/coyote/http2/ConnectionSettingsBase.java | 2 -- > > java/org/apache/coyote/http2/Http2Parser.java | 7 ++++++- > > java/org/apache/coyote/http2/Http2UpgradeHandler.java | 7 ++++++- > > webapps/docs/changelog.xml | 4 ++++ > > 4 files changed, 16 insertions(+), 4 deletions(-) > > > > diff --git a/java/org/apache/coyote/http2/ConnectionSettingsBase.java > > b/java/org/apache/coyote/http2/ConnectionSettingsBase.java > > index 042fb0c..ef4a200 100644 > > --- a/java/org/apache/coyote/http2/ConnectionSettingsBase.java > > +++ b/java/org/apache/coyote/http2/ConnectionSettingsBase.java > > @@ -88,8 +88,6 @@ abstract class ConnectionSettingsBase<T extends > > Throwable> { > > break; > > case UNKNOWN: > > // Unrecognised. Ignore it. > > - log.warn(sm.getString("connectionSettings.unknown", > > - connectionId, setting, Long.toString(value))); > > return; > > } > > > Was it intended to remove this log completely?
Yes, there is not enough information to do the logging there. Rémy > -chris > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
