Re: Reproducible builds update

2022-01-18 Thread Mark Thomas
On 19/01/2022 07:47, Romain Manni-Bucau wrote: Hi Mark, It is possible to use jdk.javadoc/jdk.compiler as libs and plug in through the Context class forcing a JavaFileManager to force a DocFileFactory in the HtmlConfiguration but it will be way more complex than unzipping/rezipping the jar. Ni

Re: Reproducible builds update

2022-01-18 Thread Romain Manni-Bucau
Hi Mark, It is possible to use jdk.javadoc/jdk.compiler as libs and plug in through the Context class forcing a JavaFileManager to force a DocFileFactory in the HtmlConfiguration but it will be way more complex than unzipping/rezipping the jar. Another option can be a light javaagent patching the

[GitHub] [tomcat] xiezhaokun commented on pull request #462: Add support for password-based encryption scheme 2 params (PBES2)

2022-01-18 Thread GitBox
xiezhaokun commented on pull request #462: URL: https://github.com/apache/tomcat/pull/462#issuecomment-1016133726 https://github.com/apache/tomcat/commit/d871a229da1408520614c87fd1f50af5c0d639ca -- This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] [tomcat] chenyonghui opened a new pull request #465: update catalina.usage item

2022-01-18 Thread GitBox
chenyonghui opened a new pull request #465: URL: https://github.com/apache/tomcat/pull/465 update catalina.usage in Chinese LocalString.properties -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: Reproducible builds update

2022-01-18 Thread Christopher Schultz
Mark, On 1/18/22 15:03, Mark Thomas wrote: On 18/01/2022 19:39, Mark Thomas wrote: The first issue looks relatively simple to fix. I don't see an easy fix for the second. My best idea so far is some sort of post-processing for the Javadoc generation that extracts the file from the zip, set

Re: [VOTE] Release Apache Tomcat 8.5.75 (clarified version numbers, again)

2022-01-18 Thread Christopher Schultz
All, Apologies for the copy/paste errors in previous [VOTE] messages. Thunderbird is refusing to find more than one instance of a string an an outgoing message. :/ Vote and details are below... On 1/18/22 17:26, Christopher Schultz wrote: The proposed Apache Tomcat 8.5.75 release is now ava

[VOTE] Release Apache Tomcat 8.5.75 (clarified version numbers, again)

2022-01-18 Thread Christopher Schultz
The proposed Apache Tomcat 8.5.75 release is now available for voting. The one notable change compared to 8.5.74 (which was not released due to this bug) is: - Correct a regression in the fix for BZ 65785 that broke HTTP/2 server push. The notable changes compared to 8.5.73 are: - Pr

[VOTE] Release Apache Tomcat 8.5.75 (clarified version number)

2022-01-18 Thread Christopher Schultz
The proposed Apache Tomcat 8.5.75 release is now available for voting. The one notable change compared to 8.5.74 (which was not released due to this bug) is: - Correct a regression in the fix for BZ 65785 that broke HTTP/2 server push. The notable changes compared to 8.5.73 are: - Pr

Re: Reproducible builds update

2022-01-18 Thread Mark Thomas
On 18/01/2022 19:39, Mark Thomas wrote: The first issue looks relatively simple to fix. I don't see an easy fix for the second. My best idea so far is some sort of post-processing for the Javadoc generation that extracts the file from the zip, sets the timestamp and then re-zips it. Suggesti

[tomcat] 01/02: Fix order to support reproducible builds

2022-01-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 929a34cf8e1b9cad97324734dbfeda5a6dce3207 Author: Mark Thomas AuthorDate: Tue Jan 18 19:49:30 2022 + Fix order to s

[tomcat] branch 8.5.x updated: Use same options for all Javadoc tasks

2022-01-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 534b884 Use same options for all Javadoc tasks 534

[tomcat] 01/02: Fix order to support reproducible builds

2022-01-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 7bc3fff66f916643c90d2947190fdc997f53176e Author: Mark Thomas AuthorDate: Tue Jan 18 19:49:30 2022 + Fix order to

[tomcat] 02/02: Use same options for all Javadoc tasks

2022-01-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit dd82317446c1e3afd0d31452ee6474f5976ae590 Author: Mark Thomas AuthorDate: Tue Jan 18 19:49:48 2022 + Use same opti

[tomcat] branch 9.0.x updated (a4f1d05 -> dd82317)

2022-01-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from a4f1d05 Align Derby version used with 10.1.x and 10.0.x new 7bc3fff Fix order to support reproducible builds

[tomcat] 02/02: Use same options for all Javadoc tasks

2022-01-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 93c70938204aaa451f332578bec70fef1138e193 Author: Mark Thomas AuthorDate: Tue Jan 18 19:49:48 2022 + Use same opt

[tomcat] 01/02: Fix order to support reproducible builds

2022-01-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit f0cb9b0741955a5f5b877aed2771598ec09bc44c Author: Mark Thomas AuthorDate: Tue Jan 18 19:49:30 2022 + Fix order to

[tomcat] branch 10.0.x updated (628cfd7 -> 93c7093)

2022-01-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 628cfd7 Align Derby version used with 10.1.x new f0cb9b0 Fix order to support reproducible builds new 93c7

[tomcat] 02/02: Use same options for all Javadoc tasks

2022-01-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git commit bbab94ed3804e5df686febeb284d6a814f81824f Author: Mark Thomas AuthorDate: Tue Jan 18 19:49:48 2022 + Use same optio

[tomcat] branch main updated (21aa5c0 -> bbab94e)

2022-01-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 21aa5c0 Increment version number for next development cycle new 929a34c Fix order to support reproducible builds

Reproducible builds update

2022-01-18 Thread Mark Thomas
Hi all, I've been looking at reproducible builds and my research so far indicates we have the following issues to solve: 1. ObjectReflectionPropertyInspector is not generating consistent code for XReflectionIntrospectionUtils. I think this is due to the various hash based collections returni

[GitHub] [tomcat] cklein05 commented on pull request #463: Add support for additional user attributes to TomcatPrincipal

2022-01-18 Thread GitBox
cklein05 commented on pull request #463: URL: https://github.com/apache/tomcat/pull/463#issuecomment-1015511489 We could always remove the new _attributes_ methods from the `TomcatPricipal` interface and work with class `GenericPrincipal` only. In other words, having these methods declared

[GitHub] [tomcat] michael-o commented on pull request #463: Add support for additional user attributes to TomcatPrincipal

2022-01-18 Thread GitBox
michael-o commented on pull request #463: URL: https://github.com/apache/tomcat/pull/463#issuecomment-101540 > > Is this save to be backported to previous Tomcat versions? > > It should be. I do not see any reasons why this cannot be backported. The big question is here is

[tomcat] branch 8.5.x updated (519c1db -> 024ddaf)

2022-01-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 519c1db Sync with 9.0.x new e97575e Align with 9.0.x new 014f474 Update test/build libraries to as build n

[tomcat] 03/04: Fix IDE warning - removed unnecessary @SuppressWarnings

2022-01-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit a35be38ceef6c2a31b171af12f2ca643f8e1aa52 Author: Mark Thomas AuthorDate: Tue Jan 18 11:36:47 2022 + Fix IDE warni

[tomcat] 04/04: Get tests building with --release=7 and newer test libraries

2022-01-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 024ddaff2cfff88e8fdf06f0db75f45bd3f8dcb1 Author: Mark Thomas AuthorDate: Tue Jan 18 11:37:13 2022 + Get tests bui

[tomcat] 02/04: Update test/build libraries to as build now uses Java 11

2022-01-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 014f4746176c7f27cda7c04b2c6036a539c385ff Author: Mark Thomas AuthorDate: Tue Jan 18 11:36:08 2022 + Update test/b

[tomcat] 01/04: Align with 9.0.x

2022-01-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit e97575e98bbd9af525015249cd8fbaff4955b372 Author: Mark Thomas AuthorDate: Tue Jan 18 09:44:28 2022 + Align with 9.

[tomcat] branch 9.0.x updated: Align Derby version used with 10.1.x and 10.0.x

2022-01-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new a4f1d05 Align Derby version used with 10.1.x and 1

[tomcat] branch 10.0.x updated: Align Derby version used with 10.1.x

2022-01-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 628cfd7 Align Derby version used with 10.1.x 628

[tomcat] branch 8.5.x updated: Sync with 9.0.x

2022-01-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 519c1db Sync with 9.0.x 519c1db is described below

[tomcat] branch 8.5.x updated: Update Travis to build with Java 11

2022-01-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 4cc2f1f Update Travis to build with Java 11 4cc2f1

All current branches building with Java 11

2022-01-18 Thread Mark Thomas
Hi all, I've just completed the switch to building with Java 11 for all currently supported branches. I have performed a spot check on local builds of 10.0.x, 9.0.x and 8.5.x and the Java class version is correct. I am monitoring the CI systems. All looks good for 10.0.x and 9.0.x. Just ne

[tomcat] 03/04: Parameterise the version of Java used to build Tomcat

2022-01-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 3390cb88819f89fa642e44f1463c35cddae74905 Author: Mark Thomas AuthorDate: Thu Jan 13 16:45:41 2022 + Parameterise

[tomcat] 02/04: Switch to building with Java 11 and using --release

2022-01-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 3b68fa6a4632592086cb9dc20118130cc7b9d16e Author: Mark Thomas AuthorDate: Thu Jan 13 16:36:32 2022 + Switch to bui

[tomcat] 04/04: Avoid IDE warnings when configuring Eclipse to use 11 with --release 8

2022-01-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit e2691b759119e27952c03563d0dd312061dbf95b Author: Mark Thomas AuthorDate: Thu Jan 13 16:55:54 2022 + Avoid IDE war

[tomcat] 01/04: Increment version for next development cycle

2022-01-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 8f3a18776d4169c61f72ae41e224dc90eacd1698 Author: Mark Thomas AuthorDate: Tue Jan 18 08:38:02 2022 + Increment ver

[tomcat] branch 8.5.x updated (6c71b4f -> e2691b7)

2022-01-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 6c71b4f Fix server push. Validation will see pseudo headers so should allow them new 8f3a187 Increment version

[tomcat] branch 9.0.x updated: Correct version for code coverage report

2022-01-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new f08219f Correct version for code coverage report f

[tomcat] branch 10.0.x updated: Remove unused configuration

2022-01-18 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 242b227 Remove unused configuration 242b227 is d