cklein05 commented on pull request #463: URL: https://github.com/apache/tomcat/pull/463#issuecomment-1015511489
We could always remove the new _attributes_ methods from the `TomcatPricipal` interface and work with class `GenericPrincipal` only. In other words, having these methods declared on the interface is not crucial for the enhancement. In that case, we just need to update the `instanceof` check in the modified JSP example at /examples/jsp/security/protected as well as the documentation (and example code) under _Common Features / Additional User Attributes_ in realm-howto.xml (both not yet committed). BTW, shouldn't we commit/merge the example mentioned above with this PR? Listing the Principal's additional attributes is completely independent from the Realm implementations. The same is likely true for the new _Common Features / Additional User Attributes_ section in realm-howto.xml. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
