Re: Weak digital signature on tomcatX.exe

2022-01-12 Thread Mark Thomas
On 13/01/2022 01:35, Christopher Schultz wrote: All, Having just done the release build for Tomcat 8.5, I was checking to ensure that the various digital signatures were done properly on the .exe files we produce as a part of that build. I happened to check tomcat8.exe and it's got a sha1 si

[GitHub] [tomcat] cklein05 commented on a change in pull request #463: Add support for additional user attributes to TomcatPrincipal

2022-01-12 Thread GitBox
cklein05 commented on a change in pull request #463: URL: https://github.com/apache/tomcat/pull/463#discussion_r783661408 ## File path: java/org/apache/catalina/TomcatPrincipal.java ## @@ -47,4 +48,37 @@ * exception to LoginContext */ void log

[GitHub] [tomcat] cklein05 commented on pull request #463: Add support for additional user attributes to TomcatPrincipal

2022-01-12 Thread GitBox
cklein05 commented on pull request #463: URL: https://github.com/apache/tomcat/pull/463#issuecomment-1011828970 > Is this save to be backported to previous Tomcat versions? It should be. I do not see any reasons why this cannot be backported. -- This is an automated message from th

Weak digital signature on tomcatX.exe

2022-01-12 Thread Christopher Schultz
All, Having just done the release build for Tomcat 8.5, I was checking to ensure that the various digital signatures were done properly on the .exe files we produce as a part of that build. I happened to check tomcat8.exe and it's got a sha1 signature instead of a sha512 signature like the o

svn commit: r52051 [2/2] - in /dev/tomcat/tomcat-8/v8.5.74: ./ bin/ bin/embed/ bin/extras/ src/

2022-01-12 Thread schultz
Added: dev/tomcat/tomcat-8/v8.5.74/bin/extras/catalina-jmx-remote.jar.asc == --- dev/tomcat/tomcat-8/v8.5.74/bin/extras/catalina-jmx-remote.jar.asc (added) +++ dev/tomcat/tomcat-8/v8.5.74/bin/extras/catalina-jmx-remote.jar.

svn commit: r52051 [1/2] - in /dev/tomcat/tomcat-8/v8.5.74: ./ bin/ bin/embed/ bin/extras/ src/

2022-01-12 Thread schultz
Author: schultz Date: Thu Jan 13 01:22:17 2022 New Revision: 52051 Log: Upload v8.5.74 for voting Added: dev/tomcat/tomcat-8/v8.5.74/ dev/tomcat/tomcat-8/v8.5.74/KEYS dev/tomcat/tomcat-8/v8.5.74/README.html dev/tomcat/tomcat-8/v8.5.74/RELEASE-NOTES dev/tomcat/tomcat-8/v8.5.74/

[VOTE] Release Apache Tomcat 9.0.57

2022-01-12 Thread Rémy Maucherat
The proposed Apache Tomcat 9.0.57 release is now available for voting. The notable changes compared to 9.0.57 are: - Add recycling check in the input and output stream isReady to try to give a more informative ISE when the facade has been recycled. - Implement support for HTTP/1.1 upgrade whe

[tomcat] 03/03: Update (currently unused) reproducible build timestamp

2022-01-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 09db648ff9e721c924d639ecfd8bfe5631e1b797 Author: Mark Thomas AuthorDate: Wed Jan 12 16:04:39 2022 + Update (curre

[tomcat] 02/03: Fix tests failing on Windows Server 2022

2022-01-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit a8046266aaa6c92c38242a74b00cfd7795c1bff3 Author: Mark Thomas AuthorDate: Wed Jan 12 15:14:27 2022 + Fix tests fai

[tomcat] 01/03: Reduce default timeouts for test client from infinite to 5 seconds.

2022-01-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 0cdfed957e0ce6aa5e6706174ead7aaaeddbea83 Author: Mark Thomas AuthorDate: Wed Jan 12 13:57:33 2022 + Reduce defaul

[tomcat] branch 8.5.x updated (9794395 -> 09db648)

2022-01-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 9794395 Make calculation of session storage location more robust new 0cdfed9 Reduce default timeouts for test cl

[tomcat] 01/01: Tag 8.5.74

2022-01-12 Thread schultz
This is an automated email from the ASF dual-hosted git repository. schultz pushed a commit to tag 8.5.74 in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 2ea50557ae05ccfca7f521ab328c238237aec8b1 Author: schultz AuthorDate: Wed Jan 12 12:59:34 2022 -0800 Tag 8.5.74 --- b

[tomcat] tag 8.5.74 created (now 2ea5055)

2022-01-12 Thread schultz
This is an automated email from the ASF dual-hosted git repository. schultz pushed a change to tag 8.5.74 in repository https://gitbox.apache.org/repos/asf/tomcat.git. at 2ea5055 (commit) This tag includes the following new commits: new 2ea5055 Tag 8.5.74 The 1 revisions listed ab

Re: Building all releases with Java 11

2022-01-12 Thread Mark Thomas
On 12/01/2022 19:59, Christopher Schultz wrote: Mark, On 1/12/22 13:36, Mark Thomas wrote: On 12/01/2022 17:29, Christopher Schultz wrote: On 1/10/22 11:46, Mark Thomas wrote: So, as a first step, I intend to completely remove the JMXLifecycleListener. Are all those various system prope

svn commit: r52047 - in /dev/tomcat/tomcat-9/v9.0.57: ./ bin/ bin/embed/ src/

2022-01-12 Thread remm
Author: remm Date: Wed Jan 12 20:04:46 2022 New Revision: 52047 Log: Upload 9.0.57 for voting Added: dev/tomcat/tomcat-9/v9.0.57/ dev/tomcat/tomcat-9/v9.0.57/KEYS dev/tomcat/tomcat-9/v9.0.57/README.html dev/tomcat/tomcat-9/v9.0.57/RELEASE-NOTES dev/tomcat/tomcat-9/v9.0.57/bin/

Re: Building all releases with Java 11

2022-01-12 Thread Christopher Schultz
Mark, On 1/12/22 13:36, Mark Thomas wrote: On 12/01/2022 17:29, Christopher Schultz wrote: On 1/10/22 11:46, Mark Thomas wrote: So, as a first step, I intend to completely remove the JMXLifecycleListener. Are all those various system properties available in recent releases of Java 7? I

[tomcat] branch 9.0.x updated: Increment version

2022-01-12 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 4a5e16d Increment version 4a5e16d is described belo

[tomcat] tag 9.0.57 created (now eb57341)

2022-01-12 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a change to tag 9.0.57 in repository https://gitbox.apache.org/repos/asf/tomcat.git. at eb57341 (commit) This tag includes the following new commits: new eb57341 Tag 9.0.57 The 1 revisions listed above

[tomcat] 01/01: Tag 9.0.57

2022-01-12 Thread remm
This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to tag 9.0.57 in repository https://gitbox.apache.org/repos/asf/tomcat.git commit eb57341d04ac6f770c50d9cee70e6e13b96cd8af Author: remm AuthorDate: Wed Jan 12 20:51:59 2022 +0100 Tag 9.0.57 --- build.p

[tomcat] branch 10.0.x updated: Increment version for next development cycle

2022-01-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 08ff835 Increment version for next development c

[VOTE] Release Apache Tomcat 10.0.15

2022-01-12 Thread Mark Thomas
The proposed Apache Tomcat 10.0.15 release is now available for voting. Apache Tomcat 10.x implements Jakarta EE 9 and, as such, the primary package for all the specification APIs has changed from javax.* to jakarta.* Applications that run on Tomcat 9 will not run on Tomcat 10 without changes.

svn commit: r52046 - in /dev/tomcat/tomcat-10/v10.0.15: ./ bin/ bin/embed/ src/

2022-01-12 Thread markt
Author: markt Date: Wed Jan 12 19:27:40 2022 New Revision: 52046 Log: Upload 10.0.15 for voting Added: dev/tomcat/tomcat-10/v10.0.15/ dev/tomcat/tomcat-10/v10.0.15/KEYS dev/tomcat/tomcat-10/v10.0.15/README.html dev/tomcat/tomcat-10/v10.0.15/RELEASE-NOTES dev/tomcat/tomcat-10/v

Re: Building all releases with Java 11

2022-01-12 Thread Rémy Maucherat
On Wed, Jan 12, 2022 at 7:00 PM Mark Thomas wrote: > > On 11/01/2022 10:34, Michael Osipov wrote: > > Am 2022-01-10 um 17:46 schrieb Mark Thomas: > >> [...] > > > > Is this because of EJC going Java 11? > > No. > > > Has anyone reached out to them? > > No. Having read the thread I don't think anyt

[tomcat] 01/01: Tag 10.0.15

2022-01-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to tag 10.0.15 in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 3265e95e46f9d03589e3ac9a2385ba70e5efd621 Author: Mark Thomas AuthorDate: Wed Jan 12 19:13:54 2022 + Tag 10.0.15 --

[tomcat] tag 10.0.15 created (now 3265e95)

2022-01-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to tag 10.0.15 in repository https://gitbox.apache.org/repos/asf/tomcat.git. at 3265e95 (commit) This tag includes the following new commits: new 3265e95 Tag 10.0.15 The 1 revisions listed ab

[tomcat] 03/03: Update (currently unused) reproducible build timestamp

2022-01-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 974b78d29ccb7610fe0d6b5c36541da2242f8614 Author: Mark Thomas AuthorDate: Wed Jan 12 16:04:39 2022 + Update (curre

[tomcat] 02/03: Fix tests failing on Windows Server 2022

2022-01-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 70fa3d3cf524a069299cf3070a27c496d3e836f3 Author: Mark Thomas AuthorDate: Wed Jan 12 15:14:27 2022 + Fix tests fai

[tomcat] 01/03: Reduce default timeouts for test client from infinite to 5 seconds.

2022-01-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 7146b0aca22b5c65d1ae62c092e65ff74c69bbf3 Author: Mark Thomas AuthorDate: Wed Jan 12 13:57:33 2022 + Reduce defaul

[tomcat] branch 9.0.x updated (1385c62 -> 974b78d)

2022-01-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 1385c62 Make calculation of session storage location more robust new 7146b0a Reduce default timeouts for test cl

Re: Building all releases with Java 11

2022-01-12 Thread Mark Thomas
On 12/01/2022 17:29, Christopher Schultz wrote: On 1/10/22 11:46, Mark Thomas wrote: So, as a first step, I intend to completely remove the JMXLifecycleListener. Are all those various system properties available in recent releases of Java 7? I wouldn't want to trap users of Tomcat 8.5 on

[Bug 65779] Introduce CATALINA_BASE_DATA

2022-01-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65779 --- Comment #4 from Gael Lalire --- I think there is no point to show generated data to the tomcat user. The conf directory is what is shown to the user. There is conf he can modified and webapp where he can copy his WARs. If you show the gen

Re: Building all releases with Java 11

2022-01-12 Thread Mark Thomas
On 11/01/2022 10:34, Michael Osipov wrote: Am 2022-01-10 um 17:46 schrieb Mark Thomas: [...] Is this because of EJC going Java 11? No. Has anyone reached out to them? No. Having read the thread I don't think anything we could say would cause them to reverse their decision. Why 11?

Re: Sensitive session cookies on error are exposed by the parser

2022-01-12 Thread Christopher Schultz
Joscha, On 1/11/22 09:50, Joscha Cepok wrote: But there is maybe another approach, during my research I encountered most time one of two cases: timestamp; key1=value1; key2=value2;... OR key1=value1; key2=value2;...;timestamp I didn't take a deeper look, why browsers add the timestamp to th

[VOTE] Release Apache Tomcat 10.1.0-M9

2022-01-12 Thread Mark Thomas
The proposed Apache Tomcat 10.1.0-M9 release is now available for voting. Applications that run on Tomcat 9 and earlier will not run on Tomcat 10 without changes. Java EE applications designed for Tomcat 9 and earlier may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat will

[Bug 65779] Introduce CATALINA_BASE_DATA

2022-01-12 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=65779 Christopher Schultz changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #3 from Chr

Re: Building all releases with Java 11

2022-01-12 Thread Christopher Schultz
Mark, On 1/10/22 11:46, Mark Thomas wrote: I thought it would be a good idea to start a new thread for this. The previous discussion started here: https://markmail.org/message/e7rsryympb2cephp I've done some testing with Tomcat 8.5.x For the Java 7 to Java 8 transition, the problematic code i

[tomcat] branch main updated: Increment version for next development cycle

2022-01-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 13370ee Increment version for next development cycle

svn commit: r52043 - in /dev/tomcat/tomcat-10/v10.1.0-M9: ./ bin/ bin/embed/ src/

2022-01-12 Thread markt
Author: markt Date: Wed Jan 12 17:17:02 2022 New Revision: 52043 Log: Upload 10.1.0-M9 for voting Added: dev/tomcat/tomcat-10/v10.1.0-M9/ dev/tomcat/tomcat-10/v10.1.0-M9/KEYS dev/tomcat/tomcat-10/v10.1.0-M9/README.html dev/tomcat/tomcat-10/v10.1.0-M9/RELEASE-NOTES dev/tomcat/t

[tomcat] 02/03: Fix tests failing on Windows Server 2022

2022-01-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 42e78d2c6f9e0ebe8217ef28af8b53c046dd41c5 Author: Mark Thomas AuthorDate: Wed Jan 12 15:14:27 2022 + Fix tests fa

[tomcat] 03/03: Update (currently unused) reproducible build timestamp

2022-01-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit d67104f4d3389dfe01f11f9a23555dd8363ef29b Author: Mark Thomas AuthorDate: Wed Jan 12 16:04:39 2022 + Update (curr

[tomcat] 01/03: Reduce default timeouts for test client from infinite to 5 seconds.

2022-01-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 0256b1d0592314d2ecadec4f0edabecef4c4b787 Author: Mark Thomas AuthorDate: Wed Jan 12 13:57:33 2022 + Reduce defau

[tomcat] branch 10.0.x updated (094800b -> d67104f)

2022-01-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 094800b Make calculation of session storage location more robust new 0256b1d Reduce default timeouts for test c

[tomcat] 01/01: Tag 10.1.0-M9

2022-01-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to tag 10.1.0-M9 in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 02d546ba3c553c74ff1a99ecc166a6ff9c501ba8 Author: Mark Thomas AuthorDate: Wed Jan 12 16:07:16 2022 + Tag 10.1.0-M

[tomcat] tag 10.1.0-M9 created (now 02d546b)

2022-01-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to tag 10.1.0-M9 in repository https://gitbox.apache.org/repos/asf/tomcat.git. at 02d546b (commit) This tag includes the following new commits: new 02d546b Tag 10.1.0-M9 The 1 revisions liste

[tomcat] branch main updated: Update (currently unused) reproducible buidl timestamp

2022-01-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new bfa944b Update (currently unused) reproducible buidl

[GitHub] [tomcat] cklein05 commented on a change in pull request #463: Add support for additional user attributes to TomcatPrincipal

2022-01-12 Thread GitBox
cklein05 commented on a change in pull request #463: URL: https://github.com/apache/tomcat/pull/463#discussion_r783215387 ## File path: java/org/apache/catalina/realm/GenericPrincipal.java ## @@ -171,6 +176,7 @@ public GenericPrincipal(String name, List roles, }

[GitHub] [tomcat] cklein05 commented on a change in pull request #463: Add support for additional user attributes to TomcatPrincipal

2022-01-12 Thread GitBox
cklein05 commented on a change in pull request #463: URL: https://github.com/apache/tomcat/pull/463#discussion_r783208291 ## File path: java/org/apache/catalina/TomcatPrincipal.java ## @@ -47,4 +48,37 @@ * exception to LoginContext */ void log

[GitHub] [tomcat] cklein05 commented on a change in pull request #463: Add support for additional user attributes to TomcatPrincipal

2022-01-12 Thread GitBox
cklein05 commented on a change in pull request #463: URL: https://github.com/apache/tomcat/pull/463#discussion_r783207980 ## File path: java/org/apache/catalina/TomcatPrincipal.java ## @@ -47,4 +48,37 @@ * exception to LoginContext */ void log

Re: Unit tests hanging on Windows

2022-01-12 Thread Mark Thomas
On 12/01/2022 14:38, Mark Thomas wrote: On 12/01/2022 13:11, Mark Thomas wrote: I'm trying to run the unit tests before I tag and they are consistently hanging on Windows. Anyone else seen this recently? Just starting to dig into the root cause. No data yet. A little progress. Infinite clie

[GitHub] [tomcat] cklein05 commented on a change in pull request #463: Add support for additional user attributes to TomcatPrincipal

2022-01-12 Thread GitBox
cklein05 commented on a change in pull request #463: URL: https://github.com/apache/tomcat/pull/463#discussion_r783204725 ## File path: java/org/apache/catalina/realm/GenericPrincipal.java ## @@ -171,6 +176,7 @@ public GenericPrincipal(String name, List roles, }

[GitHub] [tomcat] cklein05 commented on a change in pull request #463: Add support for additional user attributes to TomcatPrincipal

2022-01-12 Thread GitBox
cklein05 commented on a change in pull request #463: URL: https://github.com/apache/tomcat/pull/463#discussion_r783200198 ## File path: java/org/apache/catalina/realm/GenericPrincipal.java ## @@ -283,10 +294,16 @@ public boolean hasRole(String role) { @Override public

[GitHub] [tomcat] michael-o commented on a change in pull request #463: Add support for additional user attributes to TomcatPrincipal

2022-01-12 Thread GitBox
michael-o commented on a change in pull request #463: URL: https://github.com/apache/tomcat/pull/463#discussion_r783189035 ## File path: java/org/apache/catalina/realm/GenericPrincipal.java ## @@ -171,6 +176,7 @@ public GenericPrincipal(String name, List roles, }

[GitHub] [tomcat] cklein05 commented on pull request #428: Enhancement: Additional user attributes queried by (some) realms

2022-01-12 Thread GitBox
cklein05 commented on pull request #428: URL: https://github.com/apache/tomcat/pull/428#issuecomment-1011154379 @michael-o So, lets move to new PR https://github.com/apache/tomcat/pull/463 -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[tomcat] branch main updated (bcdb7d0 -> ddb789e)

2022-01-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git. from bcdb7d0 Reduce default timeouts for test client from infinite to 5 seconds. add ddb789e Fix tests failing on Win

[GitHub] [tomcat] cklein05 edited a comment on pull request #428: Enhancement: Additional user attributes queried by (some) realms

2022-01-12 Thread GitBox
cklein05 edited a comment on pull request #428: URL: https://github.com/apache/tomcat/pull/428#issuecomment-1011133201 So, lets move to new PR https://github.com/apache/tomcat/pull/463 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [tomcat] cklein05 opened a new pull request #463: Add support for additional user attributes to TomcatPrincipal

2022-01-12 Thread GitBox
cklein05 opened a new pull request #463: URL: https://github.com/apache/tomcat/pull/463 Add support for additional user attributes to the `TomcatPrincipal` interface and the `GenericPrincipal` class. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [tomcat] cklein05 commented on pull request #428: Enhancement: Additional user attributes queried by (some) realms

2022-01-12 Thread GitBox
cklein05 commented on pull request #428: URL: https://github.com/apache/tomcat/pull/428#issuecomment-1011133201 So, lets move to a ne PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [tomcat] michael-o commented on pull request #428: Enhancement: Additional user attributes queried by (some) realms

2022-01-12 Thread GitBox
michael-o commented on pull request #428: URL: https://github.com/apache/tomcat/pull/428#issuecomment-1011131637 > @michael-o [That's](https://github.com/cklein05/tomcat/tree/user-attributes-principal) what you meant? Did not yet create a PR in your repo. > > https://github.com/ckle

[GitHub] [tomcat] cklein05 commented on pull request #428: Enhancement: Additional user attributes queried by (some) realms

2022-01-12 Thread GitBox
cklein05 commented on pull request #428: URL: https://github.com/apache/tomcat/pull/428#issuecomment-1011126834 @michael-o [That's](https://github.com/cklein05/tomcat/tree/user-attributes-principal) what you meant? Did not yet create a PR in your repo. https://github.com/cklein05/

[GitHub] [tomcat] cklein05 commented on pull request #428: Enhancement: Additional user attributes queried by (some) realms

2022-01-12 Thread GitBox
cklein05 commented on pull request #428: URL: https://github.com/apache/tomcat/pull/428#issuecomment-1011124889 [That's](https://github.com/cklein05/tomcat/tree/user-attributes-principal) what you meant? Did not yet create a PR in your repo. -- This is an automated message from the Apach

Re: Unit tests hanging on Windows

2022-01-12 Thread Mark Thomas
On 12/01/2022 13:11, Mark Thomas wrote: I'm trying to run the unit tests before I tag and they are consistently hanging on Windows. Anyone else seen this recently? Just starting to dig into the root cause. No data yet. A little progress. Infinite client timeouts were the cause of the hang. I

[tomcat] branch main updated: Reduce default timeouts for test client from infinite to 5 seconds.

2022-01-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new bcdb7d0 Reduce default timeouts for test client from

[GitHub] [tomcat] cklein05 commented on pull request #428: Enhancement: Additional user attributes queried by (some) realms

2022-01-12 Thread GitBox
cklein05 commented on pull request #428: URL: https://github.com/apache/tomcat/pull/428#issuecomment-1011048516 @michael-o You mean the `TomcatPrincipal` interface and the `GenericPrincipal` class? Or really only the interfaces? `TomcatPrincipal` is the only interface changed by this enhan

[GitHub] [tomcat] michael-o commented on pull request #428: Enhancement: Additional user attributes queried by (some) realms

2022-01-12 Thread GitBox
michael-o commented on pull request #428: URL: https://github.com/apache/tomcat/pull/428#issuecomment-1011036905 @cklein05 Let's start with the principals (interfaces) first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub an

Unit tests hanging on Windows

2022-01-12 Thread Mark Thomas
I'm trying to run the unit tests before I tag and they are consistently hanging on Windows. Anyone else seen this recently? Just starting to dig into the root cause. No data yet. Mark - To unsubscribe, e-mail: dev-unsubscr...@

[GitHub] [tomcat] cklein05 commented on pull request #428: Enhancement: Additional user attributes queried by (some) realms

2022-01-12 Thread GitBox
cklein05 commented on pull request #428: URL: https://github.com/apache/tomcat/pull/428#issuecomment-1011029311 @michael-o Yes, we could. What exactly do you mean with _RealmBase groundwork_? There is not much in RealmBase. It's only the `parseUserAttributes` and `validateUserAttributes

[GitHub] [tomcat] michael-o commented on pull request #428: Enhancement: Additional user attributes queried by (some) realms

2022-01-12 Thread GitBox
michael-o commented on pull request #428: URL: https://github.com/apache/tomcat/pull/428#issuecomment-1011022441 @cklein05 I know, it is quite some work, but can we stick to my proposal here: https://github.com/apache/tomcat/pull/428#issuecomment-1008027903? This will break up thi

[GitHub] [tomcat] cklein05 commented on pull request #428: Enhancement: Additional user attributes queried by (some) realms

2022-01-12 Thread GitBox
cklein05 commented on pull request #428: URL: https://github.com/apache/tomcat/pull/428#issuecomment-1011006425 @michael-o files to skip: ``` java/org/apache/catalina/User.java java/org/apache/catalina/realm/MemoryRealm.java java/org/apache/catalina/realm/MemoryRuleSet.java

[GitHub] [tomcat] rmaucher commented on pull request #428: Enhancement: Additional user attributes queried by (some) realms

2022-01-12 Thread GitBox
rmaucher commented on pull request #428: URL: https://github.com/apache/tomcat/pull/428#issuecomment-1010987799 @michael-o It should be easy to merge only the files you want to merge, all the realms are independent. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [tomcat] rmaucher commented on pull request #428: Enhancement: Additional user attributes queried by (some) realms

2022-01-12 Thread GitBox
rmaucher commented on pull request #428: URL: https://github.com/apache/tomcat/pull/428#issuecomment-1010970627 I will oppose changes to the MemoryRealm and the UserDatabase realm, and I will ignore this topic for the two other realms (so I will not veto it either). -- This is an automat

[GitHub] [tomcat] cklein05 commented on pull request #428: Enhancement: Additional user attributes queried by (some) realms

2022-01-12 Thread GitBox
cklein05 commented on pull request #428: URL: https://github.com/apache/tomcat/pull/428#issuecomment-1010954501 @rmaucher I'm with @michael-o here. Having these extra attributes with the Principal is useful per se. Since any Realm can log you on and create a Principal, it should not ma

[GitHub] [tomcat] michael-o commented on pull request #428: Enhancement: Additional user attributes queried by (some) realms

2022-01-12 Thread GitBox
michael-o commented on pull request #428: URL: https://github.com/apache/tomcat/pull/428#issuecomment-1010938331 Waiting for @rmaucher answer for my last proposal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[tomcat] branch 9.0.x updated: Make calculation of session storage location more robust

2022-01-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 1385c62 Make calculation of session storage locati

[tomcat] branch 8.5.x updated: Make calculation of session storage location more robust

2022-01-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 9794395 Make calculation of session storage locati

[tomcat] branch 10.0.x updated: Make calculation of session storage location more robust

2022-01-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 094800b Make calculation of session storage loca

[tomcat] branch main updated: Make calculation of session storage location more robust

2022-01-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/main by this push: new 70da1aa Make calculation of session storage location

[tomcat] branch 8.5.x updated: Make test more robust

2022-01-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new 0adacdd Make test more robust 0adacdd is described

[tomcat] branch 9.0.x updated: Make test more robust

2022-01-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 9.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/9.0.x by this push: new 724a86e Make test more robust 724a86e is described

[tomcat] branch 10.0.x updated: Remove test code

2022-01-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 4719c4c Remove test code 4719c4c is described be

[tomcat] branch main updated (bb74265 -> ede3616)

2022-01-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git. from bb74265 Make test more robust add ede3616 Remove test code No new revisions were added by this update. Summary

[tomcat] branch 10.0.x updated: Make test more robust

2022-01-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 10.0.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/10.0.x by this push: new 1bee7a9 Make test more robust 1bee7a9 is describ

[tomcat] branch main updated (83bb6fc -> bb74265)

2022-01-12 Thread markt
This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch main in repository https://gitbox.apache.org/repos/asf/tomcat.git. from 83bb6fc Update copyright dates to 2022 add bb74265 Make test more robust No new revisions were added by this upd

[GitHub] [tomcat] cklein05 commented on pull request #428: Enhancement: Additional user attributes queried by (some) realms

2022-01-12 Thread GitBox
cklein05 commented on pull request #428: URL: https://github.com/apache/tomcat/pull/428#issuecomment-1010897315 @michael-o Rebase is done and the enhancement was successfully tested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on