cklein05 commented on a change in pull request #463:
URL: https://github.com/apache/tomcat/pull/463#discussion_r783204725
##########
File path: java/org/apache/catalina/realm/GenericPrincipal.java
##########
@@ -171,6 +176,7 @@ public GenericPrincipal(String name, List<String> roles,
}
this.loginContext = loginContext;
this.gssCredential = gssCredential;
+ this.attributes = attributes;
Review comment:
AFAIK we agreed on not using an unmodifiable map, since there is no
write access to this map. However, we could, of course, if you like so. Maybe
it's worth checking if it's already an instance of
`java.util.Collections.UnmodifiableMap` first. If not, we could wrap it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
