ChristopherSchultz commented on pull request #456:
URL: https://github.com/apache/tomcat/pull/456#issuecomment-955018111
Your test-case looks even more complicated than necessary: just initialize
two of them then deinitialize them. No shutdown hook necessary, right?
Okay, so it's not
michael-o commented on pull request #456:
URL: https://github.com/apache/tomcat/pull/456#issuecomment-954959277
@ChristopherSchultz Here is an extremely primitive test case:
```java
public class TomcatEmbeddedTest {
static class ShutdownHook2 extends Thread {
michael-o commented on pull request #456:
URL: https://github.com/apache/tomcat/pull/456#issuecomment-954947125
>
>
> > [...] so the second Tomcat now shuts down APR globally, releasing the
global structures. The first Tomcat is now shutting down, its `AprConnector`
tries to use a
ChristopherSchultz edited a comment on pull request #456:
URL: https://github.com/apache/tomcat/pull/456#issuecomment-954934999
> [...] so the second Tomcat now shuts down APR globally, releasing the
global structures. The first Tomcat is now shutting down, its `AprConnector`
tries to use
ChristopherSchultz commented on pull request #456:
URL: https://github.com/apache/tomcat/pull/456#issuecomment-954934999
> [...] so the second Tomcat now shuts down APR globally, releasing the
global structures. The first Tomcat is now shutting down, its `AprConnector`
tries to use a sub A
michael-o commented on pull request #456:
URL: https://github.com/apache/tomcat/pull/456#issuecomment-954912903
@wilkinsona Correct. The connector on main Tomcat is still active while APR
is already gone.
--
This is an automated message from the Apache Git Service.
To respond to the mess
wilkinsona commented on pull request #456:
URL: https://github.com/apache/tomcat/pull/456#issuecomment-954908926
I agree, @ChristopherSchultz. IMO, the second `AprLifecycleListener` should
not be shutting down APR if it did nothing when asked to initialize it.
The ordering in Spring
michael-o commented on pull request #456:
URL: https://github.com/apache/tomcat/pull/456#issuecomment-954898919
>
>
> Something is wrong with the premise, here. I read through
[Spring-28472](https://github.com/spring-projects/spring-boot/issues/28472) and
looked at the code for `Ap
ChristopherSchultz commented on pull request #456:
URL: https://github.com/apache/tomcat/pull/456#issuecomment-954890217
Something is wrong with the premise, here. I read through
[Spring-28472](https://github.com/spring-projects/spring-boot/issues/28472) and
looked at the code for `AprLife
On 29/10/2021 11:56, Jochen Wiedmann wrote:
Hi, Mark,
yes, I *did* try to read the documentation. Problem is, if you don't know exactly, what
you are looking for, things are hard to found. (The word "path" is used
frequently, so Google won't help.)
If you are looking for an explanation of a
michael-o edited a comment on pull request #456:
URL: https://github.com/apache/tomcat/pull/456#issuecomment-954648720
>
>
> This feels like a step forwards, but ideally one that will be reverted in
the future as AprLifecycleListener is made more robust. It's difficult to gauge
the
michael-o commented on a change in pull request #456:
URL: https://github.com/apache/tomcat/pull/456#discussion_r739135782
##
File path: java/org/apache/catalina/core/AprLifecycleListener.java
##
@@ -38,6 +38,13 @@
/**
* Implementation of LifecycleListener that will init and
michael-o commented on a change in pull request #456:
URL: https://github.com/apache/tomcat/pull/456#discussion_r739135782
##
File path: java/org/apache/catalina/core/AprLifecycleListener.java
##
@@ -38,6 +38,13 @@
/**
* Implementation of LifecycleListener that will init and
michael-o commented on pull request #456:
URL: https://github.com/apache/tomcat/pull/456#issuecomment-954648720
>
>
> This feels like a step forwards, but ideally one that will be reverted in
the future as AprLifecycleListener is made more robust. It's difficult to gauge
the need f
Hi, Mark,
yes, I *did* try to read the documentation. Problem is, if you don't know
exactly, what you are looking for, things are hard to found. (The word "path"
is used frequently, so Google won't help.)
that said: Thanks for your reply, which provided all the information, that I
need.
Joc
wilkinsona commented on a change in pull request #456:
URL: https://github.com/apache/tomcat/pull/456#discussion_r739128184
##
File path: java/org/apache/catalina/core/AprLifecycleListener.java
##
@@ -38,6 +38,13 @@
/**
* Implementation of LifecycleListener that will init an
On 29/10/2021 10:22, Jochen Wiedmann wrote:
Hi,
I am an occasional contributor to the Tomcat Eclipse Plugin [1]. One
nice thing, that the plugin does is, that it creates a Context.xml for
you, so that you can have the webapp in-place while
developing. Right now, that Context.xml would look like
Hi,
I am an occasional contributor to the Tomcat Eclipse Plugin [1]. One
nice thing, that the plugin does is, that it creates a Context.xml for
you, so that you can have the webapp in-place while
developing. Right now, that Context.xml would look like this:
Well, with recent Tomcat versions, th
michael-o opened a new pull request #456:
URL: https://github.com/apache/tomcat/pull/456
…to avoid JVM crashes
This basically document cases to avoid issues like
https://github.com/spring-projects/spring-boot/issues/28472
--
This is an automated message from the Apache Git Servi
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new 240e93e Improve robustness
240e93e is described bel
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 0df6494 Improve robustness
0df6494 is described bel
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 10.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/10.0.x by this push:
new 0781316 Improve robustness
0781316 is described b
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/main by this push:
new 67743cd Improve robustness
67743cd is described below
23 matches
Mail list logo
