michael-o commented on a change in pull request #456:
URL: https://github.com/apache/tomcat/pull/456#discussion_r739135782
##########
File path: java/org/apache/catalina/core/AprLifecycleListener.java
##########
@@ -38,6 +38,13 @@
/**
* Implementation of <code>LifecycleListener</code> that will init and
* and destroy APR.
+ * <p>
+ * <strong>Note</strong>: This listener must only be used within a {@code
Server}
+ * element to manage APR/OpenSSL init and destroy JVM-wide. If you are running
+ * Tomcat in an embedded fashion and have more than one Tomcat instance per
JVM,
+ * this listener <em>must not</em> be added to the {@code Server} instance, but
Review comment:
I almost agree with your statement. What would you change in the
documentation if the code remains the same? At least the current contract is
fully defined.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
