This is an automated email from the ASF dual-hosted git repository.
mgrigorov pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git
The following commit(s) were added to refs/heads/master by this push:
new 7d180b2 Convert the java
martin-g commented on pull request #7:
URL:
https://github.com/apache/tomcat-jakartaee-migration/pull/7#issuecomment-752351427
Thank you, @alitokmen !
This is an automated message from the Apache Git Service.
To respond to t
martin-g merged pull request #7:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/7
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
alitokmen opened a new pull request #7:
URL: https://github.com/apache/tomcat-jakartaee-migration/pull/7
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
On Tue, Dec 29, 2020 at 11:03 PM wrote:
> This is an automated email from the ASF dual-hosted git repository.
>
> ebourg pushed a commit to branch master
> in repository
> https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git
>
>
> The following commit(s) were added to refs/heads/mas
This is an automated email from the ASF dual-hosted git repository.
ebourg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat-jakartaee-migration.git
The following commit(s) were added to refs/heads/master by this push:
new c094325 Convert the javax.j
ebourg closed issue #6:
URL: https://github.com/apache/tomcat-jakartaee-migration/issues/6
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
alitokmen opened a new issue #6:
URL: https://github.com/apache/tomcat-jakartaee-migration/issues/6
Currently, the Jakarta EE migration tool seems to be leaving definitions in
`web.xml` such as the below untouched:
```
The test JMS queue
jms/MyQueue
javax.j
arjantijms commented on pull request #399:
URL: https://github.com/apache/tomcat/pull/399#issuecomment-752229567
> It's hard to see how this concept can ever be a good idea.
I personally think it's a brilliant idea. Then again, I'm probably biased ;)
rmaucher commented on pull request #399:
URL: https://github.com/apache/tomcat/pull/399#issuecomment-752216538
The plan was to keep the Servlet container implementation classes away from
the webapps, so this is a request to do the opposite. It's hard to see how this
concept can ever be a g
rmannibucau commented on pull request #399:
URL: https://github.com/apache/tomcat/pull/399#issuecomment-752179364
@markt-asf can we add a org.apache.catalina.api.Unwrappable and make the
facade objects impl it? Would it be an option?
---
rmannibucau commented on pull request #399:
URL: https://github.com/apache/tomcat/pull/399#issuecomment-752178778
@arjantijms maybe test the type and throw an exception with the request type
when it is not a wrapper, some people do it :angel: ;)
---
arjantijms commented on pull request #399:
URL: https://github.com/apache/tomcat/pull/399#issuecomment-752177666
@rmannibucau oh yeah, of course, then it won't work. It'll throw an
exception, so at least you know it won't work ;)
`requestInitialized()` is really early though, so in m
rmannibucau commented on pull request #399:
URL: https://github.com/apache/tomcat/pull/399#issuecomment-752173068
@arjantijms when you can't cast the request because a filter/valve wrapped
it (even if a bit nasty for valves it can happen) which is not uncommon for
session distribution, se
arjantijms commented on pull request #399:
URL: https://github.com/apache/tomcat/pull/399#issuecomment-752169165
> being said the getRequest() does not really work in all cases in your
example
In what cases doesn't it work?
> Guess a sane EE way to solve that is to propose to
rmannibucau commented on pull request #399:
URL: https://github.com/apache/tomcat/pull/399#issuecomment-752093847
Guess a sane EE way to solve that is to propose to servlet spec to add an
unwrap(Class type) method in most of its objects (or Unwrappable instance).
It would solve a lot of
arjantijms commented on pull request #399:
URL: https://github.com/apache/tomcat/pull/399#issuecomment-752074636
> I share the concern that adding a getRequest() method may undermine the
use of a facade.
Isn't the facade intended as a service to the user to not accidentally
access s
arjantijms commented on pull request #399:
URL: https://github.com/apache/tomcat/pull/399#issuecomment-752072520
I'll investigate the application specific Valve. Can META-INF/context.xml
exist on the class path as well, or does it have to be inside [war
root]/META-INF?
> Use reflect
The Buildbot has detected a restored build on builder tomcat-85-trunk while
building tomcat. Full details are available at:
https://ci.apache.org/builders/tomcat-85-trunk/builds/2577
Buildbot URL: https://ci.apache.org/
Buildslave for this Build: asf946_ubuntu
Build Reason: The AnyBranchSch
markt-asf commented on pull request #399:
URL: https://github.com/apache/tomcat/pull/399#issuecomment-752030086
Valves can be installed via a WAR. You can specify an application specific
Valve in a META-INF/context.xml file included in the WAR.
I share the concern that adding a getReques
The Buildbot has detected a restored build on builder tomcat-9-trunk while
building tomcat. Full details are available at:
https://ci.apache.org/builders/tomcat-9-trunk/builds/588
Buildbot URL: https://ci.apache.org/
Buildslave for this Build: asf946_ubuntu
Build Reason: The AnyBranchSchedu
The Buildbot has detected a new failure on builder tomcat-trunk while building
tomcat. Full details are available at:
https://ci.apache.org/builders/tomcat-trunk/builds/5610
Buildbot URL: https://ci.apache.org/
Buildslave for this Build: asf946_ubuntu
Build Reason: The AnyBranchScheduler sc
https://bz.apache.org/bugzilla/show_bug.cgi?id=65033
--- Comment #9 from Satya ---
Thanks for reply. we will test with Tomcat 8.5.62 once its released.
--
You are receiving this mail because:
You are the assignee for the bug.
-
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 4246e2cc6586dfb3fa819f94c89cd6a6db0acdbc
Author: remm
AuthorDate: Tue Dec 29 10:47:14 2020 +0100
Accurate version of t
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
commit 95ba57df171531fff8da664b4a3a31889f258582
Author: remm
AuthorDate: Tue Dec 29 10:55:12 2020 +0100
Remove lambdas
---
t
This is an automated email from the ASF dual-hosted git repository.
remm pushed a change to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git.
from 59d9a28 65033: Fix JNDI realm error handling
new 4246e2c Accurate version of the error test
new 95ba57d Rem
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new c906bea Accurate version of the error test
c906bea
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new 704e37a Accurate version of the error test
704e37
The Buildbot has detected a new failure on builder tomcat-85-trunk while
building tomcat. Full details are available at:
https://ci.apache.org/builders/tomcat-85-trunk/builds/2576
Buildbot URL: https://ci.apache.org/
Buildslave for this Build: asf946_ubuntu
Build Reason: The AnyBranchSchedu
The Buildbot has detected a new failure on builder tomcat-9-trunk while
building tomcat. Full details are available at:
https://ci.apache.org/builders/tomcat-9-trunk/builds/587
Buildbot URL: https://ci.apache.org/
Buildslave for this Build: asf946_ubuntu
Build Reason: The AnyBranchScheduler
https://bz.apache.org/bugzilla/show_bug.cgi?id=65033
Remy Maucherat changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 8.5.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/8.5.x by this push:
new 59d9a28 65033: Fix JNDI realm error handling
59d9a2
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/9.0.x by this push:
new 130843d 65033: Fix JNDI realm error handling
130843
This is an automated email from the ASF dual-hosted git repository.
remm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/tomcat.git
The following commit(s) were added to refs/heads/master by this push:
new 55f2f35 65033: Fix JNDI realm error handling
55f2
rmannibucau commented on pull request #399:
URL: https://github.com/apache/tomcat/pull/399#issuecomment-751987522
@arjantijms I see, my point is that the facade is about preventing the user
to access the internals (request here) or any API not from the spec so I don't
think it should be br
35 matches
Mail list logo
