[GitHub] [tomcat] arjantijms commented on pull request #399: Add getRequest method to RequestFacade, to get the wrapped Request

[GitBox]

arjantijms commented on pull request #399:
URL: https://github.com/apache/tomcat/pull/399#issuecomment-752177666


   @rmannibucau oh yeah, of course, then it won't work. It'll throw an 
exception, so at least you know it won't work ;)
   
   `requestInitialized()` is really early though, so in most cases should be 
early enough. Just to be sure I'll take your suggestion and add a default 
unwrapFully:
   
   ```java
       @SuppressWarnings("unchecked")
       private <T extends ServletRequest> T unwrapFully(ServletRequest request) 
{
           ServletRequest currentRequest = request;
           while (currentRequest instanceof ServletRequestWrapper) {
               ServletRequestWrapper wrapper = (ServletRequestWrapper) 
currentRequest;
               currentRequest = wrapper.getRequest();
           }
           return (T) currentRequest;
       }
   ```
   
   Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org