Re: [tomcat] 01/02: Replace Collections.sort() with List.sort()

On Thu, Dec 3, 2020 at 2:48 PM Martin Grigorov wrote: > Hi, > > Shall we backport these commits to 9.x and 8.5? > It will make it easier to backport future changes in these classes. > +1 No need to diverge the branches unnecessarily. Igal > > Martin > > On Fri, Dec 4, 2020, 00:06 Emmanuel B

Re: [VOTE] Release Apache Tomcat 8.5.61

On Thu, Dec 3, 2020 at 6:49 AM Mark Thomas wrote: > The proposed Apache Tomcat 8.5.61 release is now available for voting. > > The notable changes compared to the 8.5.60 release are: > > - Align the behaviour of ServletContext.getRealPath(String path) with > the recent clarification from the Se

Re: [VOTE] Release Apache Tomcat 9.0.41

On Thu, Dec 3, 2020 at 5:12 AM Mark Thomas wrote: > The proposed Apache Tomcat 9.0.41 release is now available for voting. > > The notable changes compared to the 9.0.40 release are: > > - Align the behaviour of ServletContext.getRealPath(String path) with > the recent clarification from the Se

Re: [VOTE] Release Apache Tomcat 10.0.0

On Thu, Dec 3, 2020 at 2:50 AM Mark Thomas wrote: > The proposed Apache Tomcat 10.0.0 release is now available for > voting. > > Apache Tomcat 10.x implements Jakarta EE 9 and, as such, the primary > package for all the specification APIs has changed from javax.* to > jakarta.* > Applications tha

Re: Tomcat Native Build Instructions

On Thu, Dec 3, 2020 at 2:31 PM Emmanuel Bourg wrote: > Le 03/12/2020 à 23:00, Igal Sapir a écrit : > > > It seems that the package is named "libapr1-dev" and I'm not sure if that > > was a recent change or not. > > > > I want to update the docs but not sure if that would break non-Ubuntu > > Debi

[tomcat] 04/05: Make the inner classes static when possible to save a reference to the enclosing class

This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 0b8b394241963e274e61c630c5ef5e9b191f2860 Author: Emmanuel Bourg AuthorDate: Fri Dec 4 00:48:39 2020 +0100 Make the

[tomcat] 03/05: Make the serialVersionUID fields private

This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 71cbf992386ac53cff22d4dee8b7836e23876d8d Author: Emmanuel Bourg AuthorDate: Fri Dec 4 00:22:09 2020 +0100 Make the

[tomcat] 05/05: No longer use Throwable.initCause() when possible

This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 9ede7c8232d24b93704dbfb76bcc4f6d72d20336 Author: Emmanuel Bourg AuthorDate: Fri Dec 4 01:03:07 2020 +0100 No longer

[tomcat] 02/05: Collapse identical catch blocks

This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit d03a176f94b42564ac5f6f28b587ad0e483716e2 Author: Emmanuel Bourg AuthorDate: Fri Dec 4 00:15:59 2020 +0100 Collapse

[tomcat] 01/05: Replace explicit types with <>

This is an automated email from the ASF dual-hosted git repository. ebourg pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git commit b39da50bfa564eeaf2235a110233f794c7897a81 Author: Emmanuel Bourg AuthorDate: Thu Dec 3 23:43:49 2020 +0100 Replace e

[tomcat] branch master updated (df3a323 -> 9ede7c8)

This is an automated email from the ASF dual-hosted git repository. ebourg pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git. from df3a323 It is time to drop the milestone modifier new b39da50 Replace explicit types with <> new d03a176

Re: [tomcat] 01/02: Replace Collections.sort() with List.sort()

Hi, Shall we backport these commits to 9.x and 8.5? It will make it easier to backport future changes in these classes. Martin On Fri, Dec 4, 2020, 00:06 Emmanuel Bourg wrote: > Hi Christopher, > > Le 03/12/2020 à 21:49, Christopher Schultz a écrit : > > > I'm curious as to why this change is

Re: Tomcat Native Build Instructions

Le 03/12/2020 à 23:00, Igal Sapir a écrit : > It seems that the package is named "libapr1-dev" and I'm not sure if that > was a recent change or not. > > I want to update the docs but not sure if that would break non-Ubuntu > Debian-based builds. > > Any thoughts? libapr1.0-dev was in Debian Si

Re: [tomcat] 01/02: Replace Collections.sort() with List.sort()

Hi Christopher, Le 03/12/2020 à 21:49, Christopher Schultz a écrit : > I'm curious as to why this change is warranted. I'm not suggesting it's > not... just wondering what the benefit is? Avoiding a pass-through > method call? It's the shorter idiom to sort lists with Java 8+, it just improves t

Tomcat Native Build Instructions

The docs for building Tomcat Native [1] states "libapr1.0-dev" as a prerequisite for Debian based systems, but on Ubuntu 20.04 that throws an error: > Package libapr1.0-dev is not available, but is referred to by another package. > This may mean that the package is missing, has been obsoleted, or

Re: Objection to the deprecation of the tomcat-native/APR connector

On 01/12/2020 12:05, Graham Leggett wrote: Hi all, I object to the deprecation of the tomcat-native/APR connector. Understand, but APR is the major problem. Tomcat Native uses a small subset of APR (networking), and since APR will eventually merge with apr-util (already merged in apr/trunk) t

[GitHub] [tomcat] ChristopherSchultz commented on a change in pull request #380: Fix BZ 64110 - request attr for requested ciphers and protocols

ChristopherSchultz commented on a change in pull request #380: URL: https://github.com/apache/tomcat/pull/380#discussion_r535618925 ## File path: java/org/apache/tomcat/util/net/SecureNio2Channel.java ## @@ -70,6 +73,8 @@ protected boolean closed; protected boolean cl

Re: [tomcat] 01/02: Replace Collections.sort() with List.sort()

Emmanuel, I'm curious as to why this change is warranted. I'm not suggesting it's not... just wondering what the benefit is? Avoiding a pass-through method call? Thanks, -chris On 12/1/20 19:40, ebo...@apache.org wrote: This is an automated email from the ASF dual-hosted git repository. eb

Re: Objection to the deprecation of the tomcat-native/APR connector

Graham, On 12/1/20 12:43, Graham Leggett wrote: On 01 Dec 2020, at 13:48, Rémy Maucherat wrote: You still have years to plan a migration off the APR connector as it will only be removed in 10.1 and Tomcat 9.0 continues to be supported. This eventual removal or APR has been discussed for year

[GitHub] [tomcat] michael-o commented on pull request #382: Add support for unix domain sockets.

michael-o commented on pull request #382: URL: https://github.com/apache/tomcat/pull/382#issuecomment-738291588 @minfrin Do you want to peform anymore changes or do want to me run verifcation on it? Do you think a test would be possible to start up and shut down a UDS? --

[GitHub] [tomcat] ChristopherSchultz commented on a change in pull request #380: Fix BZ 64110 - request attr for requested ciphers and protocols

ChristopherSchultz commented on a change in pull request #380: URL: https://github.com/apache/tomcat/pull/380#discussion_r535344046 ## File path: java/org/apache/tomcat/util/net/TLSClientHelloExtractor.java ## @@ -202,6 +232,15 @@ public String getSNIValue() { } +p

Container release starting

All, I will start the updates to Dockerhub for all of the latest TomEE versions. Thanks, Rod.

Re: [tomcat] branch bz-64110 created (now f98f116)

On 03/12/2020 19:07, ma...@apache.org wrote: > This is an automated email from the ASF dual-hosted git repository. > > markt pushed a change to branch bz-64110 > in repository https://gitbox.apache.org/repos/asf/tomcat.git. Sorry. Pushed to wrong repo. I've removed this branch. Mark > >

[tomcat] 02/02: Action review comments

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch bz-64110 in repository https://gitbox.apache.org/repos/asf/tomcat.git commit f98f1164a77a49e785e7beb7325e89c38a8a2f4d Author: Mark Thomas AuthorDate: Thu Dec 3 19:06:06 2020 + Action revi

[tomcat] 01/02: Fix BZ 64110 - request attr for requested ciphers and protocols

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch bz-64110 in repository https://gitbox.apache.org/repos/asf/tomcat.git commit a0e8389070b51eedb7d13b4d885b7c9f1e4b635c Author: Mark Thomas AuthorDate: Wed Nov 25 18:44:11 2020 + Fix BZ 641

[tomcat] branch bz-64110 created (now f98f116)

This is an automated email from the ASF dual-hosted git repository. markt pushed a change to branch bz-64110 in repository https://gitbox.apache.org/repos/asf/tomcat.git. at f98f116 Action review comments This branch includes the following new commits: new a0e8389 Fix BZ 64110 - r

[GitHub] [tomcat] markt-asf commented on a change in pull request #380: Fix BZ 64110 - request attr for requested ciphers and protocols

markt-asf commented on a change in pull request #380: URL: https://github.com/apache/tomcat/pull/380#discussion_r535501364 ## File path: java/org/apache/tomcat/util/net/TLSClientHelloExtractor.java ## @@ -193,6 +214,15 @@ public String getSNIValue() { } +public Lis

[GitHub] [tomcat] markt-asf commented on a change in pull request #380: Fix BZ 64110 - request attr for requested ciphers and protocols

markt-asf commented on a change in pull request #380: URL: https://github.com/apache/tomcat/pull/380#discussion_r535501143 ## File path: java/org/apache/tomcat/util/net/SecureNio2Channel.java ## @@ -70,6 +73,8 @@ protected boolean closed; protected boolean closing;

[GitHub] [tomcat] markt-asf commented on a change in pull request #380: Fix BZ 64110 - request attr for requested ciphers and protocols

markt-asf commented on a change in pull request #380: URL: https://github.com/apache/tomcat/pull/380#discussion_r535499442 ## File path: java/org/apache/tomcat/util/net/SecureNioChannel.java ## @@ -68,6 +71,8 @@ protected boolean closed = false; protected boolean clos

[GitHub] [tomcat] markt-asf commented on a change in pull request #380: Fix BZ 64110 - request attr for requested ciphers and protocols

markt-asf commented on a change in pull request #380: URL: https://github.com/apache/tomcat/pull/380#discussion_r535499222 ## File path: java/org/apache/catalina/util/TLSUtil.java ## @@ -38,6 +38,8 @@ public static boolean isTLSRequestAttribute(String name) { G

[SECURITY] CVE-2020-17527 Apache Tomcat HTTP/2 Request header mix-up

CVE-2020-17527 Apache Tomcat HTTP/2 Request header mix-up Severity: Moderate Vendor: The Apache Software Foundation Versions Affected: Apache Tomcat 10.0.0-M1 to 10.0.0-M9 Apache Tomcat 9.0.0.M5 to 9.0.39 Apache Tomcat 8.5.1 to 8.5.59 Description: While investigating Bug 64830 it was discovered

svn commit: r1884073 - in /tomcat/site/trunk: docs/security-10.html docs/security-8.html docs/security-9.html xdocs/security-10.xml xdocs/security-8.xml xdocs/security-9.xml

Author: markt Date: Thu Dec 3 18:01:08 2020 New Revision: 1884073 URL: http://svn.apache.org/viewvc?rev=1884073&view=rev Log: Publish CVE-2020-17527 Modified: tomcat/site/trunk/docs/security-10.html tomcat/site/trunk/docs/security-8.html tomcat/site/trunk/docs/security-9.html tom

Re: Objection to the deprecation of the tomcat-native/APR connector

Graham, On 12/1/20 06:05, Graham Leggett wrote: Hi all, I object to the deprecation of the tomcat-native/APR connector. Most specifically, I am -1 on the following: https://marc.info/?l=tomcat-dev&m=160681846808019&w=2 Looking at past discussion on this, the justification has been: "It is i

Re: [VOTE] Release Apache Tomcat 8.5.61

On Thu, Dec 3, 2020 at 3:50 PM Mark Thomas wrote: > The proposed Apache Tomcat 8.5.61 release is now available for voting. > > The notable changes compared to the 8.5.60 release are: > > - Align the behaviour of ServletContext.getRealPath(String path) with > the recent clarification from the Se

Re: [VOTE] Release Apache Tomcat 9.0.41

On Thu, Dec 3, 2020 at 2:12 PM Mark Thomas wrote: > The proposed Apache Tomcat 9.0.41 release is now available for voting. > > The notable changes compared to the 9.0.40 release are: > > - Align the behaviour of ServletContext.getRealPath(String path) with > the recent clarification from the Se

[GitHub] [tomcat] ChristopherSchultz commented on a change in pull request #380: Fix BZ 64110 - request attr for requested ciphers and protocols

ChristopherSchultz commented on a change in pull request #380: URL: https://github.com/apache/tomcat/pull/380#discussion_r535327550 ## File path: java/org/apache/tomcat/util/net/SecureNio2Channel.java ## @@ -70,6 +73,8 @@ protected boolean closed; protected boolean cl

[GitHub] [tomcat] ChristopherSchultz commented on a change in pull request #380: Fix BZ 64110 - request attr for requested ciphers and protocols

ChristopherSchultz commented on a change in pull request #380: URL: https://github.com/apache/tomcat/pull/380#discussion_r535319757 ## File path: java/org/apache/tomcat/util/net/TLSClientHelloExtractor.java ## @@ -193,6 +214,15 @@ public String getSNIValue() { } +p

[VOTE] Release Apache Tomcat 8.5.61

The proposed Apache Tomcat 8.5.61 release is now available for voting. The notable changes compared to the 8.5.60 release are: - Align the behaviour of ServletContext.getRealPath(String path) with the recent clarification from the Servlet specification project. If the path parameter does not

svn commit: r44827 [1/2] - in /dev/tomcat/tomcat-8/v8.5.61: ./ bin/ bin/embed/ bin/extras/ src/

Author: markt Date: Thu Dec 3 14:18:47 2020 New Revision: 44827 Log: Upload 8.5.61 for voting Added: dev/tomcat/tomcat-8/v8.5.61/ dev/tomcat/tomcat-8/v8.5.61/KEYS dev/tomcat/tomcat-8/v8.5.61/README.html dev/tomcat/tomcat-8/v8.5.61/RELEASE-NOTES dev/tomcat/tomcat-8/v8.5.61/bin

svn commit: r44827 [2/2] - in /dev/tomcat/tomcat-8/v8.5.61: ./ bin/ bin/embed/ bin/extras/ src/

Added: dev/tomcat/tomcat-8/v8.5.61/src/apache-tomcat-8.5.61-src.zip.asc == --- dev/tomcat/tomcat-8/v8.5.61/src/apache-tomcat-8.5.61-src.zip.asc (added) +++ dev/tomcat/tomcat-8/v8.5.61/src/apache-tomcat-8.5.61-src.zip.asc Th

Re: [VOTE] Release Apache Tomcat 10.0.0

On Thu, Dec 3, 2020 at 11:50 AM Mark Thomas wrote: > The proposed Apache Tomcat 10.0.0 release is now available for > voting. > > Apache Tomcat 10.x implements Jakarta EE 9 and, as such, the primary > package for all the specification APIs has changed from javax.* to > jakarta.* > Applications th

[tomcat] 01/01: Tag 8.5.61

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to tag 8.5.61 in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 77d330abea52e4aeb039ca7eb8a766e0e1c56a71 Author: Mark Thomas AuthorDate: Thu Dec 3 13:59:25 2020 + Tag 8.5.61 ---

[tomcat] tag 8.5.61 created (now 77d330a)

This is an automated email from the ASF dual-hosted git repository. markt pushed a change to tag 8.5.61 in repository https://gitbox.apache.org/repos/asf/tomcat.git. at 77d330a (commit) This tag includes the following new commits: new 77d330a Tag 8.5.61 The 1 revisions listed abov

[VOTE] Release Apache Tomcat 9.0.41

The proposed Apache Tomcat 9.0.41 release is now available for voting. The notable changes compared to the 9.0.40 release are: - Align the behaviour of ServletContext.getRealPath(String path) with the recent clarification from the Servlet specification project. If the path parameter does not

Re: [VOTE] Release Apache Tomcat 10.0.0

On 03/12/2020 10:43, Mark Thomas wrote: > The proposed Apache Tomcat 10.0.0 release is now available for > voting. > > Apache Tomcat 10.x implements Jakarta EE 9 and, as such, the primary > package for all the specification APIs has changed from javax.* to jakarta.* > Applications that run on Tomc

svn commit: r44818 - in /dev/tomcat/tomcat-9/v9.0.41: ./ bin/ bin/embed/ src/

Author: markt Date: Thu Dec 3 12:42:32 2020 New Revision: 44818 Log: Upload 9.0.41 for voting Added: dev/tomcat/tomcat-9/v9.0.41/ dev/tomcat/tomcat-9/v9.0.41/KEYS dev/tomcat/tomcat-9/v9.0.41/README.html dev/tomcat/tomcat-9/v9.0.41/RELEASE-NOTES dev/tomcat/tomcat-9/v9.0.41/bin

[tomcat] 01/01: Tag 9.0.41

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to tag 9.0.41 in repository https://gitbox.apache.org/repos/asf/tomcat.git commit 75d7a2069bf4360bcd8b885c6b7387d70c9cb052 Author: Mark Thomas AuthorDate: Thu Dec 3 11:38:47 2020 + Tag 9.0.41 ---

[tomcat] tag 9.0.41 created (now 75d7a20)

This is an automated email from the ASF dual-hosted git repository. markt pushed a change to tag 9.0.41 in repository https://gitbox.apache.org/repos/asf/tomcat.git. at 75d7a20 (commit) This tag includes the following new commits: new 75d7a20 Tag 9.0.41 The 1 revisions listed abov

[VOTE] Release Apache Tomcat 10.0.0

The proposed Apache Tomcat 10.0.0 release is now available for voting. Apache Tomcat 10.x implements Jakarta EE 9 and, as such, the primary package for all the specification APIs has changed from javax.* to jakarta.* Applications that run on Tomcat 9 will not run on Tomcat 10 without changes. The

Re: JDK 16 Early Access build 26 is now available

Hi Rory, I saw the update. This is on my TODO list for later today. Mark On 03/12/2020 08:57, Rory O'Donnell wrote: > Hi Mark, > > The bug was updated, unable to reproduce , can you provide details ? > > Rgds,Rory > > On 30/11/2020 17:00, Rory O'Donnell wrote: >> Hi Marc, >> >> Let me see wh

Re: JDK 16 Early Access build 26 is now available

On December 3, 2020 8:57:26 AM UTC, Rory O'Donnell wrote: >Hi Mark, > >The bug was updated, unable to reproduce , can you provide details ? > >Rgds,Rory > >On 30/11/2020 17:00, Rory O'Donnell wrote: >> Hi Marc, >> >> Let me see what we can do. >> >> Rgds,Rory >> >> On 30/11/2020 14:47, Mark Thoma

Re: JDK 16 Early Access build 26 is now available

Hi Mark, The bug was updated, unable to reproduce , can you provide details ? Rgds,Rory On 30/11/2020 17:00, Rory O'Donnell wrote: Hi Marc, Let me see what we can do. Rgds,Rory On 30/11/2020 14:47, Mark Thomas wrote: Hi Rory, I have been (slowly) working my way through the currently open

svn commit: r44813 - in /dev/tomcat/tomcat-10/v10.0.0: ./ bin/ bin/embed/ src/

Author: markt Date: Thu Dec 3 08:10:59 2020 New Revision: 44813 Log: UpUpload 10.0.0 for voting Added: dev/tomcat/tomcat-10/v10.0.0/ dev/tomcat/tomcat-10/v10.0.0/KEYS dev/tomcat/tomcat-10/v10.0.0/README.html dev/tomcat/tomcat-10/v10.0.0/RELEASE-NOTES dev/tomcat/tomcat-10/v10.