markt-asf commented on a change in pull request #380:
URL: https://github.com/apache/tomcat/pull/380#discussion_r535501143
##########
File path: java/org/apache/tomcat/util/net/SecureNio2Channel.java
##########
@@ -70,6 +73,8 @@
protected boolean closed;
protected boolean closing;
+ private Map<String,List<String>> additionalTlsAttributes = new HashMap<>();
Review comment:
Yes, sniComplete should be volatile.
The reason to use Map<String,List<String>> is that the attribute is exposed
to user code so I don;t want it to be an internal Tomcat class. If we get this
added to the spec then we could define a class for it in the spec.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
