Re: Blocking IO does not appear to always be blocking with asyncIO

On Tue, Dec 3, 2019 at 10:56 PM Mark Thomas wrote: > Hi, > > I've been looking into BZ 63931. The error messages I was expecting to > see were not there. > > The first odd thing I noticed was an NPE here: > > https://github.com/apache/tomcat/blob/master/java/org/apache/tomcat/websocket/WsRemoteEn

Re: NioSelectorPool usefulness

On 03/12/2019 21:00, Rémy Maucherat wrote: > Hi, > > NioSelectorPool is probably never used out of its default default > configuration as the capability is well hidden, so I had a look. I > couldn't really see a difference with ab/h2load between the default > (shared = true) and a pooled selector

[Bug 63931] The remote endpoint was in state [TEXT_FULL_WRITING] which is an invalid state

https://bz.apache.org/bugzilla/show_bug.cgi?id=63931 --- Comment #9 from Mark Thomas --- That you aren't seeing any exceptions before this one is not what I would expect. We have a unit test (TestWebSocketFrameClient) that can be fairly easily tweaked to simulate this scenario - a server sending

Blocking IO does not appear to always be blocking with asyncIO

Hi, I've been looking into BZ 63931. The error messages I was expecting to see were not there. The first odd thing I noticed was an NPE here: https://github.com/apache/tomcat/blob/master/java/org/apache/tomcat/websocket/WsRemoteEndpointImplBase.java#L310 bsh.getSendResult() returned null. That s

[Bug 63985] New: Tomcat 9 does not read UTF-8 files with no bom correctly

https://bz.apache.org/bugzilla/show_bug.cgi?id=63985 Bug ID: 63985 Summary: Tomcat 9 does not read UTF-8 files with no bom correctly Product: Tomcat 9 Version: 9.0.x Hardware: PC Status: NEW Severity:

NioSelectorPool usefulness

Hi, NioSelectorPool is probably never used out of its default default configuration as the capability is well hidden, so I had a look. I couldn't really see a difference with ab/h2load between the default (shared = true) and a pooled selector with all the extra code. Then moving down the stack Ni

[tomcat] branch master updated: Simplify code

This is an automated email from the ASF dual-hosted git repository. remm pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new ac4998b Simplify code ac4998b is described below

[GitHub] [tomcat] govi20 commented on a change in pull request #227: Unit test FileStore utility methods

govi20 commented on a change in pull request #227: Unit test FileStore utility methods URL: https://github.com/apache/tomcat/pull/227#discussion_r353303084 ## File path: java/org/apache/catalina/session/FileStore.java ## @@ -136,8 +136,8 @@ public int getSize() throws IOEx

[GitHub] [tomcat] markt-asf commented on a change in pull request #228: Correct header too large status to 414

markt-asf commented on a change in pull request #228: Correct header too large status to 414 URL: https://github.com/apache/tomcat/pull/228#discussion_r353172215 ## File path: java/org/apache/coyote/http11/Http11InputBuffer.java ## @@ -723,7 +723,7 @@ private boolean fill(

[Bug 63982] CombinedRealm makes assumptions about principal implementation

https://bz.apache.org/bugzilla/show_bug.cgi?id=63982 --- Comment #6 from Mark Thomas --- (In reply to Michael Osipov from comment #5) > Even if the behavior is not documented and an implementation detail? How > would you properly call #getRoles() from the CombinedRealm then? I wouldn't. I'd lea

[Bug 63983] Jasper builds-up open files until garbage collection, hitting Linux default limit of 4096.

https://bz.apache.org/bugzilla/show_bug.cgi?id=63983 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[tomcat] branch 8.5.x updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63983 fd 'leak'

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch 8.5.x in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/8.5.x by this push: new b30eab0 Fix https://bz.apache.org/bugzilla/show_bu

[tomcat] branch master updated: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=63983 fd 'leak'

This is an automated email from the ASF dual-hosted git repository. markt pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/tomcat.git The following commit(s) were added to refs/heads/master by this push: new b91a449 Fix https://bz.apache.org/bugzilla/show_

[Bug 63983] Jasper builds-up open files until garbage collection, hitting Linux default limit of 4096.

https://bz.apache.org/bugzilla/show_bug.cgi?id=63983 --- Comment #1 from Mark Thomas --- Thanks for the report. This is another regression in the fix for the race condition in JSP compilation that meant Jasper would see a modified JSP but then process stale content for that file from the static r

[Bug 63982] CombinedRealm makes assumptions about principal implementation

https://bz.apache.org/bugzilla/show_bug.cgi?id=63982 --- Comment #5 from Michael Osipov --- (In reply to Mark Thomas from comment #4) > (In reply to Michael Osipov from comment #3) > > Even if, it has to be supported until Tomcat 10. Do you consider returning > > null is better here? That would m

[GitHub] [tomcat] michael-o commented on a change in pull request #228: Correct header too large status to 414

michael-o commented on a change in pull request #228: Correct header too large status to 414 URL: https://github.com/apache/tomcat/pull/228#discussion_r353130285 ## File path: java/org/apache/coyote/http11/Http11InputBuffer.java ## @@ -723,7 +723,7 @@ private boolean fill(

[Bug 63981] False-positive warning logged when Registry.disableRegistry is called and the registry has already been disabled

https://bz.apache.org/bugzilla/show_bug.cgi?id=63981 --- Comment #2 from Andy Wilkinson --- Thanks, Mark. Much appreciated. -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev

[GitHub] [tomcat] Gallrax commented on a change in pull request #228: Correct header too large status to 414

Gallrax commented on a change in pull request #228: Correct header too large status to 414 URL: https://github.com/apache/tomcat/pull/228#discussion_r353049202 ## File path: java/org/apache/coyote/http11/Http11InputBuffer.java ## @@ -723,7 +723,7 @@ private boolean fill(bo

[GitHub] [tomcat] michael-o commented on a change in pull request #228: Correct header too large status to 414

michael-o commented on a change in pull request #228: Correct header too large status to 414 URL: https://github.com/apache/tomcat/pull/228#discussion_r353038471 ## File path: java/org/apache/coyote/http11/Http11InputBuffer.java ## @@ -723,7 +723,7 @@ private boolean fill(

[GitHub] [tomcat] markt-asf commented on a change in pull request #228: Correct header too large status to 414

markt-asf commented on a change in pull request #228: Correct header too large status to 414 URL: https://github.com/apache/tomcat/pull/228#discussion_r353034038 ## File path: java/org/apache/coyote/http11/Http11InputBuffer.java ## @@ -723,7 +723,7 @@ private boolean fill(

[Bug 63982] CombinedRealm makes assumptions about principal implementation

https://bz.apache.org/bugzilla/show_bug.cgi?id=63982 --- Comment #4 from Mark Thomas --- (In reply to Michael Osipov from comment #3) > Even if, it has to be supported until Tomcat 10. Do you consider returning > null is better here? That would make like in CombinedRealm easier. It has to be pre

[Bug 63982] CombinedRealm makes assumptions about principal implementation

https://bz.apache.org/bugzilla/show_bug.cgi?id=63982 --- Comment #3 from Michael Osipov --- (In reply to Mark Thomas from comment #2) > I think getRoles() can be deprecated. It isn't used anywhere now. It was > added to support the failed GSoC JASPIC work. Even if, it has to be supported until T