govi20 commented on a change in pull request #227: Unit test FileStore utility
methods
URL: https://github.com/apache/tomcat/pull/227#discussion_r353303084
##########
File path: java/org/apache/catalina/session/FileStore.java
##########
@@ -136,8 +136,8 @@ public int getSize() throws IOException {
// Figure out which files are sessions
int keycount = 0;
if (files != null) {
- for (int i = 0; i < files.length; i++) {
- if (files[i].endsWith(FILE_EXT)) {
+ for (String file1 : files) {
+ if (file1.endsWith (FILE_EXT)) {
keycount++;
Review comment:
Renamed `files[]` source as `dir` Please let me know if you think otherwise
i.e. to change files as dir.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
