Re: svn commit: r1844723 - in /tomcat/trunk/bin: makebase.bat makebase.sh

2018-10-24 Thread Igal Sapir
On Wed, Oct 24, 2018 at 9:01 AM Mark Thomas wrote: > On October 24, 2018 3:44:23 PM UTC, Igal Sapir wrote: > >On Wed, Oct 24, 2018 at 1:55 AM Mark Thomas wrote: > > >> >New Revision: 1844723 > >> > > >> >URL: http://svn.apache.org/viewvc?rev=1844723&view=rev > >> >Log: > >> >Added empty ROOT d

Re: svn commit: r1844723 - in /tomcat/trunk/bin: makebase.bat makebase.sh

2018-10-24 Thread Mark Thomas
On October 24, 2018 3:44:23 PM UTC, Igal Sapir wrote: >On Wed, Oct 24, 2018 at 1:55 AM Mark Thomas wrote: > >> On October 24, 2018 5:12:00 AM UTC, isa...@apache.org wrote: >> >Author: isapir >> >Date: Wed Oct 24 05:12:00 2018 >> >New Revision: 1844723 >> > >> >URL: http://svn.apache.org/viewvc?re

Re: svn commit: r1844723 - in /tomcat/trunk/bin: makebase.bat makebase.sh

2018-10-24 Thread Igal Sapir
On Wed, Oct 24, 2018 at 1:55 AM Mark Thomas wrote: > On October 24, 2018 5:12:00 AM UTC, isa...@apache.org wrote: > >Author: isapir > >Date: Wed Oct 24 05:12:00 2018 > >New Revision: 1844723 > > > >URL: http://svn.apache.org/viewvc?rev=1844723&view=rev > >Log: > >Added empty ROOT dir > > What is

Re: "Embedded" improvements

2018-10-24 Thread Igal Sapir
On Wed, Oct 24, 2018 at 2:55 AM Rémy Maucherat wrote: > Hi, > > I'm starting to review embedded. Maybe I won't make many changes in the end > and won't need a separate API. > > However, I have another post 9.0.13 refactoring with a redoing of > ConfigFileLoader and various places which try to loa

[GUMP@vmgump-vm3]: Project tomcat-trunk-test-nio (in module tomcat-trunk) failed

2018-10-24 Thread Bill Barker
n-1.1.1-SNAPSHOT.jar -Dtest.openssl.path=/srv/gump/public/workspace/openssl-master/dest-20181024/bin/openssl -Dtest.temp=output/test-tmp-NIO -Dtest.accesslog=true -Dexecute.test.nio=true -Dbnd.jar=/srv/gump/packages/bnd/bnd-4.0.0/biz.aQute.bnd-4.0.0.jar -Dexecute.test.apr=false -Dtest.excludePerformance=true -Dt

Re: "Embedded" improvements

2018-10-24 Thread Rémy Maucherat
On Wed, Oct 24, 2018 at 2:47 PM Coty Sutherland wrote: > I had a trivial comment that I put on the GitHub commit :) Otherwise that > looks OK to me. > Yes, the code could be nicer, so I improved it. Rémy

Re: "Embedded" improvements

2018-10-24 Thread Coty Sutherland
I had a trivial comment that I put on the GitHub commit :) Otherwise that looks OK to me. On Wed, Oct 24, 2018 at 5:55 AM Rémy Maucherat wrote: > Hi, > > I'm starting to review embedded. Maybe I won't make many changes in the end > and won't need a separate API. > > However, I have another post

"Embedded" improvements

2018-10-24 Thread Rémy Maucherat
Hi, I'm starting to review embedded. Maybe I won't make many changes in the end and won't need a separate API. However, I have another post 9.0.13 refactoring with a redoing of ConfigFileLoader and various places which try to load the configuration from seemingly random locations (the winner is "

Re: svn commit: r1844723 - in /tomcat/trunk/bin: makebase.bat makebase.sh

2018-10-24 Thread Mark Thomas
On October 24, 2018 5:12:00 AM UTC, isa...@apache.org wrote: >Author: isapir >Date: Wed Oct 24 05:12:00 2018 >New Revision: 1844723 > >URL: http://svn.apache.org/viewvc?rev=1844723&view=rev >Log: >Added empty ROOT dir What is the purpose of the above change? Mark > and run instructions to makeb