I had a trivial comment that I put on the GitHub commit :) Otherwise that looks OK to me.
On Wed, Oct 24, 2018 at 5:55 AM Rémy Maucherat <r...@apache.org> wrote: > Hi, > > I'm starting to review embedded. Maybe I won't make many changes in the end > and won't need a separate API. > > However, I have another post 9.0.13 refactoring with a redoing of > ConfigFileLoader and various places which try to load the configuration > from seemingly random locations (the winner is "server-embed.xml", which > IMO everyone forgot about aeons ago). So this redoes it with a pluggable > API as ConfigFileLoader was not. Minor additional work is needed to use it > in more places, since all configuration/resource loading from conf would > need to go through it (ideally) (and except logging, since it's obviously > pluggable enough). > > > https://github.com/rmaucher/tomcat/commit/c386eb2fc3b2f42b3a307cbc2d0ab1a72581f56a > > Comments ? > > Rémy >
