The Buildbot has detected a restored build on builder tomcat-7-trunk while
building . Full details are available at:
https://ci.apache.org/builders/tomcat-7-trunk/builds/930
Buildbot URL: https://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchScheduler
Author: markt
Date: Mon Nov 13 12:52:53 2017
New Revision: 1815097
URL: http://svn.apache.org/viewvc?rev=1815097&view=rev
Log:
Add missing import
Modified:
tomcat/tc7.0.x/trunk/test/org/apache/catalina/websocket/TestWebSocket.java
Modified:
tomcat/tc7.0.x/trunk/test/org/apache/catalina/webs
The Buildbot has detected a new failure on builder tomcat-7-trunk while
building . Full details are available at:
https://ci.apache.org/builders/tomcat-7-trunk/builds/929
Buildbot URL: https://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchScheduler sch
On 13/11/17 12:26, Konstantin Kolinko wrote:
> 2017-11-13 13:42 GMT+03:00 Mark Thomas :
>> On 13/11/17 09:49, Mark Thomas wrote:
>>
>>
>>
>>> Hmm.
>>>
>>> As I started to look at this I realised that a large number of the
>>> classes with errors are only using the static import a few times. Some
>
Author: markt
Date: Mon Nov 13 12:34:49 2017
New Revision: 1815095
URL: http://svn.apache.org/viewvc?rev=1815095&view=rev
Log:
Enforce not using static Assert.* imports
Modified:
tomcat/tc7.0.x/trunk/res/checkstyle/checkstyle.xml
Modified: tomcat/tc7.0.x/trunk/res/checkstyle/checkstyle.xml
U
Author: markt
Date: Mon Nov 13 12:34:34 2017
New Revision: 1815094
URL: http://svn.apache.org/viewvc?rev=1815094&view=rev
Log:
Few more static imports
Modified:
tomcat/tc7.0.x/trunk/test/org/apache/coyote/http11/filters/TestFlushableGZIPOutputStream.java
tomcat/tc7.0.x/trunk/test/org/apa
Modified: tomcat/tc7.0.x/trunk/test/org/apache/el/TestELEvaluation.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/test/org/apache/el/TestELEvaluation.java?rev=1815093&r1=1815092&r2=1815093&view=diff
==
--- tom
Modified:
tomcat/tc7.0.x/trunk/test/org/apache/catalina/tribes/test/channel/TestRemoteProcessException.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/test/org/apache/catalina/tribes/test/channel/TestRemoteProcessException.java?rev=1815093&r1=1815092&r2=1815093&view=diff
=
Author: markt
Date: Mon Nov 13 12:32:26 2017
New Revision: 1815093
URL: http://svn.apache.org/viewvc?rev=1815093&view=rev
Log:
Remove use of all static Assert.* imports
- fixes Gump errors with latest Checkstyle
- doesn't introduce errors for older Checkstyle
- makes unit tests consistent with use
Modified:
tomcat/tc7.0.x/trunk/test/org/apache/naming/resources/TestNamingContext.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/test/org/apache/naming/resources/TestNamingContext.java?rev=1815093&r1=1815092&r2=1815093&view=diff
===
Modified:
tomcat/tc7.0.x/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderMemoryLeak.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderMemoryLeak.java?rev=1815093&r1=1815092&r2=1815093&view=diff
=
Modified:
tomcat/tc7.0.x/trunk/test/org/apache/catalina/core/TestStandardContext.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/test/org/apache/catalina/core/TestStandardContext.java?rev=1815093&r1=1815092&r2=1815093&view=diff
=
2017-11-13 13:42 GMT+03:00 Mark Thomas :
> On 13/11/17 09:49, Mark Thomas wrote:
>
>
>
>> Hmm.
>>
>> As I started to look at this I realised that a large number of the
>> classes with errors are only using the static import a few times. Some
>> of them are using a mix of static and non-static impo
The Buildbot has detected a new failure on builder tomcat-8-trunk while
building . Full details are available at:
https://ci.apache.org/builders/tomcat-8-trunk/builds/1175
Buildbot URL: https://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchScheduler sc
Modified:
tomcat/tc8.0.x/trunk/test/org/apache/tomcat/util/descriptor/web/TestWebXmlOrdering.java
URL:
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/test/org/apache/tomcat/util/descriptor/web/TestWebXmlOrdering.java?rev=1815090&r1=1815089&r2=1815090&view=diff
=
Modified: tomcat/tc8.0.x/trunk/test/org/apache/el/lang/TestELArithmetic.java
URL:
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/test/org/apache/el/lang/TestELArithmetic.java?rev=1815090&r1=1815089&r2=1815090&view=diff
Author: markt
Date: Mon Nov 13 12:00:43 2017
New Revision: 1815091
URL: http://svn.apache.org/viewvc?rev=1815091&view=rev
Log:
Enforce not using static Assert.* imports
Modified:
tomcat/tc8.0.x/trunk/res/checkstyle/checkstyle.xml
Modified: tomcat/tc8.0.x/trunk/res/checkstyle/checkstyle.xml
U
Modified:
tomcat/tc8.0.x/trunk/test/org/apache/catalina/valves/TestRemoteIpValve.java
URL:
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/test/org/apache/catalina/valves/TestRemoteIpValve.java?rev=1815090&r1=1815089&r2=1815090&view=diff
=
Author: markt
Date: Mon Nov 13 12:00:30 2017
New Revision: 1815090
URL: http://svn.apache.org/viewvc?rev=1815090&view=rev
Log:
Remove use of all static Assert.* imports
- fixes Gump errors with latest Checkstyle
- doesn't introduce errors for older Checkstyle
- makes unit tests consistent with use
Modified:
tomcat/tc8.0.x/trunk/test/org/apache/catalina/filters/TestRemoteIpFilter.java
URL:
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/test/org/apache/catalina/filters/TestRemoteIpFilter.java?rev=1815090&r1=1815089&r2=1815090&view=diff
=
Modified:
tomcat/tc8.0.x/trunk/test/org/apache/catalina/authenticator/TestNonLoginAndBasicAuthenticator.java
URL:
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/test/org/apache/catalina/authenticator/TestNonLoginAndBasicAuthenticator.java?rev=1815090&r1=1815089&r2=1815090&view=diff
===
Modified:
tomcat/tc8.0.x/trunk/test/org/apache/catalina/startup/TestContextConfigAnnotation.java
URL:
http://svn.apache.org/viewvc/tomcat/tc8.0.x/trunk/test/org/apache/catalina/startup/TestContextConfigAnnotation.java?rev=1815090&r1=1815089&r2=1815090&view=diff
===
https://bz.apache.org/bugzilla/show_bug.cgi?id=61751
Bug ID: 61751
Summary: NIO2 connector cuts incoming request
Product: Tomcat 8
Version: 8.5.16
Hardware: PC
OS: Linux
Status: NEW
Severity: normal
Author: markt
Date: Mon Nov 13 11:26:24 2017
New Revision: 1815084
URL: http://svn.apache.org/viewvc?rev=1815084&view=rev
Log:
Enforce not using static Assert.* imports
Modified:
tomcat/tc8.5.x/trunk/res/checkstyle/checkstyle.xml
Modified: tomcat/tc8.5.x/trunk/res/checkstyle/checkstyle.xml
U
Modified:
tomcat/tc8.5.x/trunk/test/org/apache/catalina/core/TestStandardContext.java
URL:
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/test/org/apache/catalina/core/TestStandardContext.java?rev=1815083&r1=1815082&r2=1815083&view=diff
=
Modified:
tomcat/tc8.5.x/trunk/test/org/apache/coyote/http11/TestHttp11Processor.java
URL:
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/test/org/apache/coyote/http11/TestHttp11Processor.java?rev=1815083&r1=1815082&r2=1815083&view=diff
=
Modified: tomcat/tc8.5.x/trunk/test/org/apache/catalina/mapper/TestMapper.java
URL:
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/test/org/apache/catalina/mapper/TestMapper.java?rev=1815083&r1=1815082&r2=1815083&view=diff
Modified:
tomcat/tc8.5.x/trunk/test/org/apache/jasper/compiler/TestValidator.java
URL:
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/test/org/apache/jasper/compiler/TestValidator.java?rev=1815083&r1=1815082&r2=1815083&view=diff
=
Modified:
tomcat/tc8.5.x/trunk/test/org/apache/catalina/tribes/group/interceptors/TestNonBlockingCoordinator.java
URL:
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/test/org/apache/catalina/tribes/group/interceptors/TestNonBlockingCoordinator.java?rev=1815083&r1=1815082&r2=1815083&view=diff
=
Author: markt
Date: Mon Nov 13 11:25:51 2017
New Revision: 1815083
URL: http://svn.apache.org/viewvc?rev=1815083&view=rev
Log:
Remove use of all static Assert.* imports
- fixes Gump errors with latest Checkstyle
- doesn't introduce errors for older Checkstyle
- makes unit tests consistent with use
Author: markt
Date: Mon Nov 13 10:49:37 2017
New Revision: 1815080
URL: http://svn.apache.org/viewvc?rev=1815080&view=rev
Log:
Enforce not using static Assert.* imports
Modified:
tomcat/trunk/res/checkstyle/checkstyle.xml
Modified: tomcat/trunk/res/checkstyle/checkstyle.xml
URL:
http://svn.
Modified:
tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestOrderInterceptor.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/tribes/group/interceptors/TestOrderInterceptor.java?rev=1815079&r1=1815078&r2=1815079&view=diff
=
Modified: tomcat/trunk/test/org/apache/coyote/http11/TestHttp11Processor.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/coyote/http11/TestHttp11Processor.java?rev=1815079&r1=1815078&r2=1815079&view=diff
==
Author: markt
Date: Mon Nov 13 10:49:13 2017
New Revision: 1815079
URL: http://svn.apache.org/viewvc?rev=1815079&view=rev
Log:
Remove use of all static Assert.* imports
- fixes Gump errors with latest Checkstyle
- doesn't introduce errors for older Checkstyle
- makes unit tests consistent mwith us
Modified: tomcat/trunk/test/org/apache/catalina/core/TestStandardContext.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/core/TestStandardContext.java?rev=1815079&r1=1815078&r2=1815079&view=diff
==
Modified: tomcat/trunk/test/org/apache/jasper/compiler/TestValidator.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/jasper/compiler/TestValidator.java?rev=1815079&r1=1815078&r2=1815079&view=diff
==
---
Modified: tomcat/trunk/test/org/apache/catalina/mapper/TestMapper.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/mapper/TestMapper.java?rev=1815079&r1=1815078&r2=1815079&view=diff
==
--- tomca
On 13/11/17 09:49, Mark Thomas wrote:
> Hmm.
>
> As I started to look at this I realised that a large number of the
> classes with errors are only using the static import a few times. Some
> of them are using a mix of static and non-static imports.
>
> Given that switching to the non-static us
Author: markt
Date: Mon Nov 13 10:16:43 2017
New Revision: 1815073
URL: http://svn.apache.org/viewvc?rev=1815073&view=rev
Log:
Switch to non-static imports
- avoids checkstyle error
- broadly the same code volume (or less)
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/t
Modified:
tomcat/tc7.0.x/trunk/test/org/apache/tomcat/util/scan/TestJarScanner.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/test/org/apache/tomcat/util/scan/TestJarScanner.java?rev=1815073&r1=1815072&r2=1815073&view=diff
=
Author: markt
Date: Mon Nov 13 10:14:22 2017
New Revision: 1815072
URL: http://svn.apache.org/viewvc?rev=1815072&view=rev
Log:
Switch to non-static imports
- avoids checkstyle error
- broadly the same code volume (or less)
Modified:
tomcat/tc8.0.x/trunk/ (props changed)
tomcat/tc8.0.x/t
Author: markt
Date: Mon Nov 13 10:10:01 2017
New Revision: 1815070
URL: http://svn.apache.org/viewvc?rev=1815070&view=rev
Log:
Switch to non-static imports
- avoids checkstyle error
- broadly the same code volume (or less)
Modified:
tomcat/tc8.5.x/trunk/ (props changed)
tomcat/tc8.5.x/t
Author: markt
Date: Mon Nov 13 10:09:23 2017
New Revision: 1815069
URL: http://svn.apache.org/viewvc?rev=1815069&view=rev
Log:
Switch to non-static imports
- avoids checkstyle error
- broadly the same code volume (or less)
Modified:
tomcat/trunk/test/org/apache/tomcat/util/buf/TestByteChunk.j
Author: markt
Date: Mon Nov 13 09:53:47 2017
New Revision: 1815068
URL: http://svn.apache.org/viewvc?rev=1815068&view=rev
Log:
Switch to non-static imports
- avoids checkstyle error
- broadly the same code volume (or less)
Modified:
tomcat/tc8.0.x/trunk/ (props changed)
tomcat/tc8.0.x/
Author: markt
Date: Mon Nov 13 09:53:28 2017
New Revision: 1815067
URL: http://svn.apache.org/viewvc?rev=1815067&view=rev
Log:
Switch to non-static imports
- avoids checkstyle error
- broadly the same code volume (or less)
Modified:
tomcat/tc8.5.x/trunk/ (props changed)
tomcat/tc8.5.x/
Author: markt
Date: Mon Nov 13 09:52:55 2017
New Revision: 1815066
URL: http://svn.apache.org/viewvc?rev=1815066&view=rev
Log:
Switch to non-static imports
- avoids checkstyle error
- broadly the same code volume (or less)
Modified:
tomcat/trunk/modules/jdbc-pool/src/test/java/org/apache/tom
On 13/11/17 08:59, Mark Thomas wrote:
> On 11/11/17 21:47, Konstantin Kolinko wrote:
>> 2017-11-11 23:48 GMT+03:00 Mark Thomas :
>>> On 27/10/17 14:13, Mark Thomas wrote:
Now Checkstyle 8.3 has been released, I think we need to do something
about these. There are quite a few options.
On 11/11/17 21:47, Konstantin Kolinko wrote:
> 2017-11-11 23:48 GMT+03:00 Mark Thomas :
>> On 27/10/17 14:13, Mark Thomas wrote:
>>> Now Checkstyle 8.3 has been released, I think we need to do something
>>> about these. There are quite a few options.
>>>
>>> Do we want the minimalist approach (run
48 matches
Mail list logo