On 13/11/17 09:49, Mark Thomas wrote: <snip/>
> Hmm. > > As I started to look at this I realised that a large number of the > classes with errors are only using the static import a few times. Some > of them are using a mix of static and non-static imports. > > Given that switching to the non-static usage also fixes the issue, I'm > going to apply that fix first and then see what is left. Generally, I > plan to apply it when switching to the non-static usage results in > roughly the same amount of code or less. Given that: - the majority of the test classes don't use static imports - the majority of the test classes Gump is complaining about only use a few static Asserts - only a small number of test classes use a large number of static Asserts - global search and replace can remove all the static Assert imports quickly and easily - removing static Asserts fixes the Checkstyle warnings for Gump and works with all branches I'm going to go with removing static Assert (and similar) imports from the unit tests. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
