[Bug 60490] Several improvements to the ErrorReportValve

2016-12-19 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60490 --- Comment #2 from Michael Osipov <1983-01...@gmx.net> --- (In reply to Christopher Schultz from comment #1) > Some comments. > > - Line endings should be either be CRLF or LF. On certain systems, > System.lineSeparator may return CR only whic

[Bug 60490] Several improvements to the ErrorReportValve

2016-12-19 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60490 --- Comment #1 from Christopher Schultz --- Some comments. - Line endings should be either be CRLF or LF. On certain systems, System.lineSeparator may return CR only which could cause some problems[1]. I'd recommend reverting that particular c

[Bug 55554] NoSuchMethodError on ConcurrentHashMap$KeySetView

2016-12-19 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=4 --- Comment #9 from Rossen Stoyanchev --- FWIW I do not use Ubuntu packages for Tomcat. I download it from the Tomcat download page. So something there gave me a binary with the same or similar issue. -- You are receiving this mail because: Y

[Bug 55554] NoSuchMethodError on ConcurrentHashMap$KeySetView

2016-12-19 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=4 --- Comment #8 from Emmanuel Bourg --- This issue has been fixed in the version 8.5.9-2 of the tomcat8 package in Debian Stretch. The tomcat8 package in Debian Jessie was built with Java 7 and is not affected. The Ubuntu package is likely to b

[Bug 60497] JSP custom tags returned to the tag pools to be reused without executing the doEndTag method

2016-12-19 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60497 --- Comment #5 from Wai-Kau Lo --- I think the JSP spec clearly states that we should not reuse a JSP tag instance if its doStartTag method execution raises an exception, as I explained in my previous comment. Also, this is clearly a regressio

[Bug 60497] JSP custom tags returned to the tag pools to be reused without executing the doEndTag method

2016-12-19 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60497 --- Comment #4 from Remy Maucherat --- I didn't find anything that was very clear either, which is why I asked. I'd recommend you disable tag pooling for now, it's probably not that useful anymore. -- You are receiving this mail because: You

[Bug 60497] JSP custom tags returned to the tag pools to be reused without executing the doEndTag method

2016-12-19 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60497 --- Comment #3 from Wai-Kau Lo --- Page 2-54 of the JavaServer Pages Specification version 2.0 describes the lifecycle of a JSP tag instance using a state transition diagram, which I have uploaded to this bug as an attachment (named JSP Tag Lif

[Bug 60497] JSP custom tags returned to the tag pools to be reused without executing the doEndTag method

2016-12-19 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60497 --- Comment #2 from Wai-Kau Lo --- Created attachment 34534 --> https://bz.apache.org/bugzilla/attachment.cgi?id=34534&action=edit JSP Tag Lifecycle Diagram -- You are receiving this mail because: You are the assignee for the bug. -

[Bug 60497] JSP custom tags returned to the tag pools to be reused without executing the doEndTag method

2016-12-19 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60497 --- Comment #1 from Remy Maucherat --- (In reply to Wai-Kau Lo from comment #0) > This violates the JSP specification that specifies > that JSP tags should never be reused in case of an exception. Can you provide the spec language which states

[Bug 60497] JSP custom tags returned to the tag pools to be reused without executing the doEndTag method

2016-12-19 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60497 Michael Osipov <1983-01...@gmx.net> changed: What|Removed |Added CC||1983-01...@gmx.net