https://bz.apache.org/bugzilla/show_bug.cgi?id=60490

--- Comment #1 from Christopher Schultz <ch...@christopherschultz.net> ---
Some comments.

- Line endings should be either be CRLF or LF. On certain systems,
System.lineSeparator may return CR only which could cause some problems[1]. I'd
recommend reverting that particular change, or using CRLF.

- All of the various messages here need to be HTML-escaped before being
dropped-into the HTML document. Specific examples: reason phrase, error message
and description, root cause, and stack trace elements. You might consider this
out-of-scope for your patch, which is okay.

[1]
http://stackoverflow.com/questions/5916340/using-only-cr-as-linebreak-inside-pre-tag-doesnt-work

-- 
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to