[GUMP@vmgump]: Project tomcat-trunk-test-apr (in module tomcat-trunk) failed

2016-07-01 Thread Bill Barker
-commons/daemon/dist/bin/commons-daemon-20160701-native-src.tar.gz -Dexamples.sources.skip=true -Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs -Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar -Dtest.apr.loc=/srv/gump/public/workspace/tomcat-native

[GUMP@vmgump]: Project tomcat-tc8.0.x-test-apr (in module tomcat-8.0.x) failed

2016-07-01 Thread Bill Barker
space/objenesis/main/target/objenesis-2.5-SNAPSHOT.jar -Dexamples.sources.skip=true -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20160701.jar -Dtest.openssl.path=/srv/gump/public/workspace/openssl-1.0.2/dest-20160701/bin/openssl -Dexecute.test.nio=f

[GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2016-07-01 Thread Bill Barker
lic/workspace/apache-commons/beanutils/dist/commons-beanutils-20160701.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:/srv/gump/public/workspace/apache-commons/cli/target/commons-cli-1.4-SNAPSHOT.jar:/srv/gump/public/workspace/commons-lang-trunk/target/commons-lang3-3.5-SNAPS

[GUMP@vmgump]: Project tomcat-tc8.0.x-validate (in module tomcat-8.0.x) failed

2016-07-01 Thread Bill Barker
ump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20160701.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:/srv/gump/public/workspace/apache-commons/cli/target/commons-cli-1.4-SNAPSHOT.jar:/srv/gump/public/workspace/commons-lang-trunk/target/commons-la

JULI, log4j and 8.5.x

2016-07-01 Thread Mark Thomas
[1] has highlighted that the removal of JULI+log4j from 9.0.x has been partially back-ported to 8.5.x. I originally stated in [2] that I had no plans to back-port the removal of JULI+log4j support. I'd like to change that decision. Any objections to removal of JULI+log4j support from 8.5.x? If th

[Bug 59779] useRelativeRedirects being enabled breaks proxyPort and scheme

2016-07-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59779 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1751004 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/ java/org/apache/jasper/runtime/ java/org/apache/tomcat/websocket/ webapps/docs/

2016-07-01 Thread markt
Author: markt Date: Fri Jul 1 20:15:43 2016 New Revision: 1751004 URL: http://svn.apache.org/viewvc?rev=1751004&view=rev Log: Review of all calls to user code prior to calling InstanceManager.destroy() Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apach

svn commit: r1751001 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/core/ java/org/apache/coyote/ java/org/apache/jasper/runtime/ java/org/apache/tomcat/websocket/ webapps/docs/

2016-07-01 Thread markt
Author: markt Date: Fri Jul 1 20:05:04 2016 New Revision: 1751001 URL: http://svn.apache.org/viewvc?rev=1751001&view=rev Log: Review of all calls to user code prior to calling InstanceManager.destroy() Modified: tomcat/tc8.0.x/trunk/ (props changed) tomcat/tc8.0.x/trunk/java/org/apach

svn commit: r1751000 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/core/ java/org/apache/coyote/ java/org/apache/jasper/runtime/ java/org/apache/tomcat/websocket/ webapps/docs/

2016-07-01 Thread markt
Author: markt Date: Fri Jul 1 19:51:53 2016 New Revision: 1751000 URL: http://svn.apache.org/viewvc?rev=1751000&view=rev Log: Review of all calls to user code prior to calling InstanceManager.destroy() Modified: tomcat/tc8.5.x/trunk/ (props changed) tomcat/tc8.5.x/trunk/java/org/apach

svn commit: r1750995 - in /tomcat/trunk: java/org/apache/catalina/core/ java/org/apache/coyote/ java/org/apache/jasper/runtime/ java/org/apache/tomcat/websocket/ webapps/docs/

2016-07-01 Thread markt
Author: markt Date: Fri Jul 1 19:28:42 2016 New Revision: 1750995 URL: http://svn.apache.org/viewvc?rev=1750995&view=rev Log: Review of all calls to user code prior to calling InstanceManager.destroy() Modified: tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterConfig.java tomc

Re: leak if jspServlet.destroy() fails

2016-07-01 Thread Mark Thomas
On 01/07/2016 17:28, Romain Manni-Bucau wrote: > Think org.apache.jasper.runtime.TagHandlerPool#release can be affected too > - I'm not sure where it is called in the codebase but the pattern is the > same. I've doing a review of all calls to destroyInstance() now. There is at least one further is

[Bug 59779] useRelativeRedirects being enabled breaks proxyPort and scheme

2016-07-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59779 --- Comment #2 from NateC --- (In reply to Mark Thomas from comment #1) > (In reply to NateC from comment #0) > > Tomcat 7.0.67 added the ability respond with relative redirects, which > > defaults to enabled. If proxyPort or scheme is specifie

svn commit: r1750981 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/jasper/resources/LocalStrings.properties java/org/apache/jasper/servlet/JspServletWrapper.java webapps/docs/changelog.xml

2016-07-01 Thread markt
Author: markt Date: Fri Jul 1 16:35:46 2016 New Revision: 1750981 URL: http://svn.apache.org/viewvc?rev=1750981&view=rev Log: Catch and log any Exceptions during calls to Servlet.destroy() when destroying the Servlet associated with a JSP page. Modified: tomcat/tc6.0.x/trunk/ (props chang

svn commit: r1750980 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/jasper/resources/LocalStrings.properties java/org/apache/jasper/servlet/JspServletWrapper.java webapps/docs/changelog.xml

2016-07-01 Thread markt
Author: markt Date: Fri Jul 1 16:29:51 2016 New Revision: 1750980 URL: http://svn.apache.org/viewvc?rev=1750980&view=rev Log: Catch and log any Exceptions during calls to Servlet.destroy() when destroying the Servlet associated with a JSP page. Modified: tomcat/tc7.0.x/trunk/ (props chang

Re: leak if jspServlet.destroy() fails

2016-07-01 Thread Romain Manni-Bucau
Think org.apache.jasper.runtime.TagHandlerPool#release can be affected too - I'm not sure where it is called in the codebase but the pattern is the same. Romain Manni-Bucau @rmannibucau | Blog | Old Wordpress Blog

svn commit: r1750978 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/jasper/resources/LocalStrings.properties java/org/apache/jasper/servlet/JspServletWrapper.java webapps/docs/changelog.xml

2016-07-01 Thread markt
Author: markt Date: Fri Jul 1 16:26:19 2016 New Revision: 1750978 URL: http://svn.apache.org/viewvc?rev=1750978&view=rev Log: Catch and log any Exceptions during calls to Servlet.destroy() when destroying the Servlet associated with a JSP page. Modified: tomcat/tc8.0.x/trunk/ (props chang

svn commit: r1750976 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/jasper/resources/LocalStrings.properties java/org/apache/jasper/servlet/JspServletWrapper.java webapps/docs/changelog.xml

2016-07-01 Thread markt
Author: markt Date: Fri Jul 1 16:22:36 2016 New Revision: 1750976 URL: http://svn.apache.org/viewvc?rev=1750976&view=rev Log: Catch and log any Exceptions during calls to Servlet.destroy() when destroying the Servlet associated with a JSP page. Modified: tomcat/tc8.5.x/trunk/ (props chang

svn commit: r1750975 - in /tomcat/trunk: java/org/apache/jasper/resources/LocalStrings.properties java/org/apache/jasper/servlet/JspServletWrapper.java webapps/docs/changelog.xml

2016-07-01 Thread markt
Author: markt Date: Fri Jul 1 16:20:34 2016 New Revision: 1750975 URL: http://svn.apache.org/viewvc?rev=1750975&view=rev Log: Catch and log any Exceptions during calls to Servlet.destroy() when destroying the Servlet associated with a JSP page. Modified: tomcat/trunk/java/org/apache/jasper/

Re: leak if jspServlet.destroy() fails

2016-07-01 Thread Romain Manni-Bucau
+1 Romain Manni-Bucau @rmannibucau | Blog | Old Wordpress Blog | Github | LinkedIn | Tomitriber

Re: leak if jspServlet.destroy() fails

2016-07-01 Thread Mark Thomas
On 01/07/2016 16:41, Romain Manni-Bucau wrote: > Hello guys, > > if a jspDestroy() throws an Exception then the instance manager is not > called which can lead to some leaks depending the implementation (see > org.apache.jasper.servlet.JspServletWrapper#destroy) > > Would it be possible to have a

leak if jspServlet.destroy() fails

2016-07-01 Thread Romain Manni-Bucau
Hello guys, if a jspDestroy() throws an Exception then the instance manager is not called which can lead to some leaks depending the implementation (see org.apache.jasper.servlet.JspServletWrapper#destroy) Would it be possible to have a way to release/cleanup the jsp context through the instance

[Bug 59779] useRelativeRedirects being enabled breaks proxyPort and scheme

2016-07-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59779 --- Comment #1 from Mark Thomas --- (In reply to NateC from comment #0) > Tomcat 7.0.67 added the ability respond with relative redirects, which > defaults to enabled. If proxyPort or scheme is specified in the connector > which a context uses

[Bug 59779] New: useRelativeRedirects being enabled breaks proxyPort and scheme

2016-07-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59779 Bug ID: 59779 Summary: useRelativeRedirects being enabled breaks proxyPort and scheme Product: Tomcat 7 Version: 7.0.67 Hardware: PC OS: Linux

Re: Bug that spans tomcat and tomcat-native

2016-07-01 Thread Nate Clark
On Tue, Jun 28, 2016 at 12:37 PM, Rainer Jung wrote: > Am 28.06.2016 um 18:06 schrieb therealnewo...@gmail.com: >> >> On Tue, Jun 28, 2016 at 11:51 AM, Rainer Jung >> wrote: >>> >>> Am 28.06.2016 um 16:07 schrieb Mark Thomas: On 28/06/2016 12:28, Mark Thomas wrote: > >

svn commit: r1750942 - in /tomcat/site/trunk: docs/download-90.html xdocs/download-90.xml

2016-07-01 Thread markt
Author: markt Date: Fri Jul 1 14:17:04 2016 New Revision: 1750942 URL: http://svn.apache.org/viewvc?rev=1750942&view=rev Log: Remove JULI extras download links since these are no longer produced Modified: tomcat/site/trunk/docs/download-90.html tomcat/site/trunk/xdocs/download-90.xml Mo

[Bug 59778] tomcat-embed-logging-log4j artifact not published to Maven Central

2016-07-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59778 --- Comment #1 from Mark Thomas --- It is deliberate. That JAR (and related JARs) is no longer part of the distribution. It looks like we still have some clean-up to do. -- You are receiving this mail because: You are the assignee for the bug

[Bug 59778] New: tomcat-embed-logging-log4j artifact not published to Maven Central

2016-07-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59778 Bug ID: 59778 Summary: tomcat-embed-logging-log4j artifact not published to Maven Central Product: Tomcat 8 Version: 8.5.3 Hardware: PC OS: All

[Bug 59701] Improve the documentation when maxPostSize=0

2016-07-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59701 Mark Thomas changed: What|Removed |Added Resolution|--- |WONTFIX Status|NEW

[Bug 59710] java.io.IOException: Connection timed out

2016-07-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59710 Mark Thomas changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #6 from Mark Thomas

[Bug 59774] Trailing dot still present in docs of AccessLogValve

2016-07-01 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59774 Mark Thomas changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

svn commit: r1750901 - in /tomcat/tc8.0.x/trunk: ./ webapps/docs/changelog.xml webapps/docs/config/context.xml webapps/docs/config/engine.xml webapps/docs/config/host.xml webapps/docs/config/valve.xml

2016-07-01 Thread markt
Author: markt Date: Fri Jul 1 10:28:39 2016 New Revision: 1750901 URL: http://svn.apache.org/viewvc?rev=1750901&view=rev Log: Correct the prefix values in the the documented examples for configuring the AccessLogValve. Patch provided by Mike Noordermeer. Modified: tomcat/tc8.0.x/trunk/ (p

svn commit: r1750900 - in /tomcat/tc8.5.x/trunk: ./ webapps/docs/changelog.xml webapps/docs/config/context.xml webapps/docs/config/engine.xml webapps/docs/config/host.xml webapps/docs/config/valve.xml

2016-07-01 Thread markt
Author: markt Date: Fri Jul 1 10:27:56 2016 New Revision: 1750900 URL: http://svn.apache.org/viewvc?rev=1750900&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=59774 Correct the prefix values in the the documented examples for configuring the AccessLogValve. Patch provided by Mi

svn commit: r1750899 - in /tomcat/trunk/webapps/docs: changelog.xml config/context.xml config/engine.xml config/host.xml config/valve.xml

2016-07-01 Thread markt
Author: markt Date: Fri Jul 1 10:26:30 2016 New Revision: 1750899 URL: http://svn.apache.org/viewvc?rev=1750899&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=59774 Correct the prefix values in the the documented examples for configuring the AccessLogValve. Patch provided by Mi

[GUMP@vmgump]: Project tomcat-trunk-test-nio2 (in module tomcat-trunk) failed

2016-07-01 Thread Bill Barker
t-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20160701-native-src.tar.gz -Dexamples.sources.skip=true -Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs -Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar -Dt

Re: [VOTE] Release Apache Tomcat Native 1.2.8

2016-07-01 Thread Mark Thomas
On 28/06/2016 21:25, Mark Thomas wrote: > Version 1.2.8 includes the following changes: > > - Fix OCSP / no OCSP status of Windows builds > - Improve handling of OS level EAGAIN return codes > - Fix a potential performance problem on Linux and OSX > > The proposed release artefacts can be found

[GUMP@vmgump]: Project tomcat-tc8.0.x-test-nio (in module tomcat-8.0.x) failed

2016-07-01 Thread Bill Barker
t-native.tar.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20160701-native-src.tar.gz -Dexamples.sources.skip=true -Dbase.path=/srv/gump/public/workspace/tomcat-8.0.x/tomcat-build-libs -Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar -Dt

[GUMP@vmgump]: Project tomcat-trunk-test-nio (in module tomcat-trunk) failed

2016-07-01 Thread Bill Barker
.gz=/srv/gump/public/workspace/apache-commons/daemon/dist/bin/commons-daemon-20160701-native-src.tar.gz -Dexamples.sources.skip=true -Dbase.path=/srv/gump/public/workspace/tomcat-trunk/tomcat-build-libs -Djdt.jar=/srv/gump/packages/eclipse/plugins/R-4.5-201506032000/ecj-4.5.jar -Dtest.relaxTi