Re: svn commit: r1723410 - in /tomcat/trunk: java/org/apache/catalina/manager/host/HostManagerServlet.java test/org/apache/catalina/core/TestStandardContextResources.java test/org/apache/catalina/star

Hi Mark, 2016-01-06 22:06 GMT+02:00 : > > Author: markt > Date: Wed Jan 6 20:06:51 2016 > New Revision: 1723410 > > URL: http://svn.apache.org/viewvc?rev=1723410&view=rev > Log: > Avoid wheel re-invention. Use the available utility class for copying between streams. Wouldn't it be better to use

[Bug 51503] Additional error checking required for connector port attribute (e.g. for port="")

https://bz.apache.org/bugzilla/show_bug.cgi?id=51503 --- Comment #11 from Konstantin Kolinko --- Created attachment 33417 --> https://bz.apache.org/bugzilla/attachment.cgi?id=33417&action=edit catalina.2016-01-07.log (2) The log from testing the implemented feature. For a reference. Tomcat 6

[Bug 51503] Additional error checking required for connector port attribute (e.g. for port="")

https://bz.apache.org/bugzilla/show_bug.cgi?id=51503 --- Comment #10 from Konstantin Kolinko --- Implemented in Tomcat 6 by r1723466 and will be in 6.0.45 onwards. -- You are receiving this mail because: You are the assignee for the bug.

svn commit: r1723466 - in /tomcat/tc6.0.x/trunk: java/org/apache/catalina/connector/Connector.java java/org/apache/catalina/connector/LocalStrings.properties webapps/docs/changelog.xml

Author: kkolinko Date: Thu Jan 7 06:12:35 2016 New Revision: 1723466 URL: http://svn.apache.org/viewvc?rev=1723466&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=51503 Add additional validation that prevents a connector from starting if it does not have a valid port number. A

[Bug 51503] Additional error checking required for connector port attribute (e.g. for port="")

https://bz.apache.org/bugzilla/show_bug.cgi?id=51503 --- Comment #9 from Konstantin Kolinko --- Created attachment 33416 --> https://bz.apache.org/bugzilla/attachment.cgi?id=33416&action=edit catalina.2016-01-07.log I reviewed the fix (r1147949) with the question of backporting it to current T

[Bug 58817] ArrayIndexOutOfBoundsException at shutdown if running with mapperContextRootRedirectEnabled="false"

https://bz.apache.org/bugzilla/show_bug.cgi?id=58817 Konstantin Kolinko changed: What|Removed |Added OS||All --- Comment #1 from Konstanti

[Bug 58817] New: ArrayIndexOutOfBoundsException at shutdown if running with mapperContextRootRedirectEnabled="false"

https://bz.apache.org/bugzilla/show_bug.cgi?id=58817 Bug ID: 58817 Summary: ArrayIndexOutOfBoundsException at shutdown if running with mapperContextRootRedirectEnabled="false" Product: Tomcat 6 Version: unspecified Hardware

Re: jdbc pool jmx enhancements

On Tue, Jan 5, 2016 at 4:11 PM, Christopher Schultz < ch...@christopherschultz.net> wrote: > > I'm using tomcat 8.0.30. > > > > Looking through the jmx mbeans i did not see the BorrowedCount or > > CreatedCount attributes as I did when using dbcp2. > > I use these in my monitoring software to grap

[Bug 58816] New: additional jdbc pool mbean attributes - CreatedCount, BorrowedCount

https://bz.apache.org/bugzilla/show_bug.cgi?id=58816 Bug ID: 58816 Summary: additional jdbc pool mbean attributes - CreatedCount, BorrowedCount Product: Tomcat 8 Version: trunk Hardware: All OS: All

svn commit: r1723443 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/catalina/connector/mbeans-descriptors.xml

Author: kkolinko Date: Thu Jan 7 00:59:31 2016 New Revision: 1723443 URL: http://svn.apache.org/viewvc?rev=1723443&view=rev Log: Fix typo in description of "port" property of CoyoteConnector MBean. Merged r1190476 from tomcat/tc7.0.x/trunk: This is not AJP specific Modified: tomcat/tc6.0.x/

svn commit: r1723441 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/connector/Connector.java

Author: kkolinko Date: Thu Jan 7 00:31:54 2016 New Revision: 1723441 URL: http://svn.apache.org/viewvc?rev=1723441&view=rev Log: Simplify: Do not call a getter twice, use the value from a local variable. No functional change. (Review of r1207695) For https://issues.apache.org/bugzilla/show_bug.c

svn commit: r1723440 - in /tomcat/tc8.0.x/trunk: ./ java/org/apache/catalina/connector/Connector.java

Author: kkolinko Date: Thu Jan 7 00:28:33 2016 New Revision: 1723440 URL: http://svn.apache.org/viewvc?rev=1723440&view=rev Log: Simplify: Do not call a getter twice, use the value from a local variable. No functional change. (Review of r1207695) Merged r1723437 from tomcat/trunk. Modified:

svn commit: r1723437 - /tomcat/trunk/java/org/apache/catalina/connector/Connector.java

Author: kkolinko Date: Thu Jan 7 00:26:18 2016 New Revision: 1723437 URL: http://svn.apache.org/viewvc?rev=1723437&view=rev Log: Simplify: Do not call a getter twice, use the value from a local variable. No functional change. (Review of r1207695) Modified: tomcat/trunk/java/org/apache/catal

svn commit: r1723416 - /tomcat/tc6.0.x/branches/tomcat6-testing_20160106/BRANCH-README.txt

Author: kkolinko Date: Wed Jan 6 21:56:36 2016 New Revision: 1723416 URL: http://svn.apache.org/viewvc?rev=1723416&view=rev Log: Add reference to Tomcat 7 revisions that implement the features that I want to backport. (Reviewed svn log of Tomcat 7) Modified: tomcat/tc6.0.x/branches/tomcat6-

[Bug 58809] Session info missing in request when using parallel deployment

https://bz.apache.org/bugzilla/show_bug.cgi?id=58809 --- Comment #1 from Mark Thomas --- Thanks for the report and analysis. I've fixed this in trunk (for 9.0.0.M2 onwards) and the tests pass locally but I want to wait a day or so to give folks a chance to review this and to confirm that the CI s

svn commit: r1723414 - in /tomcat/trunk/java/org/apache/catalina/connector: CoyoteAdapter.java Request.java

Author: markt Date: Wed Jan 6 21:52:24 2016 New Revision: 1723414 URL: http://svn.apache.org/viewvc?rev=1723414&view=rev Log: Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58809 Correctly recycle the cookies when mapping requests for parallel deployment Modified: tomcat/trunk/java/org/a

[Bug 58813] Incoming requests hang after a website using the ISAPI connector is restarted

https://bz.apache.org/bugzilla/show_bug.cgi?id=58813 Matthew Reiter changed: What|Removed |Added OS||Windows Server 2012 -- You are recei

[Bug 58813] New: Incoming requests hang after a website using the ISAPI connector is restarted

https://bz.apache.org/bugzilla/show_bug.cgi?id=58813 Bug ID: 58813 Summary: Incoming requests hang after a website using the ISAPI connector is restarted Product: Tomcat Connectors Version: 1.2.33 Hardware: PC S

svn commit: r1723410 - in /tomcat/trunk: java/org/apache/catalina/manager/host/HostManagerServlet.java test/org/apache/catalina/core/TestStandardContextResources.java test/org/apache/catalina/startup/

Author: markt Date: Wed Jan 6 20:06:51 2016 New Revision: 1723410 URL: http://svn.apache.org/viewvc?rev=1723410&view=rev Log: Avoid wheel re-invention. Use the available utility class for copying between streams. Modified: tomcat/trunk/java/org/apache/catalina/manager/host/HostManagerServle

svn commit: r1723409 - /tomcat/trunk/TOMCAT-NEXT.txt

Author: markt Date: Wed Jan 6 19:50:39 2016 New Revision: 1723409 URL: http://svn.apache.org/viewvc?rev=1723409&view=rev Log: Another ~100 warnings eliminated Modified: tomcat/trunk/TOMCAT-NEXT.txt Modified: tomcat/trunk/TOMCAT-NEXT.txt URL: http://svn.apache.org/viewvc/tomcat/trunk/TOMCAT

svn commit: r1723408 - /tomcat/trunk/java/org/apache/catalina/tribes/util/StringManager.java

Author: markt Date: Wed Jan 6 19:49:47 2016 New Revision: 1723408 URL: http://svn.apache.org/viewvc?rev=1723408&view=rev Log: Javadoc Modified: tomcat/trunk/java/org/apache/catalina/tribes/util/StringManager.java Modified: tomcat/trunk/java/org/apache/catalina/tribes/util/StringManager.java

Re: [VOTE-RESTARTED] Release Apache Tomcat Native 1.2.4

On 06/01/2016 19:34, Rainer Jung wrote: > Hi Mark, > > there's no file bin/openssl.exe in the Windows binariy zip files. > > It existed in 1.2.3 but was also missing for 1.2.2. It also exists in > 1.2.0 and 1.2.1 as well as 1.1.33 and 1.1.34. So I guess it should be > included for 1.2.4 as well?

svn commit: r1723406 - in /tomcat/trunk/java/org/apache/tomcat/util/net: Nio2Channel.java NioChannel.java SocketWrapperBase.java

Author: markt Date: Wed Jan 6 19:43:12 2016 New Revision: 1723406 URL: http://svn.apache.org/viewvc?rev=1723406&view=rev Log: Javadoc fixes Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Nio2Channel.java tomcat/trunk/java/org/apache/tomcat/util/net/NioChannel.java tomcat/trun

Re: [VOTE-RESTARTED] Release Apache Tomcat Native 1.2.4

Hi Mark, there's no file bin/openssl.exe in the Windows binariy zip files. It existed in 1.2.3 but was also missing for 1.2.2. It also exists in 1.2.0 and 1.2.1 as well as 1.1.33 and 1.1.34. So I guess it should be included for 1.2.4 as well? Only talking about the binary release artefact he

[GUMP@vmgump]: Project tomcat-tc7.0.x-test-bio (in module tomcat-7.0.x) failed

it/target/junit-4.13-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.3-SNAPSHOT.jar -Dexamples.sources.skip=true -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20160106.jar -Dtomcat-dbcp-src.jar=/srv/gump/public/wo

Tomcat9 Removal of support for Comet

Hello Devs, My team currently uses tomcat8 to serve our Scala application developed using lift. Our application uses comet to send real time data from the server to the client. Unfortunately we noticed that in the new release of tomcat - tomcat9, comet is no longer supported because * W

svn commit: r1723382 - /tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/util/

Author: markt Date: Wed Jan 6 17:11:09 2016 New Revision: 1723382 URL: http://svn.apache.org/viewvc?rev=1723382&view=rev Log: Remove now empty package. Removed: tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/util/

svn commit: r1723381 - /tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/util/SingleRemoveSynchronizedAddLock.java

Author: markt Date: Wed Jan 6 17:10:23 2016 New Revision: 1723381 URL: http://svn.apache.org/viewvc?rev=1723381&view=rev Log: Remove deprecated code Removed: tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/util/SingleRemoveSynchronizedAddLock.java --

svn commit: r1723380 - /tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/util/SingleRemoveSynchronizedAddLock.java

Author: markt Date: Wed Jan 6 17:10:02 2016 New Revision: 1723380 URL: http://svn.apache.org/viewvc?rev=1723380&view=rev Log: Deprecate unused class. Modified: tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/util/SingleRemoveSynchronizedAddLock.java Modified: tomcat/trunk/java/

svn commit: r1723378 - /tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/util/LinkObject.java

Author: markt Date: Wed Jan 6 17:08:54 2016 New Revision: 1723378 URL: http://svn.apache.org/viewvc?rev=1723378&view=rev Log: Remove deprecated code Removed: tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/util/LinkObject.java ---

svn commit: r1723376 - /tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/MessageDispatchInterceptor.java

Author: markt Date: Wed Jan 6 17:08:18 2016 New Revision: 1723376 URL: http://svn.apache.org/viewvc?rev=1723376&view=rev Log: Remove deprecated code Modified: tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/MessageDispatchInterceptor.java Modified: tomcat/trunk/java/org/ap

svn commit: r1723377 - /tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/util/LinkObject.java

Author: markt Date: Wed Jan 6 17:08:39 2016 New Revision: 1723377 URL: http://svn.apache.org/viewvc?rev=1723377&view=rev Log: Deprecate now unused class. Modified: tomcat/trunk/java/org/apache/catalina/tribes/transport/bio/util/LinkObject.java Modified: tomcat/trunk/java/org/apache/catali

svn commit: r1723375 - /tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/MessageDispatchInterceptor.java

Author: markt Date: Wed Jan 6 17:06:51 2016 New Revision: 1723375 URL: http://svn.apache.org/viewvc?rev=1723375&view=rev Log: Refactor to remove use of unnecessary LinkObject Modified: tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/MessageDispatchInterceptor.java Modified:

svn commit: r1723373 - /tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/MessageDispatchInterceptor.java

Author: markt Date: Wed Jan 6 17:00:24 2016 New Revision: 1723373 URL: http://svn.apache.org/viewvc?rev=1723373&view=rev Log: Remove deprecated code Modified: tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/MessageDispatchInterceptor.java Modified: tomcat/trunk/java/org/ap

svn commit: r1723371 - /tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/MessageDispatchInterceptor.java

Author: markt Date: Wed Jan 6 16:59:02 2016 New Revision: 1723371 URL: http://svn.apache.org/viewvc?rev=1723371&view=rev Log: More deprecation now an Executor is used to send messages. Modified: tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/MessageDispatchInterceptor.java

svn commit: r1723369 - in /tomcat/trunk/java/org/apache/catalina/tribes: group/interceptors/MessageDispatch15Interceptor.java group/interceptors/MessageDispatchInterceptor.java transport/bio/util/Fast

Author: markt Date: Wed Jan 6 16:55:36 2016 New Revision: 1723369 URL: http://svn.apache.org/viewvc?rev=1723369&view=rev Log: Remove deprecated code Removed: tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/MessageDispatch15Interceptor.java tomcat/trunk/java/org/apache/c

svn commit: r1723368 - in /tomcat/trunk: java/org/apache/catalina/ha/tcp/ java/org/apache/catalina/tribes/group/ java/org/apache/catalina/tribes/group/interceptors/ java/org/apache/catalina/tribes/tra

Author: markt Date: Wed Jan 6 16:54:38 2016 New Revision: 1723368 URL: http://svn.apache.org/viewvc?rev=1723368&view=rev Log: MessageDispatch15Interceptor was used to add Java 5 features to MessageDispatchInterceptor. Since the minimum Java version is now >=5 (and has been since Tomcat 6) there

buildbot success in ASF Buildbot on tomcat-trunk

The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/869 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchSche

Re: jdbc pool: validationQuery vs Connection.isValid

On Wed, Jan 6, 2016 at 10:10 AM, Julian Reschke wrote: > On 2016-01-06 15:21, Christopher Schultz wrote: > >> Julian, >> >> On 1/6/16 7:42 AM, Julian Reschke wrote: >> >>> On 2016-01-06 00:06, Christopher Schultz wrote: >>> Julian, On 1/5/16 9:25 AM, Julian Reschke wrote:

svn commit: r1723346 - /tomcat/trunk/java/org/apache/catalina/security/SecurityClassLoad.java

Author: markt Date: Wed Jan 6 15:17:37 2016 New Revision: 1723346 URL: http://svn.apache.org/viewvc?rev=1723346&view=rev Log: Follow-up to r1723322. o.a.t.util.net.URL has been removed. Modified: tomcat/trunk/java/org/apache/catalina/security/SecurityClassLoad.java Modified: tomcat/trunk/ja

Re: jdbc pool: validationQuery vs Connection.isValid

On 2016-01-06 15:21, Christopher Schultz wrote: Julian, On 1/6/16 7:42 AM, Julian Reschke wrote: On 2016-01-06 00:06, Christopher Schultz wrote: Julian, On 1/5/16 9:25 AM, Julian Reschke wrote: Hi there, maybe that's a stupid question, but why do we need a configurable validationQuery when

Re: jdbc pool: validationQuery vs Connection.isValid

Julian, On 1/6/16 7:42 AM, Julian Reschke wrote: > On 2016-01-06 00:06, Christopher Schultz wrote: >> Julian, >> >> On 1/5/16 9:25 AM, Julian Reschke wrote: >>> Hi there, >>> >>> maybe that's a stupid question, but why do we need a configurable >>> validationQuery when there's >>> >>>Connectio

buildbot failure in ASF Buildbot on tomcat-trunk

The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/868 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: silvanus_ubuntu Build Reason: The AnyBranchSchedul

[Bug 58809] New: Session info missing in request when using parallel deployment

https://bz.apache.org/bugzilla/show_bug.cgi?id=58809 Bug ID: 58809 Summary: Session info missing in request when using parallel deployment Product: Tomcat 8 Version: trunk Hardware: All OS: All S

svn commit: r1723322 - /tomcat/trunk/java/org/apache/tomcat/util/net/URL.java

Author: markt Date: Wed Jan 6 13:49:40 2016 New Revision: 1723322 URL: http://svn.apache.org/viewvc?rev=1723322&view=rev Log: Drop unused class Removed: tomcat/trunk/java/org/apache/tomcat/util/net/URL.java - To unsubscrib

svn commit: r1723318 - /tomcat/trunk/java/org/apache/tomcat/util/net/URL.java

Author: markt Date: Wed Jan 6 13:37:54 2016 New Revision: 1723318 URL: http://svn.apache.org/viewvc?rev=1723318&view=rev Log: Deprecate now unused class. Modified: tomcat/trunk/java/org/apache/tomcat/util/net/URL.java Modified: tomcat/trunk/java/org/apache/tomcat/util/net/URL.java URL: htt

svn commit: r1723317 - in /tomcat/trunk/java/org/apache/catalina: connector/Response.java valves/rewrite/RewriteValve.java

Author: markt Date: Wed Jan 6 13:37:16 2016 New Revision: 1723317 URL: http://svn.apache.org/viewvc?rev=1723317&view=rev Log: Switch to use the new UriUtil class. Modified: tomcat/trunk/java/org/apache/catalina/connector/Response.java tomcat/trunk/java/org/apache/catalina/valves/rewrite/

svn commit: r1723316 - /tomcat/trunk/java/org/apache/catalina/util/UriUtil.java

Author: markt Date: Wed Jan 6 13:36:56 2016 New Revision: 1723316 URL: http://svn.apache.org/viewvc?rev=1723316&view=rev Log: Create a new UriUtil class that contains only those parts of o.a.tomcat.util.URI that a) are required by Tomcat and b) aren't provided by the JRE. Added: tomcat/tru

Re: [VOTE-RESTARTED] Release Apache Tomcat Native 1.2.4

2016-01-06 13:56 GMT+01:00 Mark Thomas : > On 05/01/2016 15:46, Mark Thomas wrote: > > Version 1.2.4 includes the following change: > > > > - Renegotiation improvements > > > > The proposed release artefacts can be found at [1], > > and the build was done using tag [2]. > > > > The Apache Tomcat N

Re: [VOTE-RESTARTED] Release Apache Tomcat Native 1.2.4

On 05/01/2016 15:46, Mark Thomas wrote: > Version 1.2.4 includes the following change: > > - Renegotiation improvements > > The proposed release artefacts can be found at [1], > and the build was done using tag [2]. > > The Apache Tomcat Native 1.2.4 is > [ ] Stable, go ahead and release > [ ]

svn commit: r11828 - /dev/tomcat/tomcat-connectors/native/1.2.4/binaries/

Author: markt Date: Wed Jan 6 12:53:25 2016 New Revision: 11828 Log: Update binaries Modified: dev/tomcat/tomcat-connectors/native/1.2.4/binaries/tomcat-native-1.2.4-ocsp-win32-bin.zip dev/tomcat/tomcat-connectors/native/1.2.4/binaries/tomcat-native-1.2.4-ocsp-win32-bin.zip.asc de

Re: jdbc pool: validationQuery vs Connection.isValid

On 2016-01-06 00:06, Christopher Schultz wrote: Julian, On 1/5/16 9:25 AM, Julian Reschke wrote: Hi there, maybe that's a stupid question, but why do we need a configurable validationQuery when there's Connection.isValid(...)

[GUMP@vmgump]: Project tomcat-tc7.0.x-test-nio (in module tomcat-7.0.x) failed

jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.3-SNAPSHOT.jar -Dexamples.sources.skip=true -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20160106.jar -

[GUMP@vmgump]: Project tomcat-tc7.0.x-test-apr (in module tomcat-7.0.x) failed

it/target/junit-4.13-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.3-SNAPSHOT.jar -Dexamples.sources.skip=true -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20160106.jar -Dtomcat-dbcp-src.jar=/srv/gump/public/wo

[GUMP@vmgump]: Project tomcat-tc7.0.x-test-bio (in module tomcat-7.0.x) failed

jar=/srv/gump/public/workspace/junit/target/junit-4.13-SNAPSHOT.jar -Dobjenesis.jar=/srv/gump/public/workspace/objenesis/main/target/objenesis-2.3-SNAPSHOT.jar -Dexamples.sources.skip=true -Dcommons-daemon.jar=/srv/gump/public/workspace/apache-commons/daemon/dist/commons-daemon-20160106.jar -

svn commit: r1723250 - /tomcat/trunk/build.xml

Author: ognjen Date: Wed Jan 6 08:32:30 2016 New Revision: 1723250 URL: http://svn.apache.org/viewvc?rev=1723250&view=rev Log: Typo (Eclipse workplace -> Eclipse workspace) Modified: tomcat/trunk/build.xml Modified: tomcat/trunk/build.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/buil