https://bz.apache.org/bugzilla/show_bug.cgi?id=51503
--- Comment #9 from Konstantin Kolinko <knst.koli...@gmail.com> --- Created attachment 33416 --> https://bz.apache.org/bugzilla/attachment.cgi?id=33416&action=edit catalina.2016-01-07.log I reviewed the fix (r1147949) with the question of backporting it to current Tomcat 6, while working on bug 52028. The current behaviour of Tomcat 6: 1). The installer part of the fix r1147949 (tomcat.nsi) has already been backported to Tomcat 6. I tested installer for 6.0.44. It has this feature and works well. 2). The message "Acceptor thread .. failed to unlock." from Comment 0 is observed when running with APR connector. I tested the current 6.0.x/trunk (6.0.45-dev) With APR connectors there is a delay of 10 seconds for each connector during Tomcat shutdown. The message is printed only once, not 30 times. > 07.01.2016 8:04:54 org.apache.tomcat.util.net.AprEndpoint stop > WARNING: Acceptor thread [http-0-Acceptor-0] failed to unlock. Forcing hard > socket shutdown. There is no message when running with BIO connectors, and there are no delays during shutdown. Thus only APR connectors are affected. I will attach the logs, for a reference. My conclusion: 1). It is worth fixing AprEndpoint so that it does not try connecting to a wrong port number and does not print that message. I think the AprEndpoint issue will be addressed under bug 52028 / r1208115. 2). It is worth protecting from missing port number, but it is not worth rejecting the port number of 0 like r1147949 does. The value of 0 may be a valid use case now, and it will be a valid use case once bug 52028 is implemented. Tomcat 7 (since r1207695) uses the default of -1. -- You are receiving this mail because: You are the assignee for the bug. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
