To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at gene...@gump.apache.org.
Project tomcat-tc7.0.x-test-bio has an issue affecting its community
integration.
Author: violetagg
Date: Tue Dec 1 07:54:50 2015
New Revision: 1717385
URL: http://svn.apache.org/viewvc?rev=1717385&view=rev
Log:
Follow up to r1717311
Modified:
tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java
tomcat/trunk/java/org/apache/catalina/valves/rewrite/Rewrit
As most of you probably know FOSDEM 2016 (the biggest,
100% free open source developer conference) is right
around the corner:
https://fosdem.org/2016/
We hope to have an ASF booth and we would love to see as
many ASF projects as possible present at various tracks
(AKA Developer rooms):
htt
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at gene...@gump.apache.org.
Project tomcat-tc8.0.x-test-apr has an issue affecting its community
integration.
To whom it may engage...
This is an automated request, but not an unsolicited one. For
more information please visit http://gump.apache.org/nagged.html,
and/or contact the folk at gene...@gump.apache.org.
Project tomcat-tc8.0.x-test-nio2 has an issue affecting its community
integration
https://bz.apache.org/bugzilla/show_bug.cgi?id=56917
--- Comment #11 from Ajay Sindwani ---
@Mark Thomas
Logically since 7/8 backports, existing app servers, will receive your patch
through minor upgrades, the defaults should maintain the existing behavior to
prevent wasted labor and troubleshoo
https://bz.apache.org/bugzilla/show_bug.cgi?id=58626
--- Comment #15 from Michael Osipov <1983-01...@gmx.net> ---
(In reply to Konstantin Kolinko from comment #14)
> (In reply to Michael Osipov from comment #13)
>
> If you do not know what the license is, I prefer you not to show us that
> code.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58646
--- Comment #10 from Christopher Schultz ---
(In reply to Alexander Malyshev from comment #9)
> Well, I don't see how NullPointer in Tomcat code can possibly be an
> application bug.
package com.your.code;
public class BrokeFilter implements
https://bz.apache.org/bugzilla/show_bug.cgi?id=58626
--- Comment #14 from Konstantin Kolinko ---
(In reply to Michael Osipov from comment #13)
If you do not know what the license is, I prefer you not to show us that code.
--
You are receiving this mail because:
You are the assignee for the bug
https://bz.apache.org/bugzilla/show_bug.cgi?id=58657
--- Comment #9 from Mark Thomas ---
OK. I have this working now. Some additional details for other people who want
to try this test case:
- URL expects POST requests. I used JMeter to send one.
- The POST body needs to be big enough that it isn
https://bz.apache.org/bugzilla/show_bug.cgi?id=58626
--- Comment #13 from Michael Osipov <1983-01...@gmx.net> ---
(In reply to Christopher Schultz from comment #11)
> (In reply to Michael Osipov from comment #10)
> > (In reply to Christopher Schultz from comment #9)
> > > Michael, can you provide
https://bz.apache.org/bugzilla/show_bug.cgi?id=56917
--- Comment #10 from Mark Thomas ---
I haven't found a client that doesn't support it yet. I did find one reference
for curl [1] that suggests back then all browsers supported various forms of
relative redirects.
[1] http://daniel.haxx.se/blog
https://bz.apache.org/bugzilla/show_bug.cgi?id=58646
--- Comment #9 from Alexander Malyshev ---
Well, I don't see how NullPointer in Tomcat code can possibly be an application
bug.
I forgot about these two valves, but, again, they never store request/response
objects so they definitely are not u
https://bz.apache.org/bugzilla/show_bug.cgi?id=58655
--- Comment #5 from Mark Thomas ---
The scheme isn't re-written. If you redirect using an absolute URI with a
specific scheme then that is what you get. If you want the scheme to be
"rewritten"/correct then use a relative redirect.
--
You are
Author: markt
Date: Mon Nov 30 19:50:39 2015
New Revision: 1717311
URL: http://svn.apache.org/viewvc?rev=1717311&view=rev
Log:
FindBugs niggle
Modified:
tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java
Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11Processor.java
U
The Buildbot has detected a restored build on builder tomcat-7-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-7-trunk/builds/212
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranch
https://bz.apache.org/bugzilla/show_bug.cgi?id=58655
--- Comment #4 from Cristian Klein ---
Thanks for the fix. I'm not sure to understand how the fix helps. What line or
what mechanism rewrites the scheme from `http` to `https`?
--
You are receiving this mail because:
You are the assignee for
Author: markt
Date: Mon Nov 30 18:56:55 2015
New Revision: 1717302
URL: http://svn.apache.org/viewvc?rev=1717302&view=rev
Log:
Fix import for moved Tester class
Modified:
tomcat/tc7.0.x/trunk/test/org/apache/tomcat/websocket/server/TestWsServerContainer.java
Modified:
tomcat/tc7.0.x/trunk/
Author: markt
Date: Mon Nov 30 18:21:53 2015
New Revision: 1717301
URL: http://svn.apache.org/viewvc?rev=1717301&view=rev
Log:
Java 6, not Java 7.
Modified:
tomcat/tc7.0.x/trunk/test/org/apache/tomcat/unittest/TesterRequest.java
tomcat/tc7.0.x/trunk/test/org/apache/tomcat/unittest/Tester
https://bz.apache.org/bugzilla/show_bug.cgi?id=58626
--- Comment #12 from Konstantin Kolinko ---
(In reply to Michael Osipov from comment #10)
What is the license for those scripts?
--
You are receiving this mail because:
You are the assignee for the bug.
-
https://bz.apache.org/bugzilla/show_bug.cgi?id=58626
--- Comment #11 from Christopher Schultz ---
(In reply to Michael Osipov from comment #10)
> (In reply to Christopher Schultz from comment #9)
> > Michael, can you provide a reference that says that HP-UX sends a SIGHUP to
> > processes after i
https://bz.apache.org/bugzilla/show_bug.cgi?id=58658
--- Comment #2 from Christopher Schultz ---
(In reply to Mark Thomas from comment #1)
> I've reverted r1715984 and refactored the code that required 1.7 so it
> compiles with 1.6. The fix will be in 7.0.67 onwards.
It's not an issue of compili
The Buildbot has detected a restored build on builder tomcat-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/704
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchSche
The Buildbot has detected a restored build on builder tomcat-8-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-8-trunk/builds/312
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranch
https://bz.apache.org/bugzilla/show_bug.cgi?id=58657
--- Comment #8 from Jonathan ---
(In reply to Mark Thomas from comment #7)
> Daft question. What URL do I need to request to see the issue?
Not daft at all, terrible naming convention on my part...
http://localhost:8080/demo-0.0.1-SNAPSHOT/de
https://bz.apache.org/bugzilla/show_bug.cgi?id=58657
--- Comment #7 from Mark Thomas ---
Daft question. What URL do I need to request to see the issue?
--
You are receiving this mail because:
You are the assignee for the bug.
https://bz.apache.org/bugzilla/show_bug.cgi?id=58626
--- Comment #10 from Michael Osipov <1983-01...@gmx.net> ---
(In reply to Christopher Schultz from comment #9)
> Michael, can you provide a reference that says that HP-UX sends a SIGHUP to
> processes after init runs? I found a thread on unix.st
https://bz.apache.org/bugzilla/show_bug.cgi?id=56917
--- Comment #9 from Mark Thomas ---
The complexity is to ensure that the session ID only gets added if the redirect
is to a location within the current web application.
In nearly all cases it will get skipped anyway since the session will have
https://bz.apache.org/bugzilla/show_bug.cgi?id=56917
--- Comment #8 from Remy Maucherat ---
Not really related, the processing for session id encoding in the URL
(encodeRedirectURL and encodeURL) is extraordinarily complex and expensive. I
don't remember why it looks like that.
--
You are recei
https://bz.apache.org/bugzilla/show_bug.cgi?id=56917
--- Comment #7 from Remy Maucherat ---
I verified the behavior with a telnet. If it is known all clients are
compatible, then it should be fine. I read in the original description "many
modern browsers support 302s to relative Locations", so wh
https://bz.apache.org/bugzilla/show_bug.cgi?id=58655
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
Author: markt
Date: Mon Nov 30 16:29:01 2015
New Revision: 1717292
URL: http://svn.apache.org/viewvc?rev=1717292&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58655
Fix an IllegalStateException when calling HttpServletResponse.sendRedirect()
with the RemoteIpFilter. This was ca
Author: markt
Date: Mon Nov 30 16:27:06 2015
New Revision: 1717291
URL: http://svn.apache.org/viewvc?rev=1717291&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58655
Fix an IllegalStateException when calling HttpServletResponse.sendRedirect()
with the RemoteIpFilter. This was ca
Author: markt
Date: Mon Nov 30 16:25:19 2015
New Revision: 1717290
URL: http://svn.apache.org/viewvc?rev=1717290&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58655
Fix an IllegalStateException when calling HttpServletResponse.sendRedirect()
with the RemoteIpFilter. This was ca
Author: markt
Date: Mon Nov 30 16:03:03 2015
New Revision: 1717289
URL: http://svn.apache.org/viewvc?rev=1717289&view=rev
Log:
Update changelog
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
Propchange: tomcat/tc7.0.x/trunk/
Author: markt
Date: Mon Nov 30 16:01:51 2015
New Revision: 1717288
URL: http://svn.apache.org/viewvc?rev=1717288&view=rev
Log: (empty)
Modified:
tomcat/tc8.0.x/trunk/ (props changed)
tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml
Propchange: tomcat/tc8.0.x/trunk/
-
Author: markt
Date: Mon Nov 30 16:01:05 2015
New Revision: 1717286
URL: http://svn.apache.org/viewvc?rev=1717286&view=rev
Log:
Update changelog
Modified:
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/
Author: markt
Date: Mon Nov 30 15:57:08 2015
New Revision: 1717284
URL: http://svn.apache.org/viewvc?rev=1717284&view=rev
Log:
Fix test broken by test refactoring in r1717278
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/test/org/apache/catalina/realm/TestRealmBas
https://bz.apache.org/bugzilla/show_bug.cgi?id=58626
--- Comment #9 from Christopher Schultz ---
Michael, can you provide a reference that says that HP-UX sends a SIGHUP to
processes after init runs? I found a thread on unix.stackexchange that seemed
related, but someone commented that sending SI
Author: markt
Date: Mon Nov 30 15:54:46 2015
New Revision: 1717283
URL: http://svn.apache.org/viewvc?rev=1717283&view=rev
Log:
Fix test broken by test refactoring in r1717257
Modified:
tomcat/tc8.0.x/trunk/ (props changed)
tomcat/tc8.0.x/trunk/test/org/apache/catalina/realm/TestRealmBas
Author: markt
Date: Mon Nov 30 15:52:57 2015
New Revision: 1717282
URL: http://svn.apache.org/viewvc?rev=1717282&view=rev
Log:
Fix test broken by test refactoring in r1717252
Modified:
tomcat/trunk/test/org/apache/catalina/realm/TestRealmBase.java
Modified: tomcat/trunk/test/org/apache/catal
Felix,
On 11/24/15 3:47 PM, Felix Schumacher wrote:
> Am 23.11.2015 um 03:19 schrieb Huxing Zhang:
>> Hi fschumacher,
>>
>> Just a friendly reminder that I had a discussion with kkolinko about
>> this before.
>> I seems that it is better to explicitly define the default value
>> rather than the Bo
https://bz.apache.org/bugzilla/show_bug.cgi?id=56917
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bz.apache.org/bugzilla/show_bug.cgi?id=58657
Jonathan changed:
What|Removed |Added
Status|NEEDINFO|NEW
--
You are receiving this mail because
Author: markt
Date: Mon Nov 30 15:35:05 2015
New Revision: 1717278
URL: http://svn.apache.org/viewvc?rev=1717278&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=56917
Allow relative URIs to be used with sendRedirect()
Added:
tomcat/tc7.0.x/trunk/test/org/apache/tomcat/unittes
Author: markt
Date: Mon Nov 30 15:21:13 2015
New Revision: 1717274
URL: http://svn.apache.org/viewvc?rev=1717274&view=rev
Log:
Back-port some refactoring that simplifies the code and is required for some
unit tests planned for back-porting.
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/cata
The Buildbot has detected a new failure on builder tomcat-8-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-8-trunk/builds/310
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchSch
Author: violetagg
Date: Mon Nov 30 14:58:40 2015
New Revision: 1717268
URL: http://svn.apache.org/viewvc?rev=1717268&view=rev
Log:
Merged revision 1717264 from tomcat/trunk:
Fixed potential NPE in HostConfig while deploying an application. Issue
reported by coverity scan.
Modified:
tomcat/tc
Author: violetagg
Date: Mon Nov 30 14:55:58 2015
New Revision: 1717267
URL: http://svn.apache.org/viewvc?rev=1717267&view=rev
Log:
Merged revision 1717264 from tomcat/trunk:
Fixed potential NPE in HostConfig while deploying an application. Issue
reported by coverity scan.
Modified:
tomcat/tc
Author: violetagg
Date: Mon Nov 30 14:50:00 2015
New Revision: 1717264
URL: http://svn.apache.org/viewvc?rev=1717264&view=rev
Log:
Fixed potential NPE in HostConfig while deploying an application. Issue
reported by coverity scan.
Modified:
tomcat/trunk/java/org/apache/catalina/startup/HostCo
https://bz.apache.org/bugzilla/show_bug.cgi?id=56917
--- Comment #5 from Remy Maucherat ---
Similar to 58660, I think the behavior change may not be such a good idea. It
could be done in 9, but not elsewhere by default.
--
You are receiving this mail because:
You are the assignee for the bug.
The Buildbot has detected a new failure on builder tomcat-7-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-7-trunk/builds/206
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchSch
Author: markt
Date: Mon Nov 30 14:03:23 2015
New Revision: 1717255
URL: http://svn.apache.org/viewvc?rev=1717255&view=rev
Log:
Move the TesterServletContext since it is used by multiple tests
Added:
tomcat/tc8.0.x/trunk/test/org/apache/tomcat/unittest/TesterServletContext.java
- copied
Author: markt
Date: Mon Nov 30 14:21:15 2015
New Revision: 1717259
URL: http://svn.apache.org/viewvc?rev=1717259&view=rev
Log:
Move the TesterServletContext since it is used by multiple tests
Added:
tomcat/tc7.0.x/trunk/test/org/apache/tomcat/unittest/TesterServletContext.java
- copied
Author: markt
Date: Mon Nov 30 14:04:37 2015
New Revision: 1717256
URL: http://svn.apache.org/viewvc?rev=1717256&view=rev
Log:
Remove a TODO marker for something long since completed
Modified:
tomcat/tc8.0.x/trunk/ (props changed)
tomcat/tc8.0.x/trunk/java/org/apache/catalina/connector/
Author: markt
Date: Mon Nov 30 14:02:12 2015
New Revision: 1717252
URL: http://svn.apache.org/viewvc?rev=1717252&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=56917
All relative URIs to be used with sendRedirect()
Added:
tomcat/trunk/test/org/apache/tomcat/unittest/TesterCo
The Buildbot has detected a new failure on builder tomcat-trunk while building
ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/701
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranchSchedul
Author: markt
Date: Mon Nov 30 14:06:54 2015
New Revision: 1717257
URL: http://svn.apache.org/viewvc?rev=1717257&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=56917
All relative URIs to be used with sendRedirect()
Added:
tomcat/tc8.0.x/trunk/test/org/apache/tomcat/unittest/
Author: markt
Date: Mon Nov 30 12:04:45 2015
New Revision: 1717233
URL: http://svn.apache.org/viewvc?rev=1717233&view=rev
Log:
Remove a TODO marker for something long since completed
Modified:
tomcat/trunk/java/org/apache/catalina/connector/Response.java
Modified: tomcat/trunk/java/org/apach
https://bz.apache.org/bugzilla/show_bug.cgi?id=58657
--- Comment #6 from Jonathan ---
Created attachment 33312
--> https://bz.apache.org/bugzilla/attachment.cgi?id=33312&action=edit
Maven project of demo
--
You are receiving this mail because:
You are the assignee for the bug.
--
https://bz.apache.org/bugzilla/show_bug.cgi?id=58657
--- Comment #5 from Jonathan ---
Hi Mark,
Sorry about that. I've attached a zip there of the project. Its a maven project
and can be assembled with the usual mvn clean install to get the WAR
--
You are receiving this mail because:
You are th
Author: markt
Date: Mon Nov 30 10:54:14 2015
New Revision: 1717225
URL: http://svn.apache.org/viewvc?rev=1717225&view=rev
Log:
Move the TesterServletContext since it is used by multiple tests
Added:
tomcat/trunk/test/org/apache/tomcat/unittest/TesterServletContext.java
- copied, changed
The Buildbot has detected a restored build on builder tomcat-7-trunk while
building ASF Buildbot. Full details are available at:
http://ci.apache.org/builders/tomcat-7-trunk/builds/204
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: silvanus_ubuntu
Build Reason: The AnyBranch
https://bz.apache.org/bugzilla/show_bug.cgi?id=58646
--- Comment #8 from Mark Thomas ---
(In reply to Alexander Malyshev from comment #6)
> I don't think it's application bug.
All the evidence so far points to an application bug being more likely than a
Tomcat bug.
> The only custom part here a
https://bz.apache.org/bugzilla/show_bug.cgi?id=58657
Mark Thomas changed:
What|Removed |Added
Status|NEW |NEEDINFO
--
You are receiving this mail
https://bz.apache.org/bugzilla/show_bug.cgi?id=58660
Mark Thomas changed:
What|Removed |Added
Resolution|--- |FIXED
Status|REOPENED
Author: markt
Date: Mon Nov 30 09:35:53 2015
New Revision: 1717217
URL: http://svn.apache.org/viewvc?rev=1717217&view=rev
Log:
Correct changelog
Modified:
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/vie
Author: markt
Date: Mon Nov 30 09:35:25 2015
New Revision: 1717216
URL: http://svn.apache.org/viewvc?rev=1717216&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58660
With mapperContextRootRedirectEnabled ste to false, the redirect needs to be
handled elsewhere.
- Ensure the Mapp
Author: markt
Date: Mon Nov 30 09:31:59 2015
New Revision: 1717215
URL: http://svn.apache.org/viewvc?rev=1717215&view=rev
Log:
Refactoring prior to fixing https://bz.apache.org/bugzilla/show_bug.cgi?id=58660
No functional change
Modified:
tomcat/tc6.0.x/trunk/ (props changed)
tomcat/tc6
Author: markt
Date: Mon Nov 30 09:27:41 2015
New Revision: 1717212
URL: http://svn.apache.org/viewvc?rev=1717212&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58660
With mapperContextRootRedirectEnabled ste to false, the redirect needs to be
handled elsewhere.
- Ensure the Mapp
Author: markt
Date: Mon Nov 30 09:12:07 2015
New Revision: 1717210
URL: http://svn.apache.org/viewvc?rev=1717210&view=rev
Log:
Refactoring prior to fixing https://bz.apache.org/bugzilla/show_bug.cgi?id=58660
No functional change
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7
Author: markt
Date: Mon Nov 30 09:11:20 2015
New Revision: 1717209
URL: http://svn.apache.org/viewvc?rev=1717209&view=rev
Log:
Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=58660
With mapperContextRootRedirectEnabled ste to false, the redirect needs to be
handled elsewhere.
- Ensure the Mapp
Author: markt
Date: Mon Nov 30 09:04:11 2015
New Revision: 1717208
URL: http://svn.apache.org/viewvc?rev=1717208&view=rev
Log:
Refactoring prior to fixing https://bz.apache.org/bugzilla/show_bug.cgi?id=58660
No functional change
Modified:
tomcat/tc8.0.x/trunk/ (props changed)
tomcat/tc8
73 matches
Mail list logo
