Author: violetagg
Date: Sat Sep 13 05:47:11 2014
New Revision: 1624699
URL: http://svn.apache.org/r1624699
Log:
Merged revision 1604768 from tomcat/trunk:
Starting to look at WebSocket compression. These implementations will be
required to process the extension negotiation.
Added:
tomcat/tc7
Author: violetagg
Date: Sat Sep 13 05:39:19 2014
New Revision: 1624698
URL: http://svn.apache.org/r1624698
Log:
Merged revision 1597652 from tomcat/trunk:
ISE is expected when using AsyncChannels. Handle it the same way an IOException
is handled rather than expecting the client code to catch and
https://issues.apache.org/bugzilla/show_bug.cgi?id=56446
--- Comment #2 from Violeta Georgieva ---
The fix was back-ported to 7.0.x for 7.0.56 onwards.
--
You are receiving this mail because:
You are the assignee for the bug.
Author: violetagg
Date: Sat Sep 13 05:24:57 2014
New Revision: 1624697
URL: http://svn.apache.org/r1624697
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56446
Merged revision 1595898 from tomcat/trunk:
Clearer handling of exceptions when calling a method on a POJO based WebSocket
en
Author: violetagg
Date: Sat Sep 13 04:36:06 2014
New Revision: 1624696
URL: http://svn.apache.org/r1624696
Log:
Merged revision 1589523 from tomcat/trunk:
Add session ID to the exception message to aid debugging.
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java
The Buildbot has detected a restored build on builder tomcat-trunk while
building ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/457
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: bb-vm_ubuntu
Build Reason: scheduler
Build Source
The Buildbot has detected a new failure on builder tomcat-trunk while building
ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/456
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: bb-vm_ubuntu
Build Reason: scheduler
Build Source Sta
Author: kkolinko
Date: Fri Sep 12 23:33:31 2014
New Revision: 1624683
URL: http://svn.apache.org/r1624683
Log:
Drop AnnotationDefault attribute as unused.
This class has no getter methods and thus provides no value.
It is merge of r1624583 from tomcat/trunk.
Removed:
tomcat/tc7.0.x/trunk/ja
Author: kkolinko
Date: Fri Sep 12 23:28:22 2014
New Revision: 1624680
URL: http://svn.apache.org/r1624680
Log:
Implement a TODO: change return value of AnnotationEntry.getElementValuePairs()
from an array to a list.
As all usages are known and constructor of ElementValuePair class is not
accessi
Author: kkolinko
Date: Fri Sep 12 23:26:10 2014
New Revision: 1624679
URL: http://svn.apache.org/r1624679
Log:
Followup to r1624573
Correct duplicate getter call typo
Modified:
tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java
Modified: tomcat/trunk/java/org/apache/catalina/st
Author: kkolinko
Date: Fri Sep 12 23:12:36 2014
New Revision: 1624676
URL: http://svn.apache.org/r1624676
Log:
Reduce visibility of constructors.
Remove unused constants
It is merge of r1624568, r1624571 from tomcat/trunk.
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/
Author: kkolinko
Date: Fri Sep 12 23:07:49 2014
New Revision: 1624674
URL: http://svn.apache.org/r1624674
Log:
Remove unused ConstantPool.constantToString methods.
Found thanks to Cobertura coverage report.
It is merge of r1624569 from tomcat/trunk.
Modified:
tomcat/tc7.0.x/trunk/ (props c
Author: kkolinko
Date: Fri Sep 12 23:02:25 2014
New Revision: 1624672
URL: http://svn.apache.org/r1624672
Log:
Remove length and constant_pool fields from Attribute class.
It is merge of r1624565 from tomcat/trunk.
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/ja
Author: kkolinko
Date: Fri Sep 12 22:57:54 2014
New Revision: 1624670
URL: http://svn.apache.org/r1624670
Log:
Remove unused method Attribute.getName(). It allows to remove name_index field
as well.
Found thanks to Cobertura coverage report.
It is merge of r1624564 from tomcat/trunk.
Modified:
Author: kkolinko
Date: Fri Sep 12 22:49:16 2014
New Revision: 1624667
URL: http://svn.apache.org/r1624667
Log:
Remove serialization support and serialVersionUID fields from BCEL classes.
It is merge of r1624563 from tomcat/trunk.
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/t
Author: kkolinko
Date: Fri Sep 12 22:42:07 2014
New Revision: 1624665
URL: http://svn.apache.org/r1624665
Log:
Memory efficiency: Use a shared emptySet() as the value for
JavaClassCacheEntry.sciSet when there are no SCIs for a class.
It is merge of r1624655 from tomcat/trunk.
Modified:
tomc
Author: kkolinko
Date: Fri Sep 12 22:34:40 2014
New Revision: 1624664
URL: http://svn.apache.org/r1624664
Log:
Reorganize branches for better performance.
The "docBase.toLowerCase(Locale.ENGLISH).endsWith(".war") &&
!file.isDirectory()" condition was the same in both branches.
It is merge of r16
https://issues.apache.org/bugzilla/show_bug.cgi?id=56938
--- Comment #2 from Austin Jones ---
(In reply to Mark Thomas from comment #1)
> Fixed in 8.0.x for 8.0.13 onwards and in 7.0.x for 7.0.56 onwards.
Thank you, Mark!
--
You are receiving this mail because:
You are the assignee for the bug
Author: kkolinko
Date: Fri Sep 12 21:56:47 2014
New Revision: 1624657
URL: http://svn.apache.org/r1624657
Log:
Reorganize branches for better performance.
The "docBase.toLowerCase(Locale.ENGLISH).endsWith(".war") &&
!file.isDirectory()" condition was the same in both branches.
Modified:
tomc
Author: kkolinko
Date: Fri Sep 12 21:46:59 2014
New Revision: 1624655
URL: http://svn.apache.org/r1624655
Log:
Memory efficiency: Use a shared emptySet() as the value for
JavaClassCacheEntry.sciSet when there are no SCIs for a class.
Modified:
tomcat/trunk/java/org/apache/catalina/startup/Co
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #8 from Pierre Viret ---
I have implemented an EXPERIMENTAL set of maven projects for the tomcat
components.
The main idea is that the sources are simply copied from the central repository
to an existing maven projects' tree. Ev
Author: kkolinko
Date: Fri Sep 12 21:07:30 2014
New Revision: 1624648
URL: http://svn.apache.org/r1624648
Log:
Remove branch that is not used by Tomcat. Thanks to Cobertura coverage report.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ClassParser.java
Modified:
tomcat/t
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #7 from Pierre Viret ---
Created attachment 32017
--> https://issues.apache.org/bugzilla/attachment.cgi?id=32017&action=edit
README for setting up maven for tomcat
This file contains a small how-to explaining the steps needed
Author: kkolinko
Date: Fri Sep 12 21:04:36 2014
New Revision: 1624647
URL: http://svn.apache.org/r1624647
Log:
Remove class_name argument from constructor, as Tomcat does not provide the
name.
Modified:
tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java
tomcat/trunk/java/or
https://issues.apache.org/bugzilla/show_bug.cgi?id=56397
--- Comment #6 from Pierre Viret ---
Created attachment 32016
--> https://issues.apache.org/bugzilla/attachment.cgi?id=32016&action=edit
tar containing the maven pom.xml files and the directories
See README-MAVEN.txt file for usage
--
Author: kkolinko
Date: Fri Sep 12 20:54:57 2014
New Revision: 1624645
URL: http://svn.apache.org/r1624645
Log:
Inline ConstantPool.getConstantString() method.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ConstantPool.java
tomcat/trunk/java/org/apache/tomcat/util/bcel/
Author: kkolinko
Date: Fri Sep 12 20:50:17 2014
New Revision: 1624642
URL: http://svn.apache.org/r1624642
Log:
Move int -> String mapping for class and interface names from JavaClass to
ClassParser.
This avoids an intermediary int[] array.
Move commons classname lookup and compact code into a hel
Author: kkolinko
Date: Fri Sep 12 20:29:08 2014
New Revision: 1624636
URL: http://svn.apache.org/r1624636
Log:
Do not create an empty arrays when Class has no interfaces.
Skip creation of int[] indexes array and share the same empty String[] names
array.
Modified:
tomcat/trunk/java/org/apach
The Buildbot has detected a restored build on builder tomcat-trunk while
building ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/454
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: bb-vm_ubuntu
Build Reason: scheduler
Build Source
https://issues.apache.org/bugzilla/show_bug.cgi?id=56871
--- Comment #2 from Ciaran ---
On my system the test exercised (and continues to) the fault reliably within a
couple of minutes. However I've since been unable to replicate the failure on
clean virtual machines.
I'm happy to chalk it up t
https://issues.apache.org/bugzilla/show_bug.cgi?id=56871
--- Comment #1 from Mark Thomas ---
I'm starting to look at this now. How reliably does this script reproduce the
issue. To put it another way, how long / how many requests before you start
seeing errors?
--
You are receiving this mail be
Author: kkolinko
Date: Fri Sep 12 19:18:22 2014
New Revision: 1624618
URL: http://svn.apache.org/r1624618
Log:
Performance improvement: skip processing early when there are no annotations on
the class.
Modified:
tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java
Modified: tomc
Author: kkolinko
Date: Fri Sep 12 18:57:28 2014
New Revision: 1624614
URL: http://svn.apache.org/r1624614
Log:
Get rid of ArrayList arithmetics in JavaClass.getAnnotationEntries()
Note that this changes return value of getAnnotationEntries() to be null
instead of zero-length array by default.
Th
Author: kkolinko
Date: Fri Sep 12 18:38:03 2014
New Revision: 1624605
URL: http://svn.apache.org/r1624605
Log:
Flatten class hierarchy. The only subtype of Annotations class is
RuntimeVisibleAnnotations.
Removed:
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/RuntimeVisibleAnnotat
Author: kkolinko
Date: Fri Sep 12 17:50:20 2014
New Revision: 1624598
URL: http://svn.apache.org/r1624598
Log:
Remove RuntimeVisibleParameterAnnotations and its supporting classes.
The fields in these classes have no getters (especially
ParameterAnnotationEntry.annotation_table).
As such, informa
On 12/09/2014 18:26, Konstantin Kolinko wrote:
> Hi!
>
> Looking at ParameterAnnotationEntry class, its "annotation_table"
> field is never read.
>
> As such, that class provides no information
> and the following 3 classes can be removed:
> * ParameterAnnotationEntry
> * ParameterAnnotations
> *
Hi!
Looking at ParameterAnnotationEntry class, its "annotation_table"
field is never read.
As such, that class provides no information
and the following 3 classes can be removed:
* ParameterAnnotationEntry
* ParameterAnnotations
* RuntimeVisibleParameterAnnotations
>From documentation, "RuntimeV
Author: kkolinko
Date: Fri Sep 12 17:15:31 2014
New Revision: 1624594
URL: http://svn.apache.org/r1624594
Log:
Move stream reading logic into AnnotationEntry and ElementValue constructors.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/AnnotationEntry.java
tomcat/trunk/
2014-09-12 21:06 GMT+04:00 Mark Thomas :
> On 12/09/2014 17:57, kkoli...@apache.org wrote:
>> Author: kkolinko
>> Date: Fri Sep 12 16:57:06 2014
>> New Revision: 1624592
>>
>> URL: http://svn.apache.org/r1624592
>> Log:
>> Add 'final' modifiers to fields.
>
> No objection, just some commentary.
>
>
On 12/09/2014 17:57, kkoli...@apache.org wrote:
> Author: kkolinko
> Date: Fri Sep 12 16:57:06 2014
> New Revision: 1624592
>
> URL: http://svn.apache.org/r1624592
> Log:
> Add 'final' modifiers to fields.
No objection, just some commentary.
I've avoided this sort of change in the past to keep t
Author: kkolinko
Date: Fri Sep 12 16:57:06 2014
New Revision: 1624592
URL: http://svn.apache.org/r1624592
Log:
Add 'final' modifiers to fields.
Remove several num_xxx fields that accompanied an xxx array.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/AnnotationElementValu
Author: kkolinko
Date: Fri Sep 12 16:37:48 2014
New Revision: 1624588
URL: http://svn.apache.org/r1624588
Log:
Remove constant_pool_count field.
The field is never read, and its value is known from the length of
constant_pool array created in constructor.
Modified:
tomcat/trunk/java/org/apac
Author: kkolinko
Date: Fri Sep 12 16:26:44 2014
New Revision: 1624586
URL: http://svn.apache.org/r1624586
Log:
Simplify.
There is no real need to convert every attribute name into numeric tag via
lookup table, when there are only two attribute names that we recognize.
In the old code there was a
Author: kkolinko
Date: Fri Sep 12 16:16:15 2014
New Revision: 1624583
URL: http://svn.apache.org/r1624583
Log:
Drop AnnotationDefault attribute as unused.
Evidences:
1) Its constructor just swallowed an ElementValue without keeping it.
As such, this class has no getter methods and thus provides n
https://issues.apache.org/bugzilla/show_bug.cgi?id=56952
--- Comment #1 from Mark Thomas ---
I'm not overly keen on adding an additional JAR to the distrbution to address
this.
Does Jetty not have a configuration option to skip the processing of selected
container provided SCIs? Alternatively co
https://issues.apache.org/bugzilla/show_bug.cgi?id=56938
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
Author: markt
Date: Fri Sep 12 16:10:12 2014
New Revision: 1624581
URL: http://svn.apache.org/r1624581
Log:
Ensure web applications that have mixed case context paths and are deployed as
directories are correctly removed on undeploy when running on a case sensitive
file system.
Modified:
to
Author: markt
Date: Fri Sep 12 16:08:27 2014
New Revision: 1624580
URL: http://svn.apache.org/r1624580
Log:
Ensure web applications that have mixed case context paths and are deployed as
directories are correctly removed on undeploy when running on a case sensitive
file system.
Modified:
to
Author: markt
Date: Fri Sep 12 15:54:59 2014
New Revision: 1624576
URL: http://svn.apache.org/r1624576
Log:
Update changelog
Modified:
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/t
Author: markt
Date: Fri Sep 12 15:54:27 2014
New Revision: 1624574
URL: http://svn.apache.org/r1624574
Log:
Update changelog
Modified:
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/change
Author: kkolinko
Date: Fri Sep 12 15:41:33 2014
New Revision: 1624573
URL: http://svn.apache.org/r1624573
Log:
Implement a TODO: change return value of AnnotationEntry.getElementValuePairs()
from an array to a list.
As all usages are known and constructor of ElementValuePair class is not
accessi
Author: markt
Date: Fri Sep 12 15:25:34 2014
New Revision: 1624571
URL: http://svn.apache.org/r1624571
Log:
Remove unused constants
Modified:
tomcat/trunk/java/org/apache/tomcat/util/bcel/Constants.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/Constants.java
URL:
http://svn.a
Author: kkolinko
Date: Fri Sep 12 15:22:40 2014
New Revision: 1624569
URL: http://svn.apache.org/r1624569
Log:
Remove unused ConstantPool.constantToString methods.
Found thanks to Cobertura coverage report.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/ConstantPool.java
M
Author: kkolinko
Date: Fri Sep 12 15:15:41 2014
New Revision: 1624568
URL: http://svn.apache.org/r1624568
Log:
Reduce visibility of constructors.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/AccessFlags.java
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Ann
Author: kkolinko
Date: Fri Sep 12 15:09:41 2014
New Revision: 1624565
URL: http://svn.apache.org/r1624565
Log:
Remove length and constant_pool fields from Attribute class.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/AnnotationDefault.java
tomcat/trunk/java/org/apach
Author: kkolinko
Date: Fri Sep 12 15:02:00 2014
New Revision: 1624564
URL: http://svn.apache.org/r1624564
Log:
Remove unused method Attribute.getName(). It allows to remove name_index field
as well.
Found thanks to Cobertura coverage report.
Modified:
tomcat/trunk/java/org/apache/tomcat/uti
Author: kkolinko
Date: Fri Sep 12 14:50:19 2014
New Revision: 1624563
URL: http://svn.apache.org/r1624563
Log:
Remove serialization support and serialVersionUID fields from BCEL classes.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/AccessFlags.java
tomcat/trunk/java/
The Buildbot has detected a new failure on builder tomcat-trunk while building
ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/tomcat-trunk/builds/452
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: bb-vm_ubuntu
Build Reason: scheduler
Build Source Sta
Author: kkolinko
Date: Fri Sep 12 14:07:53 2014
New Revision: 1624552
URL: http://svn.apache.org/r1624552
Log:
Use ClassFormatException in ElementValue.readElementValue() as this behaviour
is driven by user-provided data,
instead of logic errors in the code (as is the case for remaining
RuntimeE
https://issues.apache.org/bugzilla/show_bug.cgi?id=56953
--- Comment #7 from Mark Thomas ---
With the various other changes and improvements back-ported to 7.0.x, I'm
prepared to consider this idea if the benefit justifies it. That said, we need
a patch that implements this idea - and just this i
https://issues.apache.org/bugzilla/show_bug.cgi?id=56940
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://issues.apache.org/bugzilla/show_bug.cgi?id=56955
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
Author: markt
Date: Fri Sep 12 13:24:16 2014
New Revision: 1624543
URL: http://svn.apache.org/r1624543
Log:
Add performance test
Added:
tomcat/tc7.0.x/trunk/test/org/apache/tomcat/util/bcel/
tomcat/tc7.0.x/trunk/test/org/apache/tomcat/util/bcel/TesterPerformance.java
(with props)
Add
Author: kkolinko
Date: Fri Sep 12 13:23:42 2014
New Revision: 1624542
URL: http://svn.apache.org/r1624542
Log:
Use ClassFormatException in ElementValue.readElementValue() as this behaviour
is driven by user-provided data,
instead of logic errors in the code (as is the case for remaining
RuntimeE
Author: markt
Date: Fri Sep 12 13:21:12 2014
New Revision: 1624541
URL: http://svn.apache.org/r1624541
Log:
Clean up merge errors and align code wth trunk
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/bcel/Constants.java
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/bcel/
Author: markt
Date: Fri Sep 12 13:12:21 2014
New Revision: 1624535
URL: http://svn.apache.org/r1624535
Log:
Port more code removal from trunk
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/bcel/ (props changed)
tomcat/tc7.0.x/trun
Author: markt
Date: Fri Sep 12 13:09:13 2014
New Revision: 1624534
URL: http://svn.apache.org/r1624534
Log:
Port more code removal from trunk
Removed:
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/bcel/classfile/FieldOrMethod.java
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/bcel
Author: markt
Date: Fri Sep 12 13:01:37 2014
New Revision: 1624533
URL: http://svn.apache.org/r1624533
Log:
Port removal of unnecesary code from trunk
Removed:
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/bcel/classfile/ConstantCP.java
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/uti
On 12/09/2014 13:04, Violeta Georgieva wrote:
> Hi,
>
> 2014-08-22 14:02 GMT+03:00 :
>>
>> Author: markt
>> Date: Fri Aug 22 11:02:19 2014
>> New Revision: 1619738
>>
>> URL: http://svn.apache.org/r1619738
>> Log:
>> Extend support for the WebSocket permessage-deflate extension to
> compression of
Author: markt
Date: Fri Sep 12 12:54:11 2014
New Revision: 1624529
URL: http://svn.apache.org/r1624529
Log:
Port removal of unused code from trunk
Removed:
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/bcel/classfile/Code.java
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/bcel/clas
Author: markt
Date: Fri Sep 12 12:48:21 2014
New Revision: 1624527
URL: http://svn.apache.org/r1624527
Log:
Merge more simplification from trunk
Removed:
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/bcel/classfile/Synthetic.java
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
t
Author: markt
Date: Fri Sep 12 12:46:55 2014
New Revision: 1624526
URL: http://svn.apache.org/r1624526
Log:
Merge more simplification from trunk
Removed:
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/bcel/classfile/Signature.java
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/bcel/
Author: markt
Date: Fri Sep 12 12:42:21 2014
New Revision: 1624523
URL: http://svn.apache.org/r1624523
Log:
Port more simplifications from trunk
Removed:
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/bcel/classfile/StackMapEntry.java
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/b
Author: markt
Date: Fri Sep 12 12:35:49 2014
New Revision: 1624521
URL: http://svn.apache.org/r1624521
Log:
Port simplications from trunk
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/bcel/ (props changed)
tomcat/tc7.0.x/trunk/ja
Author: markt
Date: Fri Sep 12 12:31:01 2014
New Revision: 1624520
URL: http://svn.apache.org/r1624520
Log:
Merge more unused code removal from trunk
Removed:
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/bcel/classfile/AttributeReader.java
tomcat/tc7.0.x/trunk/java/org/apache/tomcat
Author: markt
Date: Fri Sep 12 12:16:03 2014
New Revision: 1624514
URL: http://svn.apache.org/r1624514
Log:
Backport of unused code removal from trunk
Removed:
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/bcel/classfile/Field.java
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/bcel/
Author: markt
Date: Fri Sep 12 12:10:50 2014
New Revision: 1624511
URL: http://svn.apache.org/r1624511
Log:
Backport fix for stack overflow error from trunk
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/bcel/ (props changed)
tomc
Author: markt
Date: Fri Sep 12 12:09:34 2014
New Revision: 1624510
URL: http://svn.apache.org/r1624510
Log:
Back-port of more cleanup from trunk
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/bcel/ (props changed)
tomcat/tc7.0.x/tr
Author: markt
Date: Fri Sep 12 12:05:52 2014
New Revision: 1624509
URL: http://svn.apache.org/r1624509
Log:
Merge restoration of necessary code from trunk
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/bcel/ (props changed)
tomcat/
Hi,
2014-08-22 14:02 GMT+03:00 :
>
> Author: markt
> Date: Fri Aug 22 11:02:19 2014
> New Revision: 1619738
>
> URL: http://svn.apache.org/r1619738
> Log:
> Extend support for the WebSocket permessage-deflate extension to
compression of outgoing messages on the server side.
I would like to back-p
Author: markt
Date: Fri Sep 12 12:00:17 2014
New Revision: 1624508
URL: http://svn.apache.org/r1624508
Log:
Merge addition of comments from trunk
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/bcel/ (props changed)
tomcat/tc7.0.x/
Author: markt
Date: Fri Sep 12 11:59:12 2014
New Revision: 1624506
URL: http://svn.apache.org/r1624506
Log:
Merge removal of unused code from trunk
Removed:
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/bcel/util/ByteSequence.java
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
t
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/bcel/classfile/Utility.java
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/bcel/classfile/Utility.java?rev=1624506&r1=1624505&r2=1624506&view=diff
===
Author: markt
Date: Fri Sep 12 11:51:40 2014
New Revision: 1624503
URL: http://svn.apache.org/r1624503
Log:
Port removal of unused code from trunk
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/bcel/ (props changed)
tomcat/tc7.0.x
Author: markt
Date: Fri Sep 12 11:45:31 2014
New Revision: 1624502
URL: http://svn.apache.org/r1624502
Log:
BCEL changes that were then reverted
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
Propchange: tomcat/tc7.0.x/trunk/
---
https://issues.apache.org/bugzilla/show_bug.cgi?id=56970
--- Comment #1 from Konstantin Kolinko ---
> http://tomcat.apache.org/migration-8.html#Database_Connection_Pooling
> Documents: The maxActive configuration option has been renamed to maxTotal
The above documentation talks about DBCP pool.
2014-09-11 22:34 GMT+04:00 Mark Thomas :
> On 11/09/2014 15:24, Romain Manni-Bucau wrote:
>> Hi guys
>>
>> on tomee jira we got an issue from a user migrating from tomcat 6 to
>> tomee (tomcat 7)
>>
>> his authenticator was not called anymore
>>
>> seems it was due to the change in:
>>
>> boolean a
Author: markt
Date: Fri Sep 12 11:28:01 2014
New Revision: 1624500
URL: http://svn.apache.org/r1624500
Log:
Merge cosmetic changes from trunk. No functional change.
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/bcel/ (props changed)
Author: kkolinko
Date: Fri Sep 12 11:15:44 2014
New Revision: 1624498
URL: http://svn.apache.org/r1624498
Log:
Simplify Constant.readConstant()
and remove swallow methods that are no longer used from Utility class.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Constant.jav
On 12/09/2014 11:11, dalibor topic wrote:
> On 11.09.2014 20:50, Mark Thomas wrote:
>>
>> The protection against JRE triggered memory leaks is a source of a lot
>> of internal API usage:
>> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/JreMemoryLeakPreventionListener.java?
Author: kkolinko
Date: Fri Sep 12 11:05:52 2014
New Revision: 1624497
URL: http://svn.apache.org/r1624497
Log:
Simplify Attribute.readAttribute()
and remove a lot of swallow methods that are no longer used from Utility class.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/A
https://issues.apache.org/bugzilla/show_bug.cgi?id=56953
--- Comment #6 from Konstantin Kolinko ---
The point of java.io.BufferedInputStream() is that is.read() were fast enough.
I do not see much benefit in re-implementing standard JRE classes.
By the way, is.read() is a blocking method. If you
Author: markt
Date: Fri Sep 12 09:36:57 2014
New Revision: 1624487
URL: http://svn.apache.org/r1624487
Log:
Don't use DataInputStream where we don't have to
Modified:
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Utility.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/bcel/
Author: markt
Date: Fri Sep 12 09:34:25 2014
New Revision: 1624486
URL: http://svn.apache.org/r1624486
Log:
Simplify attribute skipping. Based on an idea by kkolinko.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/bcel/classfile/Attribute.java
tomcat/trunk/java/org/apache/tomcat/util/
2014-09-12 13:20 GMT+04:00 Mark Thomas :
> On 12/09/2014 10:08, Mark Thomas wrote:
>> On 12/09/2014 09:36, Konstantin Kolinko wrote:
>>> Hi!
>>>
>>> Reviewing BCEL method Utility.swallowUnknownAttribute(...), I think
>>> the same approach can be used for all other attributes that we ignore,
>>> ig
Author: markt
Date: Fri Sep 12 09:22:36 2014
New Revision: 1624483
URL: http://svn.apache.org/r1624483
Log:
Focus timing on BCEL parts of code.
Modified:
tomcat/trunk/test/org/apache/tomcat/util/bcel/TesterPerformance.java
Modified: tomcat/trunk/test/org/apache/tomcat/util/bcel/TesterPerform
On 12/09/2014 10:08, Mark Thomas wrote:
> On 12/09/2014 09:36, Konstantin Kolinko wrote:
>> Hi!
>>
>> Reviewing BCEL method Utility.swallowUnknownAttribute(...), I think
>> the same approach can be used for all other attributes that we ignore,
>> ignoring their internal structure.
>>
>> That is: w
On 12/09/2014 09:36, Konstantin Kolinko wrote:
> Hi!
>
> Reviewing BCEL method Utility.swallowUnknownAttribute(...), I think
> the same approach can be used for all other attributes that we ignore,
> ignoring their internal structure.
>
> That is: we know length of their data. In Attribute.readA
https://issues.apache.org/bugzilla/show_bug.cgi?id=56974
Bug ID: 56974
Summary: jdbc-pool validation query defaultAutoCommit status
Product: Tomcat Modules
Version: unspecified
Hardware: PC
OS: Linux
Status: NEW
https://issues.apache.org/bugzilla/show_bug.cgi?id=56955
--- Comment #7 from hzha...@ebay.com ---
Sorry for any inconvenience. I am now reviewing my code.
--
You are receiving this mail because:
You are the assignee for the bug.
--
1 - 100 of 108 matches
Mail list logo
