On 12/09/2014 17:57, kkoli...@apache.org wrote:
> Author: kkolinko
> Date: Fri Sep 12 16:57:06 2014
> New Revision: 1624592
> 
> URL: http://svn.apache.org/r1624592
> Log:
> Add 'final' modifiers to fields.

No objection, just some commentary.

I've avoided this sort of change in the past to keep the code closer to
the original BCEL code to aid keeping the code in sync. I think there
might be some value in this still but the Tomcat code is getting quite a
long way from the BCEL code that manual merges rather than svn merges
may be simpler.

Mark


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to