svn commit: r1577376 - /tomcat/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletOutputStream.java

2014-03-13 Thread remm
Author: remm Date: Thu Mar 13 23:27:12 2014 New Revision: 1577376 URL: http://svn.apache.org/r1577376 Log: With the writeLock in use in the superclass, remove the useless extra locking (after testing). Modified: tomcat/trunk/java/org/apache/coyote/http11/upgrade/Nio2ServletOutputStream.java

Re: svn commit: r1577328 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/descriptor/DigesterFactory.java java/org/apache/tomcat/util/descriptor/LocalStrings.properties webapps/docs/changelo

2014-03-13 Thread Konstantin Kolinko
1. addSelf() is odd, does not match with TC8. Bad merge? 2. Both add() and addSelf() should display a warning. Maybe move "log.warn()" into locationFor(..) method. 3. What is the point of putting null values into the maps. 4. Message: > digesterFactory.missingSchema=The XML schema [{0}] could not b

svn commit: r1577331 - /tomcat/tc6.0.x/trunk/STATUS.txt

2014-03-13 Thread markt
Author: markt Date: Thu Mar 13 21:38:52 2014 New Revision: 1577331 URL: http://svn.apache.org/r1577331 Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1577331&r1=1577330&r

Re: svn commit: r1560931 - in /tomcat/tc7.0.x/trunk: build.xml java/org/apache/tomcat/util/descriptor/DigesterFactory.java

2014-03-13 Thread Mark Thomas
On 13/03/2014 13:41, Violeta Georgieva wrote: > 2014-03-13 15:28 GMT+02:00 Mark Thomas : >> What exactly is it that we want to cover? I can think of a number of >> requirements. >> >> 1. Ensure that Tomcat still works (excluding validation) if using a >> servlet API implementation that does not

svn commit: r1577328 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/descriptor/DigesterFactory.java java/org/apache/tomcat/util/descriptor/LocalStrings.properties webapps/docs/changelog.xm

2014-03-13 Thread markt
Author: markt Date: Thu Mar 13 21:33:08 2014 New Revision: 1577328 URL: http://svn.apache.org/r1577328 Log: Enable Tomcat to work in a OSGI environment with alternative Servlet and JSP API JARs. Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0.x/trunk/java/org/apache/tomca

svn commit: r1577324 - /tomcat/trunk/java/org/apache/tomcat/util/descriptor/DigesterFactory.java

2014-03-13 Thread markt
Author: markt Date: Thu Mar 13 21:26:40 2014 New Revision: 1577324 URL: http://svn.apache.org/r1577324 Log: Simplify Modified: tomcat/trunk/java/org/apache/tomcat/util/descriptor/DigesterFactory.java Modified: tomcat/trunk/java/org/apache/tomcat/util/descriptor/DigesterFactory.java URL: ht

Re: svn commit: r1560931 - in /tomcat/tc7.0.x/trunk: build.xml java/org/apache/tomcat/util/descriptor/DigesterFactory.java

2014-03-13 Thread Konstantin Kolinko
2014-03-13 16:28 GMT+04:00 Violeta Georgieva : > Hi, > > In OSGi world the functionality is separated in different bundles and > schemes for servlet API is in one bundle and schemes for JSP API in > another. > With that change we pack all schemes in servlet-api.jar. Till this changed > one was able

svn commit: r1577315 - in /tomcat/trunk: java/org/apache/tomcat/util/descriptor/DigesterFactory.java java/org/apache/tomcat/util/descriptor/LocalStrings.properties webapps/docs/changelog.xml

2014-03-13 Thread markt
Author: markt Date: Thu Mar 13 20:57:01 2014 New Revision: 1577315 URL: http://svn.apache.org/r1577315 Log: Enable Tomcat to work in a OSGI environment with alternative Servlet and JSP API JARs. Modified: tomcat/trunk/java/org/apache/tomcat/util/descriptor/DigesterFactory.java tomcat/tru

svn commit: r1577299 - /tomcat/trunk/webapps/docs/changelog.xml

2014-03-13 Thread markt
Author: markt Date: Thu Mar 13 19:46:59 2014 New Revision: 1577299 URL: http://svn.apache.org/r1577299 Log: Whitespace police Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/chang

[GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

2014-03-13 Thread Bill Barker
/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-5.7-SNAPSHOT.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20140313.jar:/srv/g

buildbot success in ASF Buildbot on tomcat-trunk

2014-03-13 Thread buildbot
The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/5589 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

[Bug 56248] Automatic deployment with TCD deletes customized context.xml file

2014-03-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56248 --- Comment #2 from Jesse Barnum --- Wow, thank you!!! -- You are receiving this mail because: You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr..

Re: [Bug 56248] Automatic deployment with TCD deletes customized context.xml file

2014-03-13 Thread sebb
On 13 March 2014 15:30, wrote: > https://issues.apache.org/bugzilla/show_bug.cgi?id=56248 > > Mark Thomas changed: > >What|Removed |Added > > Status|NEW

svn commit: r1577201 - /tomcat/trunk/java/org/apache/catalina/manager/ManagerServlet.java

2014-03-13 Thread markt
Author: markt Date: Thu Mar 13 15:33:14 2014 New Revision: 1577201 URL: http://svn.apache.org/r1577201 Log: Clean-up / consistency Modified: tomcat/trunk/java/org/apache/catalina/manager/ManagerServlet.java Modified: tomcat/trunk/java/org/apache/catalina/manager/ManagerServlet.java URL: htt

[Bug 56248] Automatic deployment with TCD deletes customized context.xml file

2014-03-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56248 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1577199 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/manager/LocalStrings.properties java/org/apache/catalina/manager/ManagerServlet.java java/org/apache/catalina/startup/HostC

2014-03-13 Thread markt
Author: markt Date: Thu Mar 13 15:30:35 2014 New Revision: 1577199 URL: http://svn.apache.org/r1577199 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56248 Allow the deployer to update an existing WAR file without undeploying the existing application if the update flag is set. This al

svn commit: r1577195 - /tomcat/trunk/java/org/apache/catalina/manager/ManagerServlet.java

2014-03-13 Thread markt
Author: markt Date: Thu Mar 13 15:23:31 2014 New Revision: 1577195 URL: http://svn.apache.org/r1577195 Log: Correct some errors in r1577182 Modified: tomcat/trunk/java/org/apache/catalina/manager/ManagerServlet.java Modified: tomcat/trunk/java/org/apache/catalina/manager/ManagerServlet.java

Re: svn commit: r1577182 - in /tomcat/trunk: java/org/apache/catalina/manager/LocalStrings.properties java/org/apache/catalina/manager/ManagerServlet.java java/org/apache/catalina/startup/HostConfig.j

2014-03-13 Thread Mark Thomas
On 13/03/2014 14:48, ma...@apache.org wrote: > Author: markt > Date: Thu Mar 13 14:48:14 2014 > New Revision: 1577182 > > URL: http://svn.apache.org/r1577182 > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56248 > Allow the deployer to update an existing WAR file without > undeploy

svn commit: r1577182 - in /tomcat/trunk: java/org/apache/catalina/manager/LocalStrings.properties java/org/apache/catalina/manager/ManagerServlet.java java/org/apache/catalina/startup/HostConfig.java

2014-03-13 Thread markt
Author: markt Date: Thu Mar 13 14:48:14 2014 New Revision: 1577182 URL: http://svn.apache.org/r1577182 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56248 Allow the deployer to update an existing WAR file without undeploying the existing application if the update flag is set. This al

svn commit: r1577173 - /tomcat/trunk/test/org/apache/tomcat/websocket/TestWebSocketFrameClientSSL.java

2014-03-13 Thread remm
Author: remm Date: Thu Mar 13 14:13:32 2014 New Revision: 1577173 URL: http://svn.apache.org/r1577173 Log: Disable SSL websocket "firehose" test for now on NIO2, since a legitimate explanation for the failure has been found. Modified: tomcat/trunk/test/org/apache/tomcat/websocket/TestWebSoc

Re: svn commit: r1560931 - in /tomcat/tc7.0.x/trunk: build.xml java/org/apache/tomcat/util/descriptor/DigesterFactory.java

2014-03-13 Thread Violeta Georgieva
2014-03-13 15:28 GMT+02:00 Mark Thomas : > > On 13/03/2014 13:09, Violeta Georgieva wrote: > > Hi Mark, > > > > > > 2014-03-13 15:01 GMT+02:00 Mark Thomas : > >> > >> On 13/03/2014 12:28, Violeta Georgieva wrote: > >>> Hi, > >>> > >>> In OSGi world the functionality is separated in different bundle

Re: svn commit: r1560931 - in /tomcat/tc7.0.x/trunk: build.xml java/org/apache/tomcat/util/descriptor/DigesterFactory.java

2014-03-13 Thread Mark Thomas
On 13/03/2014 13:09, Violeta Georgieva wrote: > Hi Mark, > > > 2014-03-13 15:01 GMT+02:00 Mark Thomas : >> >> On 13/03/2014 12:28, Violeta Georgieva wrote: >>> Hi, >>> >>> In OSGi world the functionality is separated in different bundles and >>> schemes for servlet API is in one bundle and scheme

Re: svn commit: r1560931 - in /tomcat/tc7.0.x/trunk: build.xml java/org/apache/tomcat/util/descriptor/DigesterFactory.java

2014-03-13 Thread Violeta Georgieva
Hi Mark, 2014-03-13 15:01 GMT+02:00 Mark Thomas : > > On 13/03/2014 12:28, Violeta Georgieva wrote: > > Hi, > > > > In OSGi world the functionality is separated in different bundles and > > schemes for servlet API is in one bundle and schemes for JSP API in > > another. > > Then I'd argue that th

Re: svn commit: r1560931 - in /tomcat/tc7.0.x/trunk: build.xml java/org/apache/tomcat/util/descriptor/DigesterFactory.java

2014-03-13 Thread Mark Thomas
On 13/03/2014 12:28, Violeta Georgieva wrote: > Hi, > > In OSGi world the functionality is separated in different bundles and > schemes for servlet API is in one bundle and schemes for JSP API in > another. Then I'd argue that those bundles are broken as far as validation goes. You can't validate

Re: svn commit: r1560931 - in /tomcat/tc7.0.x/trunk: build.xml java/org/apache/tomcat/util/descriptor/DigesterFactory.java

2014-03-13 Thread Violeta Georgieva
Hi, In OSGi world the functionality is separated in different bundles and schemes for servlet API is in one bundle and schemes for JSP API in another. With that change we pack all schemes in servlet-api.jar. Till this changed one was able to use whatever servlet api bundle compatible with Tomcat b

[Bug 56253] StringIndexOutOfBoundsException in AbstractArchiveResourceSet.list() method

2014-03-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56253 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1577103 - in /tomcat/trunk: java/org/apache/catalina/webresources/ test/org/apache/catalina/webresources/ webapps/docs/

2014-03-13 Thread markt
Author: markt Date: Thu Mar 13 10:42:49 2014 New Revision: 1577103 URL: http://svn.apache.org/r1577103 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56253 When listing resources that are provided by a JAR, fix possible StringIndexOutOfBoundsExceptions. Add some unit tests for this a

svn commit: r1577087 - /tomcat/trunk/java/org/apache/catalina/core/StandardContext.java

2014-03-13 Thread kkolinko
Author: kkolinko Date: Thu Mar 13 10:23:35 2014 New Revision: 1577087 URL: http://svn.apache.org/r1577087 Log: Reduce calls to getManager(). (That is not a simple getter, but it performs some locking). Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java Modified: tomcat

[Bug 56256] New: Multiple cookies and parallel deployment

2014-03-13 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=56256 Bug ID: 56256 Summary: Multiple cookies and parallel deployment Product: Tomcat 8 Version: 8.0.3 Hardware: All OS: All Status: NEW Severity: minor

svn commit: r1577080 - /tomcat/trunk/test/org/apache/tomcat/websocket/TestWebSocketFrameClientSSL.java

2014-03-13 Thread remm
Author: remm Date: Thu Mar 13 10:00:47 2014 New Revision: 1577080 URL: http://svn.apache.org/r1577080 Log: Set eol prop. Modified: tomcat/trunk/test/org/apache/tomcat/websocket/TestWebSocketFrameClientSSL.java (props changed) Propchange: tomcat/trunk/test/org/apache/tomcat/websocket/Tes

svn commit: r1577077 - /tomcat/trunk/test/org/apache/tomcat/websocket/TestWebSocketFrameClient.java

2014-03-13 Thread markt
Author: markt Date: Thu Mar 13 09:51:03 2014 New Revision: 1577077 URL: http://svn.apache.org/r1577077 Log: Remove unused imports Modified: tomcat/trunk/test/org/apache/tomcat/websocket/TestWebSocketFrameClient.java Modified: tomcat/trunk/test/org/apache/tomcat/websocket/TestWebSocketFrameC

svn commit: r1577073 - in /tomcat/trunk/test/org/apache/tomcat/websocket: TestWebSocketFrameClient.java TestWebSocketFrameClientSSL.java

2014-03-13 Thread remm
Author: remm Date: Thu Mar 13 09:29:30 2014 New Revision: 1577073 URL: http://svn.apache.org/r1577073 Log: The test now uses too much memory for the test server, so split it SSL / non SSL. Added: tomcat/trunk/test/org/apache/tomcat/websocket/TestWebSocketFrameClientSSL.java Modified: to

Re: svn commit: r1576770 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/realm/MemoryRealm.java test/org/apache/catalina/realm/TestMemoryRealm.java webapps/docs/changelog.xml

2014-03-13 Thread Konstantin Kolinko
2014-03-12 18:53 GMT+04:00 : > Author: markt > Date: Wed Mar 12 14:53:29 2014 > New Revision: 1576770 > > URL: http://svn.apache.org/r1576770 > Log: > Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56246 > Fix NullPointerException in MemoryRealm when authenticating an unknown user. > > Add