2014-03-13 15:28 GMT+02:00 Mark Thomas <ma...@apache.org>: > > On 13/03/2014 13:09, Violeta Georgieva wrote: > > Hi Mark, > > > > > > 2014-03-13 15:01 GMT+02:00 Mark Thomas <ma...@apache.org>: > >> > >> On 13/03/2014 12:28, Violeta Georgieva wrote: > >>> Hi, > >>> > >>> In OSGi world the functionality is separated in different bundles and > >>> schemes for servlet API is in one bundle and schemes for JSP API in > >>> another. > >> > >> Then I'd argue that those bundles are broken as far as validation goes. > >> You can't validate a web.xml document without access to the JSP schemas > >> but it should not be necessary to have a dependency on the jsp-api just > >> to validate a web.xml document. > >> > > > > if you have two bundles one with the servlet API and another with JSP API > > then Servlet API bundle can import optionally the resources from JSP API > > bundle. > > That's the way bundles use when need some functionality. When you import it > > optionally you say that you need these resources/functionality but you can > > run also without it. > > Using this way you cover xml validation on and off in this particular > > scenario. > > My point is the the JSP API bundle should not be required at all to > validate a schema from the Servlet API bundle. The Servlet API bundle > should be self-contained. > > >>> With that change we pack all schemes in servlet-api.jar. Till this > > changed > >>> one was able to use whatever servlet api bundle compatible with Tomcat > > but > >>> with that change we enforce people to use only the jar provided by > > Tomcat > >>> which is not a bundle also. > >>> > >>> Is it possible to return back the check with JSPContext? Something like > >>> this? > >> > >> No. That creates a dependency on jsp-api.jar. > > > > :( You are right > > > >> > >> A solution should be possible but it is going to be more complex that > >> the patch proposed here. > > > > What we can do if we want to cover this scenario? > > What exactly is it that we want to cover? I can think of a number of > requirements. > > 1. Ensure that Tomcat still works (excluding validation) if using a > servlet API implementation that does not include the JSP schemas. > > 2. Ensure that Tomcat can still validate web.xml files if using a > Servlet API implementation that does not include JSP schemas along with > a JSP API implementation that does. > > Any more?
No. These two cover the scenario. > Both of the above should be do-able. > > Mark > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org >
