svn commit: r1574785 - in /tomcat/trunk: java/org/apache/jasper/JspC.java java/org/apache/jasper/servlet/JspCServletContext.java test/org/apache/jasper/servlet/TestJspCServletContext.java

Author: markt Date: Thu Mar 6 07:40:12 2014 New Revision: 1574785 URL: http://svn.apache.org/r1574785 Log: Better fix for BZ56199 Fix failing unit tests caused by original fix. Modified: tomcat/trunk/java/org/apache/jasper/JspC.java tomcat/trunk/java/org/apache/jasper/servlet/JspCServlet

[GUMP@vmgump]: Project tomcat-trunk-test (in module tomcat-trunk) failed

To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-trunk-test has an issue affecting its community integration. This i

[Bug 56223] New: ServletContext#setInitParameter(..) does not throw IllegalStateException after it's been initialized

https://issues.apache.org/bugzilla/show_bug.cgi?id=56223 Bug ID: 56223 Summary: ServletContext#setInitParameter(..) does not throw IllegalStateException after it's been initialized Product: Tomcat 8 Version: 8.0.3 Hardware:

Re: buildbot failure in ASF Buildbot on tomcat-trunk

2014-03-06 2:46 GMT+04:00 : > The Buildbot has detected a new failure on builder tomcat-trunk while > building ASF Buildbot. > Full details are available at: > http://ci.apache.org/builders/tomcat-trunk/builds/5558 > > Buildbot URL: http://ci.apache.org/ > > Buildslave for this Build: bb-vm_ubun

[Bug 54315] Redeploying webapp causes NullPointerException in managerBase

https://issues.apache.org/bugzilla/show_bug.cgi?id=54315 Konstantin Kolinko changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|I

buildbot failure in ASF Buildbot on tomcat-trunk

The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/5558 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source St

[Bug 56190] Connection keep-alive not working with asynchronous servlet

https://issues.apache.org/bugzilla/show_bug.cgi?id=56190 --- Comment #8 from Mark Thomas --- I've been back and re-read both the Servlet 3.0 and Servlet 3.1 specifications. I don't know where I got the idea from that the response always had to be writable after the call to complete() but that is

[Bug 56199] Re-implement validateXml option in JspC of Tomcat 8, or remove it from documentation

https://issues.apache.org/bugzilla/show_bug.cgi?id=56199 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1574657 - in /tomcat/trunk: java/org/apache/jasper/Constants.java java/org/apache/jasper/JspC.java java/org/apache/jasper/servlet/JspCServletContext.java webapps/docs/changelog.xml

Author: markt Date: Wed Mar 5 21:01:50 2014 New Revision: 1574657 URL: http://svn.apache.org/r1574657 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56199 Restore validateXml option to JspC Modified: tomcat/trunk/java/org/apache/jasper/Constants.java tomcat/trunk/java/org/ap

[Bug 56199] Re-implement validateXml option in JspC of Tomcat 8, or remove it from documentation

https://issues.apache.org/bugzilla/show_bug.cgi?id=56199 --- Comment #2 from Mark Thomas --- I'll re-add the feature to 8.0.x for JspC. Folks using JspC may wish to use validation. -- You are receiving this mail because: You are the assignee for the bug. ---

[Bug 56221] Crash when using tomcat version 7.0.52 when calling setImplementation method of LogFactory.java

https://issues.apache.org/bugzilla/show_bug.cgi?id=56221 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: Documentation for Tomcat 6/7 + DBCP 1

On 05/03/2014 15:53, Christopher Schultz wrote: > All, > > Tomcat 8 uses DBCP 2 which has changed the name of some > configuration parameters, specifically maxActive->maxTotal and > maxWait->maxWaitMillis. I have just fixed the JNDI DataSource > examples to reflect that. > > However, the docum

[Bug 56221] New: Crash when using tomcat version 7.0.52 when calling setImplementation method of LogFactory.java

https://issues.apache.org/bugzilla/show_bug.cgi?id=56221 Bug ID: 56221 Summary: Crash when using tomcat version 7.0.52 when calling setImplementation method of LogFactory.java Product: Tomcat 7 Version: 7.0.52 Hardware: PC

buildbot success in ASF Buildbot on tomcat-trunk

The Buildbot has detected a restored build on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/5556 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source

buildbot failure in ASF Buildbot on tomcat-7-trunk

The Buildbot has detected a new failure on builder tomcat-7-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-7-trunk/builds/1790 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Sourc

Documentation for Tomcat 6/7 + DBCP 1

All, Tomcat 8 uses DBCP 2 which has changed the name of some configuration parameters, specifically maxActive->maxTotal and maxWait->maxWaitMillis. I have just fixed the JNDI DataSource examples to reflect that. However, the documentation for Tomcat 6, 7, and 8 all point to DBCP's configuration p

svn commit: r1574543 - in /tomcat/tc7.0.x/trunk: java/org/apache/tomcat/websocket/WsSession.java webapps/docs/changelog.xml

Author: remm Date: Wed Mar 5 15:51:14 2014 New Revision: 1574543 URL: http://svn.apache.org/r1574543 Log: Pick some of r1560702. Call onError if the onClose call throws an exception. Modified: tomcat/tc7.0.x/trunk/java/org/apache/tomcat/websocket/WsSession.java tomcat/tc7.0.x/trunk/webap

svn commit: r1574541 - in /tomcat/trunk/webapps/docs: jndi-datasource-examples-howto.xml jndi-resources-howto.xml

Author: schultz Date: Wed Mar 5 15:47:11 2014 New Revision: 1574541 URL: http://svn.apache.org/r1574541 Log: Align documentation of DBCP examples to match changes from DBCP 1 -> DBCP 2. Specifically, change "maxActive" -> "maxTotal" and "maxWait" -> "maxWaitMillis" in all examples. Modified:

buildbot failure in ASF Buildbot on tomcat-trunk

The Buildbot has detected a new failure on builder tomcat-trunk while building ASF Buildbot. Full details are available at: http://ci.apache.org/builders/tomcat-trunk/builds/ Buildbot URL: http://ci.apache.org/ Buildslave for this Build: bb-vm_ubuntu Build Reason: scheduler Build Source St

svn commit: r1574517 - /tomcat/tc6.0.x/trunk/STATUS.txt

Author: markt Date: Wed Mar 5 15:00:17 2014 New Revision: 1574517 URL: http://svn.apache.org/r1574517 Log: Votes Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1574517&r1=1574516&r2=1

[Bug 56215] sendError doesn't send error page with AsyncContext

https://issues.apache.org/bugzilla/show_bug.cgi?id=56215 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1574508 - in /tomcat/trunk: java/org/apache/catalina/loader/LocalStrings.properties java/org/apache/catalina/loader/WebappClassLoader.java webapps/docs/changelog.xml

Author: kkolinko Date: Wed Mar 5 14:37:38 2014 New Revision: 1574508 URL: http://svn.apache.org/r1574508 Log: When reporting threads that are still running while web application is being stopped, print their stack traces to the log. Minor fixes: Remember result of Thread.getName() as that metho

svn commit: r1574507 - /tomcat/trunk/res/findbugs/filter-false-positives.xml

Author: markt Date: Wed Mar 5 14:32:44 2014 New Revision: 1574507 URL: http://svn.apache.org/r1574507 Log: Update false positives Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml URL: http://svn.apache.org/viewvc/

svn commit: r1574503 - /tomcat/trunk/webapps/docs/changelog.xml

Author: markt Date: Wed Mar 5 14:23:42 2014 New Revision: 1574503 URL: http://svn.apache.org/r1574503 Log: Add FindBugs fixes to change log Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/web

svn commit: r1574502 - /tomcat/trunk/java/org/apache/jasper/compiler/JspDocumentParser.java

Author: markt Date: Wed Mar 5 14:22:19 2014 New Revision: 1574502 URL: http://svn.apache.org/r1574502 Log: FindBugs: Remove unnecessary null check Modified: tomcat/trunk/java/org/apache/jasper/compiler/JspDocumentParser.java Modified: tomcat/trunk/java/org/apache/jasper/compiler/JspDocument

svn commit: r1574497 - in /tomcat/site/trunk: docs/stylesheets/tomcat.css xdocs/stylesheets/tomcat.css

Author: kpreisser Date: Wed Mar 5 14:21:49 2014 New Revision: 1574497 URL: http://svn.apache.org/r1574497 Log: Fix rendering effects on browsers like IE. Modified: tomcat/site/trunk/docs/stylesheets/tomcat.css tomcat/site/trunk/xdocs/stylesheets/tomcat.css Modified: tomcat/site/trunk/do

svn commit: r1574495 - /tomcat/trunk/java/org/apache/tomcat/util/modeler/modules/MbeansDescriptorsIntrospectionSource.java

Author: markt Date: Wed Mar 5 14:19:49 2014 New Revision: 1574495 URL: http://svn.apache.org/r1574495 Log: Findbugs: Remove pointless null check. Refactor. Modified: tomcat/trunk/java/org/apache/tomcat/util/modeler/modules/MbeansDescriptorsIntrospectionSource.java Modified: tomcat/trunk/j

svn commit: r1574493 - in /tomcat/trunk: java/org/apache/tomcat/websocket/WsRemoteEndpointImplBase.java webapps/docs/changelog.xml

Author: markt Date: Wed Mar 5 14:09:19 2014 New Revision: 1574493 URL: http://svn.apache.org/r1574493 Log: FindBugs: Avoid NPE when flushing batched WebSocket messages. Modified: tomcat/trunk/java/org/apache/tomcat/websocket/WsRemoteEndpointImplBase.java tomcat/trunk/webapps/docs/changel

svn commit: r1574488 - in /tomcat/trunk: build.xml webapps/docs/changelog.xml

Author: markt Date: Wed Mar 5 13:52:25 2014 New Revision: 1574488 URL: http://svn.apache.org/r1574488 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56204 Clean-up Modified: tomcat/trunk/build.xml tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/build.xml URL:

[Bug 56204] build target downloadgz-2 's dependence on target setproxy is redundant

https://issues.apache.org/bugzilla/show_bug.cgi?id=56204 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1574484 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/tomcat/util/net/NioBlockingSelector.java webapps/docs/changelog.xml

Author: markt Date: Wed Mar 5 13:41:58 2014 New Revision: 1574484 URL: http://svn.apache.org/r1574484 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56213 Reduce GC when NIO connector is under load. Results in a small performance improvement. KeyReferences and finalizer references w

[Bug 56213] Many KeyReference Objects Cause Long CMS-remark GC Times

https://issues.apache.org/bugzilla/show_bug.cgi?id=56213 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Bug 56217] Regarding Tomcat Manager Application Status Page

https://issues.apache.org/bugzilla/show_bug.cgi?id=56217 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

svn commit: r1574482 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/manager/StatusTransformer.java webapps/docs/changelog.xml

Author: markt Date: Wed Mar 5 13:37:47 2014 New Revision: 1574482 URL: http://svn.apache.org/r1574482 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56217 Left align makes more sense as entries might be very long Modified: tomcat/tc7.0.x/trunk/ (props changed) tomcat/tc7.0

svn commit: r1574479 - in /tomcat/trunk: java/org/apache/catalina/manager/StatusTransformer.java webapps/docs/changelog.xml

Author: markt Date: Wed Mar 5 13:36:31 2014 New Revision: 1574479 URL: http://svn.apache.org/r1574479 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56217 Left align makes more sense entries might be very long Modified: tomcat/trunk/java/org/apache/catalina/manager/StatusTransfo

Re: NIO 2 connector

Rémy, On 3/4/14, 2:23 PM, Rémy Maucherat wrote: > 2014-03-04 19:26 GMT+01:00 Mark Thomas : >> >> Can you wait until we split 8.0.x from trunk or did you want to get this >> into 8.0.x? >> > > Depends, if you want to branch soon or not. It would have to be > experimental for a while anyway, but it

svn commit: r1574456 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

Author: kkolinko Date: Wed Mar 5 12:41:47 2014 New Revision: 1574456 URL: http://svn.apache.org/r1574456 Log: Add bug number Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc7.0.x/

[Bug 56219] Failure to parse MergedWebXml in Jasper in 7.0.52 when in Strict Compliance mode for 2.5 and earlier web apps

https://issues.apache.org/bugzilla/show_bug.cgi?id=56219 Konstantin Kolinko changed: What|Removed |Added Status|NEW |RESOLVED Resolution|-

[Bug 56219] New: Failure to parse MergedWebXml in Jasper in 7.0.52 when in Strict Compliance mode for 2.5 and earlier web apps

https://issues.apache.org/bugzilla/show_bug.cgi?id=56219 Bug ID: 56219 Summary: Failure to parse MergedWebXml in Jasper in 7.0.52 when in Strict Compliance mode for 2.5 and earlier web apps Product: Tomcat 7 Version: 7.0.52

svn commit: r1574413 - /tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java

Author: remm Date: Wed Mar 5 10:33:16 2014 New Revision: 1574413 URL: http://svn.apache.org/r1574413 Log: Use the log fallback to log access anyway when something unexpected occurs. Do the same at the end of event to avoid the possibility of skipping recycling. Modified: tomcat/trunk/java/o

Re: svn commit: r1574167 - /tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java

2014-03-05 11:07 GMT+01:00 Konstantin Kolinko : > In my opinion, this is wrong. One should not skip access logging. > If context==null, it can be logged via CoyoteAdapter.log(...) that > logs into (ROOT app or Host or Engine). > Ok, I'll try to improve it. I see the call at the end of event is un

Re: svn commit: r1574167 - /tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java

2014-03-04 22:10 GMT+04:00 : > Author: remm > Date: Tue Mar 4 18:10:56 2014 > New Revision: 1574167 > > URL: http://svn.apache.org/r1574167 > Log: > Avoid possible NPE. > > Modified: > tomcat/trunk/java/org/apache/catalina/connector/CoyoteAdapter.java > > Modified: tomcat/trunk/java/org/apach