On 09/30/2013 08:50 PM, Christopher Schultz wrote:
Mladen,
Unless there is significant objection,
Yes there is.
The transition from Java to JNI costs 10 times then
then a simple 'if (socket == OL)' in java
I'd like to add such NULL checks
to limit JVM crashes in cases where the Java code is
> -Original Message-
> From: Mark Thomas [mailto:ma...@apache.org]
> Sent: Monday, September 30, 2013 9:31 PM
> To: Tomcat Developers List
> Subject: Re: [VOTE] Release Apache Tomcat 7.0.45
>
> On 30/09/2013 09:00, Mark Thomas wrote:
> > On 26/09/2013 19:46, Konstantin Preißer wrote:
> >
On 30/09/2013 20:31, Mark Thomas wrote:
> On 30/09/2013 09:00, Mark Thomas wrote:
>> It looks like my recent fixes for APR/native unit test failures/crashes
>> are the culprit. Hopefully it won't take too long to find a fix.
> I *think* I have a fix for this. If folks that have seen this error
>
The Buildbot has detected a restored build on builder tomcat-7-trunk while
building ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/tomcat-7-trunk/builds/1434
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: bb-vm_ubuntu
Build Reason: scheduler
Build So
https://issues.apache.org/bugzilla/show_bug.cgi?id=55602
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Version|unspecif
Author: markt
Date: Mon Sep 30 19:39:50 2013
New Revision: 1527745
URL: http://svn.apache.org/r1527745
Log:
Update changelog
Modified:
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/t
Author: markt
Date: Mon Sep 30 19:38:05 2013
New Revision: 1527742
URL: http://svn.apache.org/r1527742
Log:
Switch to destroySocket in a few places where it is safe to do so.
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint
Author: markt
Date: Mon Sep 30 19:37:33 2013
New Revision: 1527740
URL: http://svn.apache.org/r1527740
Log:
Refactor the method names some more.
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
Propchange: tomcat/tc7.
Author: markt
Date: Mon Sep 30 19:34:42 2013
New Revision: 1527738
URL: http://svn.apache.org/r1527738
Log:
Add a warning comment and simplify the code a little.
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
Propch
Author: markt
Date: Mon Sep 30 19:34:17 2013
New Revision: 1527737
URL: http://svn.apache.org/r1527737
Log:
Refactor the remove list in the Poller to be a close list. The poller
now removes the socket if it is in the Poller then destroys it. Note the
socket is always destroyed whether it is found
Author: markt
Date: Mon Sep 30 19:33:41 2013
New Revision: 1527735
URL: http://svn.apache.org/r1527735
Log:
Rename method
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
Propchange: tomcat/tc7.0.x/trunk/
Author: markt
Date: Mon Sep 30 19:33:10 2013
New Revision: 1527734
URL: http://svn.apache.org/r1527734
Log:
Move the point where the socket is removed from the connections Map so
all the actions apart from removal from the Poller are in a single
method to facilitate refactoring removal of the sock
On 30/09/2013 09:00, Mark Thomas wrote:
> On 26/09/2013 19:46, Konstantin Preißer wrote:
>> Hi Rainer,
>>
>>> -Original Message-
>>> From: Rainer Jung [mailto:rainer.j...@kippdata.de]
>>> Sent: Thursday, September 26, 2013 8:22 PM
>>
>>> Any chance you can try current trunk? Mark added more
Author: markt
Date: Mon Sep 30 19:27:02 2013
New Revision: 1527733
URL: http://svn.apache.org/r1527733
Log:
Switch to destroySocket in a few places where it is safe to do so.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
Modified: tomcat/trunk/java/org/apache/tomcat
Author: markt
Date: Mon Sep 30 19:26:27 2013
New Revision: 1527732
URL: http://svn.apache.org/r1527732
Log:
Refactor the method names some more.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
URL
Author: markt
Date: Mon Sep 30 19:25:52 2013
New Revision: 1527731
URL: http://svn.apache.org/r1527731
Log:
Add a warning comment and simplify the code a little.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/Apr
Author: markt
Date: Mon Sep 30 19:25:18 2013
New Revision: 1527730
URL: http://svn.apache.org/r1527730
Log:
Refactor the remove list in the Poller to be a close list. The poller
now removes the socket if it is in the Poller then destroys it. Note the
socket is always destroyed whether it is found
Author: markt
Date: Mon Sep 30 19:24:43 2013
New Revision: 1527728
URL: http://svn.apache.org/r1527728
Log:
Rename method
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
URL:
http://svn.apache.or
Author: markt
Date: Mon Sep 30 19:24:07 2013
New Revision: 1527727
URL: http://svn.apache.org/r1527727
Log:
Move the point where the socket is removed from the connections Map so
all the actions apart from removal from the Poller are in a single
method to facilitate refactoring removal of the sock
Konstantin,
On 9/30/13 11:32 AM, Konstantin Preißer wrote:
> Hi Chris,
>
>> -Original Message-
>> From: Christopher Schultz [mailto:ch...@christopherschultz.net]
>> Sent: Monday, September 30, 2013 5:19 PM
>> To: Tomcat Developers List
>> Subject: Re: Possible IIS SPDY Redirector for Tomc
Mladen,
On 9/30/13 1:42 PM, Mladen Turk wrote:
> On 09/30/2013 05:33 PM, Christopher Schultz wrote:
>>
>> I may need a little more guidance, since adding NULL-checks for
>> everything is a little silly. Here is the function declaration in
>> tcnative:
>>
>> TCN_IMPLEMENT_CALL(jint, Poll, poll)(TCN
https://issues.apache.org/bugzilla/show_bug.cgi?id=55613
Mark Thomas changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://issues.apache.org/bugzilla/show_bug.cgi?id=55613
Tony Weston changed:
What|Removed |Added
OS||All
--- Comment #1 from Tony Weston
https://issues.apache.org/bugzilla/show_bug.cgi?id=55613
Bug ID: 55613
Summary: Contexts in webapp/META-INF should be observed even if
an equivalent Context appears in server.xml
Product: Tomcat 7
Version: trunk
Hardware: P
On 09/30/2013 05:33 PM, Christopher Schultz wrote:
I may need a little more guidance, since adding NULL-checks for
everything is a little silly. Here is the function declaration in tcnative:
TCN_IMPLEMENT_CALL(jint, Poll, poll)(TCN_STDARGS, jlong pollset,
j
Mark,
On 9/30/13 9:34 AM, Mark Thomas wrote:
> On 30/09/2013 08:32, Mark Thomas wrote:
>> On 28/09/2013 11:57, Mladen Turk wrote:
>>> On 09/28/2013 12:25 PM, Rainer Jung wrote:
> I can't seem to reproduce the problem using an APR connector on Linux:
> reports seems to indicate that tr
Hi Chris,
> -Original Message-
> From: Christopher Schultz [mailto:ch...@christopherschultz.net]
> Sent: Monday, September 30, 2013 5:19 PM
> To: Tomcat Developers List
> Subject: Re: Possible IIS SPDY Redirector for Tomcat
>
> Konstantin,
>
> On 9/28/13 1:40 PM, Konstantin Preißer wrote
On 09/30/2013 03:34 PM, Mark Thomas wrote:
I'd like to try and make the changes as a series of small, incremental,
easy to review changes. I'm not sure how feasible that will be. I hope
to have this fixed in the next day or so.
Cool.
Not sure if socket wrapper is created for each native socke
Konstantin,
On 9/28/13 1:40 PM, Konstantin Preißer wrote:
> Contra:
> - Worse performance than the native ISAPI redirector. I made a test by a
> Servlet that produces 700 MB of random data, and on a separate machine I used
> a program to make a HTTP request and read the data. The average transfe
https://issues.apache.org/bugzilla/show_bug.cgi?id=55608
--- Comment #3 from Christopher Schultz ---
One could argue that might actually be used to intentionally
buffer content a bit, just in case an error occurs. Once the response is
committed, errors occurring during rendering are usually cata
On 30/09/2013 08:32, Mark Thomas wrote:
> On 28/09/2013 11:57, Mladen Turk wrote:
>> On 09/28/2013 12:25 PM, Rainer Jung wrote:
>>>
I can't seem to reproduce the problem using an APR connector on Linux:
reports seems to indicate that trivially accessing Tomcat via an HTTP
APR connect
The Buildbot has detected a new failure on builder tomcat-7-trunk while
building ASF Buildbot.
Full details are available at:
http://ci.apache.org/builders/tomcat-7-trunk/builds/1433
Buildbot URL: http://ci.apache.org/
Buildslave for this Build: bb-vm_ubuntu
Build Reason: scheduler
Build Sourc
Author: markt
Date: Mon Sep 30 10:01:38 2013
New Revision: 1527504
URL: http://svn.apache.org/r1527504
Log:
Better debug messages
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/res/LocalStrings.properties
Modified:
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/res/Lo
Author: markt
Date: Mon Sep 30 10:00:35 2013
New Revision: 1527503
URL: http://svn.apache.org/r1527503
Log:
Better debug messages
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/res/LocalStrings.properties
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/res/LocalStrings.proper
Author: markt
Date: Mon Sep 30 09:16:58 2013
New Revision: 1527495
URL: http://svn.apache.org/r1527495
Log:
Add missing bracket
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/res/LocalStrings.properties
Propchange: tomcat/tc7.0.x/t
Author: markt
Date: Mon Sep 30 09:16:24 2013
New Revision: 1527493
URL: http://svn.apache.org/r1527493
Log:
Add missing bracket
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/res/LocalStrings.properties
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/res/LocalStrings.properti
Author: markt
Date: Mon Sep 30 08:18:54 2013
New Revision: 1527483
URL: http://svn.apache.org/r1527483
Log:
Fix copy/paste error
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
Propchange: tomcat/tc7.0.x/trunk/
-
Author: markt
Date: Mon Sep 30 08:11:34 2013
New Revision: 1527480
URL: http://svn.apache.org/r1527480
Log:
Fix copy/paste error
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
URL:
http://svn.ap
On 26/09/2013 19:46, Konstantin Preißer wrote:
> Hi Rainer,
>
>> -Original Message-
>> From: Rainer Jung [mailto:rainer.j...@kippdata.de]
>> Sent: Thursday, September 26, 2013 8:22 PM
>
>> Any chance you can try current trunk? Mark added more fixes to
>> AprEndpoint after r1523781. It wou
Author: kfujino
Date: Mon Sep 30 07:54:55 2013
New Revision: 1527475
URL: http://svn.apache.org/r1527475
Log:
Add document for sessionIdAttribute attribute in JvmRouteBinderValve.
Modified:
tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml
tomcat/tc7.0.x/trunk/webapps/docs/cluster-howto.xml
Author: kfujino
Date: Mon Sep 30 07:46:14 2013
New Revision: 1527474
URL: http://svn.apache.org/r1527474
Log:
Fix default value of sessionIdAttribute.
Modified:
tomcat/trunk/webapps/docs/cluster-howto.xml
Modified: tomcat/trunk/webapps/docs/cluster-howto.xml
URL:
http://svn.apache.org/viewv
Author: markt
Date: Mon Sep 30 07:45:09 2013
New Revision: 1527472
URL: http://svn.apache.org/r1527472
Log:
Removal of a socket from the poller needs to happen on the poller thread as
removal, like addition, is not thread safe.
Removal of a socket from the poller needs to remove the socket from t
Author: markt
Date: Mon Sep 30 07:43:19 2013
New Revision: 1527470
URL: http://svn.apache.org/r1527470
Log:
Narrow scope of localAddList
Modified:
tomcat/tc7.0.x/trunk/ (props changed)
tomcat/tc7.0.x/trunk/java/org/apache/tomcat/util/net/AprEndpoint.java
tomcat/tc7.0.x/trunk/webapps
Author: kfujino
Date: Mon Sep 30 07:37:53 2013
New Revision: 1527468
URL: http://svn.apache.org/r1527468
Log:
Add document for sessionIdAttribute attribute in JvmRouteBinderValve.
Modified:
tomcat/trunk/webapps/docs/config/cluster-valve.xml
Modified: tomcat/trunk/webapps/docs/config/cluster-
On 28/09/2013 11:57, Mladen Turk wrote:
> On 09/28/2013 12:25 PM, Rainer Jung wrote:
>>
>>> I can't seem to reproduce the problem using an APR connector on Linux:
>>> reports seems to indicate that trivially accessing Tomcat via an HTTP
>>> APR connector will cause a crash, and I was able to run th
45 matches
Mail list logo
