Re: Issues in Apache Taglibs 1.2.0-RC1

2013-09-20 Thread sebb
On 18 September 2013 08:01, Jeremy Boynes wrote: > On Sep 15, 2013, at 4:49 PM, sebb wrote: > >> On 14 September 2013 17:09, Jeremy Boynes wrote: >>> >>> I think addressed those issues in the following changes: >>> http://svn.apache.org/r1512150 >>> http://svn.apache.org/r1512151 >>> http://svn.

Re: SCI discovery ordering

2013-09-20 Thread Nick Williams
On Sep 20, 2013, at 4:33 PM, Jeremy Boynes wrote: > On Fri, Sep 20, 2013 at 8:50 AM, Mark Thomas wrote: > >> On 20/09/2013 16:02, Jeremy Boynes wrote: >>> The only ordering concern for SCIs in the spec is that they are >>> "discovered" following the classloader delegation model. This will >>> t

[Bug 55576] New: Order of ServletRequest parameters is not preserved

2013-09-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55576 Bug ID: 55576 Summary: Order of ServletRequest parameters is not preserved Product: Tomcat 7 Version: 7.0.35 Hardware: PC Status: NEW Severity: major Prio

Re: SCI discovery ordering

2013-09-20 Thread Jeremy Boynes
On Fri, Sep 20, 2013 at 8:50 AM, Mark Thomas wrote: > On 20/09/2013 16:02, Jeremy Boynes wrote: > > The only ordering concern for SCIs in the spec is that they are > > "discovered" following the classloader delegation model. This will > > typically be configured to load application classes first,

Re: [VOTE] Release Apache Tomcat 8.0.0-RC3

2013-09-20 Thread Mark Thomas
On 20/09/2013 11:36, Mark Thomas wrote: > The proposed Apache Tomcat 8.0.0 release candidate 3 is now available > for voting. > > Given this is a release candidate I am working on the basis that it is > equivalent to an alpha. The main changes since RC1 are: > - Updated spec implementations with r

Re: SCI discovery ordering

2013-09-20 Thread Mark Thomas
On 20/09/2013 16:02, Jeremy Boynes wrote: > The only ordering concern for SCIs in the spec is that they are > "discovered" following the classloader delegation model. This will > typically be configured to load application classes first, > something r1524727 does not do. The intention of the lan

Re: [VOTE] Release Apache Tomcat 7.0.43

2013-09-20 Thread Yoav Shapira
On Fri, Sep 20, 2013 at 3:38 AM, Violeta Georgieva wrote: > The proposed Apache Tomcat 7.0.43 release is now available for voting. > This release candidate contains JSR-356 Java WebSocket 1.0 implementation. > Note that use of this functionality requires Java 7. > > It can be obtained from: > http

Re: SCI discovery ordering

2013-09-20 Thread Jeremy Boynes
On Sep 20, 2013, at 12:38 AM, Mark Thomas wrote: > On 20/09/2013 06:11, Jeremy Boynes wrote: >> On Sep 19, 2013, at 8:31 AM, Jeremy Boynes wrote: >> >>> On Sep 19, 2013, at 6:07 AM, ma...@apache.org wrote: >>> Author: markt Date: Thu Sep 19 13:07:02 2013 New Revision: 1524727 >>

Re: Some trunk test suite observations

2013-09-20 Thread Mark Thomas
On 20/09/2013 11:02, Rainer Jung wrote: > Having run some sporadically failing tests in a loop under the three > connectors on Solaris 10 Sparc using Java 1.7.0_40. Code is trunk > r1524838 (current as of this morning and codewise identical to 8.0.0 RC3). Great. This is really helpful. If you coul

svn commit: r1524984 - /tomcat/trunk/test/org/apache/tomcat/websocket/TestWsWebSocketContainer.java

2013-09-20 Thread markt
Author: markt Date: Fri Sep 20 12:40:39 2013 New Revision: 1524984 URL: http://svn.apache.org/r1524984 Log: Fix possible false test failure when the session gets closed before the message write can complete. Modified: tomcat/trunk/test/org/apache/tomcat/websocket/TestWsWebSocketContainer.jav

svn commit: r1524978 - /tomcat/trunk/test/org/apache/tomcat/websocket/TestWsSubprotocols.java

2013-09-20 Thread markt
Author: markt Date: Fri Sep 20 11:36:48 2013 New Revision: 1524978 URL: http://svn.apache.org/r1524978 Log: Attempt to address intermittent failures suspect to be caused by timing/threading issues Modified: tomcat/trunk/test/org/apache/tomcat/websocket/TestWsSubprotocols.java Modified: tomc

svn commit: r1524977 - /tomcat/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderExecutorMemoryLeak.java

2013-09-20 Thread markt
Author: markt Date: Fri Sep 20 11:22:49 2013 New Revision: 1524977 URL: http://svn.apache.org/r1524977 Log: Attempt to address intermittent failures suspect to be caused by timing issues Modified: tomcat/trunk/test/org/apache/catalina/loader/TestWebappClassLoaderExecutorMemoryLeak.java Modi

Re: [VOTE] Release Apache Tomcat 7.0.43

2013-09-20 Thread Jeanfrancois Arcand
On 2013-09-20 7:05 AM, Mark Thomas wrote: On 20/09/2013 11:57, Jeanfrancois Arcand wrote: On 2013-09-20 6:26 AM, Mark Thomas wrote: On 20/09/2013 11:24, Jeanfrancois Arcand wrote: Hi, [X] Broken - do not release I do test/use Tomcat with WebSocket since 7.0.27. 8.0.0-RC1 worked well with js

Re: [VOTE] Release Apache Tomcat 7.0.43

2013-09-20 Thread Mark Thomas
On 20/09/2013 11:57, Jeanfrancois Arcand wrote: > > On 2013-09-20 6:26 AM, Mark Thomas wrote: >> On 20/09/2013 11:24, Jeanfrancois Arcand wrote: >>> Hi, >>> >>> [X] Broken - do not release >>> >>> I do test/use Tomcat with WebSocket since 7.0.27. 8.0.0-RC1 worked well >>> with jsr356, but 7.0.43 i

Re: [VOTE] Release Apache Tomcat 7.0.43

2013-09-20 Thread Violeta Georgieva
2013/9/20 Jeanfrancois Arcand > > > On 2013-09-20 6:26 AM, Mark Thomas wrote: >> >> On 20/09/2013 11:24, Jeanfrancois Arcand wrote: >>> >>> Hi, >>> >>> [X] Broken - do not release >>> >>> I do test/use Tomcat with WebSocket since 7.0.27. 8.0.0-RC1 worked well >>> with jsr356, but 7.0.43 is broken.

Re: [VOTE] Release Apache Tomcat 7.0.43

2013-09-20 Thread Jeanfrancois Arcand
On 2013-09-20 6:26 AM, Mark Thomas wrote: On 20/09/2013 11:24, Jeanfrancois Arcand wrote: Hi, [X] Broken - do not release I do test/use Tomcat with WebSocket since 7.0.27. 8.0.0-RC1 worked well with jsr356, but 7.0.43 is broken. You can try it by deploying http://search.maven.org/remoteconte

[VOTE] Release Apache Tomcat 8.0.0-RC3

2013-09-20 Thread Mark Thomas
The proposed Apache Tomcat 8.0.0 release candidate 3 is now available for voting. Given this is a release candidate I am working on the basis that it is equivalent to an alpha. The main changes since RC1 are: - Updated spec implementations with results of various "grey area" discussions from the E

Re: [VOTE] Release Apache Tomcat 7.0.43

2013-09-20 Thread Mark Thomas
On 20/09/2013 11:24, Jeanfrancois Arcand wrote: > Hi, > > [X] Broken - do not release > > I do test/use Tomcat with WebSocket since 7.0.27. 8.0.0-RC1 worked well > with jsr356, but 7.0.43 is broken. You can try it by deploying > > http://search.maven.org/remotecontent?filepath=org/atmosphere/sam

Re: [VOTE] Release Apache Tomcat 7.0.43

2013-09-20 Thread Jeanfrancois Arcand
One more observation. If I force Atmosphere to use the Tomcat Native WebSocket API instead of jsr 356, the 7.0.43 works fine as well. So only jsr356 is broken. -- Jeanfrancois On 2013-09-20 6:24 AM, Jeanfrancois Arcand wrote: Hi, [X] Broken - do not release I do test/use Tomcat with WebSocke

Re: [VOTE] Release Apache Tomcat 7.0.43

2013-09-20 Thread Jeanfrancois Arcand
Hi, [X] Broken - do not release I do test/use Tomcat with WebSocket since 7.0.27. 8.0.0-RC1 worked well with jsr356, but 7.0.43 is broken. You can try it by deploying http://search.maven.org/remotecontent?filepath=org/atmosphere/samples/atmosphere-chat/2.0.0/atmosphere-chat-2.0.0.war This ap

Some trunk test suite observations

2013-09-20 Thread Rainer Jung
Having run some sporadically failing tests in a loop under the three connectors on Solaris 10 Sparc using Java 1.7.0_40. Code is trunk r1524838 (current as of this morning and codewise identical to 8.0.0 RC3). The system is relatively slow but not *that* slow. OTOH it had some NFS server duties wh

Re: svn commit: r1524545 - in /tomcat/tc7.0.x/tags/TOMCAT_7_0_43: ./ build.properties.default

2013-09-20 Thread Violeta Georgieva
2013/9/19 Konstantin Kolinko > > 2013/9/18 : > > Author: violetagg > > Date: Wed Sep 18 19:44:03 2013 > > New Revision: 1524545 > > > > URL: http://svn.apache.org/r1524545 > > Log: > > Tag 7.0.43 > > > > Added: > > tomcat/tc7.0.x/tags/TOMCAT_7_0_43/ (props changed) > > - copied from r

svn commit: r1524929 - in /tomcat/tc7.0.x/trunk: build.properties.default res/maven/mvn.properties.default

2013-09-20 Thread violetagg
Author: violetagg Date: Fri Sep 20 07:58:11 2013 New Revision: 1524929 URL: http://svn.apache.org/r1524929 Log: Prep for next version Modified: tomcat/tc7.0.x/trunk/build.properties.default tomcat/tc7.0.x/trunk/res/maven/mvn.properties.default Modified: tomcat/tc7.0.x/trunk/build.propert

Re: SCI discovery ordering

2013-09-20 Thread Remy Maucherat
On Fri, 2013-09-20 at 08:38 +0100, Mark Thomas wrote: > a) The container defined SCIs need to be loaded first. Any other > solution places an unnecessary burden on application developers. It is > reasonable for application developers to expect that if a container > advertises support for WebSocket,

[VOTE] Release Apache Tomcat 7.0.43

2013-09-20 Thread Violeta Georgieva
The proposed Apache Tomcat 7.0.43 release is now available for voting. This release candidate contains JSR-356 Java WebSocket 1.0 implementation. Note that use of this functionality requires Java 7. It can be obtained from: https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.43/ The Maven

Re: SCI discovery ordering

2013-09-20 Thread Mark Thomas
On 20/09/2013 06:11, Jeremy Boynes wrote: > On Sep 19, 2013, at 8:31 AM, Jeremy Boynes wrote: > >> On Sep 19, 2013, at 6:07 AM, ma...@apache.org wrote: >> >>> Author: markt >>> Date: Thu Sep 19 13:07:02 2013 >>> New Revision: 1524727 >>> >>> URL: http://svn.apache.org/r1524727 >>> Log: >>> Always