On 20/09/2013 11:57, Jeanfrancois Arcand wrote: > > On 2013-09-20 6:26 AM, Mark Thomas wrote: >> On 20/09/2013 11:24, Jeanfrancois Arcand wrote: >>> Hi, >>> >>> [X] Broken - do not release >>> >>> I do test/use Tomcat with WebSocket since 7.0.27. 8.0.0-RC1 worked well >>> with jsr356, but 7.0.43 is broken. You can try it by deploying >>> >>> http://search.maven.org/remotecontent?filepath=org/atmosphere/samples/atmosphere-chat/2.0.0/atmosphere-chat-2.0.0.war >>> >> Just a quick question, were you running on Java 7? > Ah! No I wasn't. I think a log message or warning should be written > because the jsr356's ServerApplicationConfig is scanned and created with > jdk 6, hence initialized.
There is a log message when you start with Java 6. It is at INFO level and is written the first time the WebSocket ServletContainerInitializer is called. Thoughts on making that message more prominent / increasing it to WARN ? > So I confirm it works with jdk7, with a small error > > https://gist.github.com/jfarcand/6635844 Best guess is if you switch 7.0.x to use NIO the error will go away (or switch 8.0.x to use BIO and the error will appear). >From the stack trace it looks like it might be a bug. > I don't get that error with 8.0.0-RC3 (will file an issue). But that > shouldn't stop the release, so I change my vote to > > [X] Stable - go ahead and release as 7.0.43 Stable > > (native and jsr 356 websockets works fine) Great. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
