Re: [Bug 55259] Unnecessary work in JspConfig

2013-07-16 Thread Jeremy Boynes
On Jul 16, 2013, at 10:27 AM, Christopher Schultz wrote: > Jeremy, > > On 7/13/13 6:11 PM, bugzi...@apache.org wrote: >> https://issues.apache.org/bugzilla/show_bug.cgi?id=55259 >> >> Jeremy Boynes changed: >> >> What|Removed |Added >> --

[Bug 55259] Unnecessary work in JspConfig

2013-07-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55259 --- Comment #3 from Jeremy Boynes --- Fixed in trunk: http://svn.apache.org/r1502897 -- You are receiving this mail because: You are the assignee for the bug. - To unsub

svn commit: r1503937 - in /tomcat/trunk: java/org/apache/el/lang/ java/org/apache/el/parser/ java/org/apache/el/stream/ test/org/apache/el/lang/ webapps/docs/config/

2013-07-16 Thread markt
Author: markt Date: Tue Jul 16 23:01:27 2013 New Revision: 1503937 URL: http://svn.apache.org/r1503937 Log: Implement non-backwards compatible change to the coercion rules. Modified: tomcat/trunk/java/org/apache/el/lang/ELSupport.java tomcat/trunk/java/org/apache/el/parser/AstAnd.java

svn commit: r1503930 - in /tomcat/trunk/test/org/apache/el/parser: TestAstAnd.java TestAstChoice.java TestAstNot.java TestAstOr.java

2013-07-16 Thread markt
Author: markt Date: Tue Jul 16 22:39:37 2013 New Revision: 1503930 URL: http://svn.apache.org/r1503930 Log: New tests to ensure changes in coercion rules for nulls don't break any code that uses coerceToBoolean internally Added: tomcat/trunk/test/org/apache/el/parser/TestAstAnd.java (with

svn commit: r1503926 - /tomcat/trunk/java/org/apache/el/stream/Stream.java

2013-07-16 Thread markt
Author: markt Date: Tue Jul 16 22:24:51 2013 New Revision: 1503926 URL: http://svn.apache.org/r1503926 Log: Unlikely but protect against the lambda expression returning null. Modified: tomcat/trunk/java/org/apache/el/stream/Stream.java Modified: tomcat/trunk/java/org/apache/el/stream/Stream.

Various shell-scripting idioms in bin/daemon.sh

2013-07-16 Thread Christopher Schultz
All, While doing the trivial fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=55268, I noticed a few idioms being used in bin/daemon.sh that struck me as odd. For example: while [ ".$1" != . ] do case "$1" in --java-home ) JAVA_HOME="$2" shift; shift; conti

[Bug 55268] daemon.sh only waits for 10 seconds

2013-07-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55268 Christopher Schultz changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|

svn commit: r1503878 - /tomcat/trunk/test/org/apache/el/lang/TestELArithmetic.java

2013-07-16 Thread markt
Author: markt Date: Tue Jul 16 20:49:58 2013 New Revision: 1503878 URL: http://svn.apache.org/r1503878 Log: Add some test cases for null handling Modified: tomcat/trunk/test/org/apache/el/lang/TestELArithmetic.java Modified: tomcat/trunk/test/org/apache/el/lang/TestELArithmetic.java URL: ht

svn commit: r1503872 - /tomcat/trunk/java/org/apache/el/parser/ELParser.jjt

2013-07-16 Thread markt
Author: markt Date: Tue Jul 16 20:39:00 2013 New Revision: 1503872 URL: http://svn.apache.org/r1503872 Log: whitespace police Modified: tomcat/trunk/java/org/apache/el/parser/ELParser.jjt Modified: tomcat/trunk/java/org/apache/el/parser/ELParser.jjt URL: http://svn.apache.org/viewvc/tomcat/

svn commit: r1503865 - in /tomcat/trunk/java/javax/el: BeanELResolver.java ELContext.java

2013-07-16 Thread markt
Author: markt Date: Tue Jul 16 20:12:32 2013 New Revision: 1503865 URL: http://svn.apache.org/r1503865 Log: Use new API Modified: tomcat/trunk/java/javax/el/BeanELResolver.java tomcat/trunk/java/javax/el/ELContext.java Modified: tomcat/trunk/java/javax/el/BeanELResolver.java URL: http:/

Re: [Bug 55268] daemon.sh only waits for 10 seconds

2013-07-16 Thread Mark Thomas
On 16/07/2013 20:56, bugzi...@apache.org wrote: > https://issues.apache.org/bugzilla/show_bug.cgi?id=55268 > > Christopher Schultz changed: > >What|Removed |Added > > Sta

svn commit: r1503857 - in /tomcat/trunk: java/javax/el/ java/org/apache/el/parser/ test/org/apache/el/parser/

2013-07-16 Thread markt
Author: markt Date: Tue Jul 16 20:01:47 2013 New Revision: 1503857 URL: http://svn.apache.org/r1503857 Log: Fix handling of nested lambda expressions with method parameters. Removed: tomcat/trunk/java/org/apache/el/parser/AstLambdaExpressionOrInvocation.java Modified: tomcat/trunk/java/ja

svn commit: r1503854 - /tomcat/tc6.0.x/trunk/STATUS.txt

2013-07-16 Thread schultz
Author: schultz Date: Tue Jul 16 19:56:43 2013 New Revision: 1503854 URL: http://svn.apache.org/r1503854 Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1503854&r1=1503853

[Bug 55268] daemon.sh only waits for 10 seconds

2013-07-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55268 Christopher Schultz changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1503852 - in /tomcat/tc7.0.x/trunk: ./ bin/daemon.sh webapps/docs/changelog.xml

2013-07-16 Thread schultz
Author: schultz Date: Tue Jul 16 19:54:00 2013 New Revision: 1503852 URL: http://svn.apache.org/r1503852 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55268 Added optional --service-start-wait-time command-line option to change service start wait time from default of 10 seconds.

svn commit: r1503851 - /tomcat/trunk/bin/daemon.sh

2013-07-16 Thread schultz
Author: schultz Date: Tue Jul 16 19:51:00 2013 New Revision: 1503851 URL: http://svn.apache.org/r1503851 Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=55268 Added optional --service-start-wait-time command-line option to change service start wait time from default of 10 seconds.

[Bug 55268] daemon.sh only waits for 10 seconds

2013-07-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55268 --- Comment #2 from js...@zepler.net --- I think a command line parameter would be more visible in diagnostics and more straightforward to add to puppet manifests, so that would be my preference. -- You are receiving this mail because: You

[Bug 55268] daemon.sh only waits for 10 seconds

2013-07-16 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=55268 --- Comment #1 from Christopher Schultz --- It appears that while catalina.sh mostly uses environment variables to adjust behavior, daemon.sh uses command-line arguments. Would you prefer an environment variable or a command-line parameter?

Re: [Bug 55259] Unnecessary work in JspConfig

2013-07-16 Thread Christopher Schultz
Jeremy, On 7/13/13 6:11 PM, bugzi...@apache.org wrote: > https://issues.apache.org/bugzilla/show_bug.cgi?id=55259 > > Jeremy Boynes changed: > >What|Removed |Added > > S

Re: svn commit: r1503056 - in /tomcat/trunk: java/org/apache/el/ java/org/apache/el/parser/ test/org/apache/el/parser/

2013-07-16 Thread Mark Thomas
On 16/07/2013 16:02, Mark Thomas wrote: > On 16/07/2013 15:39, Violeta Georgieva wrote: >> 2013/7/16 Mark Thomas wrote: >>> > > > >>> Do you have an example of a valid expression that needs multiple method >>> arguments? I'll try and come up with one. If I can't I'll change the >>> grammar and r

svn commit: r1503766 - in /tomcat/trunk/java/org/apache/el/parser: ELParser.java ELParser.jjt

2013-07-16 Thread markt
Author: markt Date: Tue Jul 16 15:46:34 2013 New Revision: 1503766 URL: http://svn.apache.org/r1503766 Log: Rever r1503672 Modified: tomcat/trunk/java/org/apache/el/parser/ELParser.java tomcat/trunk/java/org/apache/el/parser/ELParser.jjt Modified: tomcat/trunk/java/org/apache/el/parser/E

Re: svn commit: r1503056 - in /tomcat/trunk: java/org/apache/el/ java/org/apache/el/parser/ test/org/apache/el/parser/

2013-07-16 Thread Mark Thomas
On 16/07/2013 15:39, Violeta Georgieva wrote: > 2013/7/16 Mark Thomas wrote: >> >> Do you have an example of a valid expression that needs multiple method >> arguments? I'll try and come up with one. If I can't I'll change the >> grammar and re-generate. > > What about > (x->y->x+y)(a)(b) > >

Re: svn commit: r1503056 - in /tomcat/trunk: java/org/apache/el/ java/org/apache/el/parser/ test/org/apache/el/parser/

2013-07-16 Thread Violeta Georgieva
2013/7/16 Mark Thomas wrote: > > On 16/07/2013 09:02, Violeta Georgieva wrote: > > 2013/7/15 > > > > >> +public class AstLambdaExpressionOrInvocation extends SimpleNode { > >> + > >> +public AstLambdaExpressionOrInvocation(int id) { > >> +super(id); > >> +} > >> + > >> + > >> +

svn commit: r1503734 - in /tomcat/trunk: java/org/apache/el/stream/Stream.java test/org/apache/el/stream/TestCollectionOperations.java

2013-07-16 Thread markt
Author: markt Date: Tue Jul 16 14:32:13 2013 New Revision: 1503734 URL: http://svn.apache.org/r1503734 Log: EL 3.0 collections operations. Implement anyMatch, allMatch noneMatch and findFirst. Modified: tomcat/trunk/java/org/apache/el/stream/Stream.java tomcat/trunk/test/org/apache/el/str

svn commit: r1503715 - in /tomcat/trunk: java/org/apache/el/stream/Stream.java test/org/apache/el/stream/TestCollectionOperations.java

2013-07-16 Thread markt
Author: markt Date: Tue Jul 16 13:45:47 2013 New Revision: 1503715 URL: http://svn.apache.org/r1503715 Log: EL 3.0 collections operations. Implement average, sum and count. Modified: tomcat/trunk/java/org/apache/el/stream/Stream.java tomcat/trunk/test/org/apache/el/stream/TestCollectionOp

svn commit: r1503683 - in /tomcat/trunk: java/org/apache/el/stream/Stream.java test/org/apache/el/stream/TestCollectionOperations.java

2013-07-16 Thread markt
Author: markt Date: Tue Jul 16 12:34:36 2013 New Revision: 1503683 URL: http://svn.apache.org/r1503683 Log: EL 3.0 collections operations. Implement max and min. Modified: tomcat/trunk/java/org/apache/el/stream/Stream.java tomcat/trunk/test/org/apache/el/stream/TestCollectionOperations.ja

[jira] [Commented] (MTOMCAT-216) tomca7:run fails in multi-module project with overlays

2013-07-16 Thread Petar Tahchiev (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13709703#comment-13709703 ] Petar Tahchiev commented on MTOMCAT-216: No, sorry.. I still see the exception ev

svn commit: r1503672 - in /tomcat/trunk/java/org/apache/el/parser: ELParser.java ELParser.jjt

2013-07-16 Thread markt
Author: markt Date: Tue Jul 16 12:00:18 2013 New Revision: 1503672 URL: http://svn.apache.org/r1503672 Log: A LambdaExpression has zero or one rather than zero to many MethodParameters Modified: tomcat/trunk/java/org/apache/el/parser/ELParser.java tomcat/trunk/java/org/apache/el/parser/EL

svn commit: r1503667 - in /tomcat/trunk: java/org/apache/el/stream/Optional.java java/org/apache/el/stream/Stream.java test/org/apache/el/stream/TestCollectionOperations.java

2013-07-16 Thread markt
Author: markt Date: Tue Jul 16 11:52:45 2013 New Revision: 1503667 URL: http://svn.apache.org/r1503667 Log: EL 3.0 collections operations. Implement reduce. Modified: tomcat/trunk/java/org/apache/el/stream/Optional.java tomcat/trunk/java/org/apache/el/stream/Stream.java tomcat/trunk/t

Re: svn commit: r1503056 - in /tomcat/trunk: java/org/apache/el/ java/org/apache/el/parser/ test/org/apache/el/parser/

2013-07-16 Thread Mark Thomas
On 16/07/2013 09:02, Violeta Georgieva wrote: > 2013/7/15 >> +public class AstLambdaExpressionOrInvocation extends SimpleNode { >> + >> +public AstLambdaExpressionOrInvocation(int id) { >> +super(id); >> +} >> + >> + >> +@Override >> +public Object getValue(EvaluationCon

Re: svn commit: r1503056 - in /tomcat/trunk: java/org/apache/el/ java/org/apache/el/parser/ test/org/apache/el/parser/

2013-07-16 Thread Violeta Georgieva
2013/7/15 > > Author: markt > Date: Sun Jul 14 21:07:26 2013 > New Revision: 1503056 > > URL: http://svn.apache.org/r1503056 > Log: > Start to implement the lambda expression syntax. Very basic expressions work. I expect further changes to be required for more complex expressions. > Includes the i