Re: WebSocketServlet (and chat example) comments

2012-06-19 Thread Mark Thomas
On 19/06/2012 18:02, Michael Roberts wrote: >> >> 3) As mentioned, the chat example maintains a list of connections. Connections (MessageInbound instances) are added to this list when connections are established. However, they are never removed when the connection is closed, so

Re: WebSocketServlet (and chat example) comments

2012-06-19 Thread Michael Roberts
Thanks, comments below. I'm going to address the chat example connection pruning in a separate mail. >> 1) In the createWebSocketInbound method implemented by the chat example's > >> subclass of WebSocketServlet, there is seemingly no way to interrogate > the > >> incoming request for information

[Bug 52135] Global error page is not handled

2012-06-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52135 Jens Borgland changed: What|Removed |Added CC||jens.borgl...@gmail.com -- You ar

[Bug 52135] Global error page is not handled

2012-06-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=52135 --- Comment #12 from Jens Borgland --- I think this would be a very good thing to have from a security perspective - makes it very easy to reduce the amount of error information that is disclosed by specifying one single error page that han

Re: WebSocketServlet (and chat example) comments

2012-06-19 Thread Michael Roberts
> > > >> 3) As mentioned, the chat example maintains a list of connections. > >> Connections (MessageInbound instances) are added to this list when > >> connections are established. However, they are never removed when the > >> connection is closed, so the list grows. The broadcast method silentl

[jira] [Commented] (MTOMCAT-60) Multiple-War-Deployment in configuration section.

2012-06-19 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396869#comment-13396869 ] Hudson commented on MTOMCAT-60: --- Integrated in TomcatMavenPlugin-mvn3.x #166 (See [https://

[jira] [Closed] (MTOMCAT-60) Multiple-War-Deployment in configuration section.

2012-06-19 Thread *$^¨%`£
[ https://issues.apache.org/jira/browse/MTOMCAT-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) closed MTOMCAT-60. - Resolution: Fixed Fix Version/s: 2.0 Assignee: Olivier Lamy (*$^¨%

svn commit: r1351742 - in /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run: AbstractRunMojo.java Webapp.java

2012-06-19 Thread olamy
Author: olamy Date: Tue Jun 19 15:31:50 2012 New Revision: 1351742 URL: http://svn.apache.org/viewvc?rev=1351742&view=rev Log: [MTOMCAT-60] Multiple-War-Deployment in configuration section. Patch for tomcat7 Submitted by Neale Upstone. Added: tomcat/maven-plugin/trunk/tomcat7-maven-plugin/sr

svn commit: r1351741 - in /tomcat/maven-plugin/trunk: common-tomcat-maven-plugin/src/main/java/org/apache/tomcat/maven/common/config/ tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/

2012-06-19 Thread olamy
Author: olamy Date: Tue Jun 19 15:31:34 2012 New Revision: 1351741 URL: http://svn.apache.org/viewvc?rev=1351741&view=rev Log: [MTOMCAT-60] Multiple-War-Deployment in configuration section. extract beans to reuse those with tomcat7 plugin. Submitted by Neale Upstone. Added: tomcat/maven-plug

[jira] [Commented] (MTOMCAT-162) SaxException when deploying multiple WARs

2012-06-19 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-162?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13396781#comment-13396781 ] Hudson commented on MTOMCAT-162: Integrated in TomcatMavenPlugin-mvn3.x #165 (See [https

[jira] [Closed] (MTOMCAT-162) SaxException when deploying multiple WARs

2012-06-19 Thread *$^¨%`£
[ https://issues.apache.org/jira/browse/MTOMCAT-162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) closed MTOMCAT-162. -- Resolution: Fixed Fix Version/s: 2.0 Thanks > SaxExcep

svn commit: r1351716 - /tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/run/RunMojo.java

2012-06-19 Thread olamy
Author: olamy Date: Tue Jun 19 13:54:34 2012 New Revision: 1351716 URL: http://svn.apache.org/viewvc?rev=1351716&view=rev Log: [MTOMCAT-162] for tomcat7 Submitted by Neale Upstone. Modified: tomcat/maven-plugin/trunk/tomcat7-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat7/r

svn commit: r1351715 - /tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/AbstractRunMojo.java

2012-06-19 Thread olamy
Author: olamy Date: Tue Jun 19 13:54:20 2012 New Revision: 1351715 URL: http://svn.apache.org/viewvc?rev=1351715&view=rev Log: manual skip win revert back logic to decide to run or not the tomcat instance Modified: tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomca

Re: svn commit: r1351368 - in /tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6: AbstractRunMojo.java Webapp.java

2012-06-19 Thread Olivier Lamy
I agree using skip must prevent running even if additional webapps have been added. I will change that 2012/6/19 Konstantin Kolinko : > 2012/6/18  : >> Author: olamy >> Date: Mon Jun 18 14:49:43 2012 >> New Revision: 1351368 >> >> URL: http://svn.apache.org/viewvc?rev=1351368&view=rev >> Log: >> [

Re: WebSocketServlet (and chat example) comments

2012-06-19 Thread Mark Thomas
On 19/06/2012 10:20, Mark Thomas wrote: > On 19/06/2012 06:16, Michael Roberts wrote: >> Hi, I have been playing with the web sockets support in 7.0.27. I have >> some comments and, as requested in the readme, am sending them to the dev >> list. > > Thanks. Much appreciated. > >> Caveat: it's be

Re: Plans for 6.0.36?

2012-06-19 Thread Mark Thomas
On 19/06/2012 14:03, Konstantin Kolinko wrote: > Hi! > > Previous version of Tomcat 6 was released in December 2011. > There are a number of changes already committed and a number of > nominations in the STATUS file. > > I think it is about time to start preparing for the next Tomcat 6.0 release.

Plans for 6.0.36?

2012-06-19 Thread Konstantin Kolinko
Hi! Previous version of Tomcat 6 was released in December 2011. There are a number of changes already committed and a number of nominations in the STATUS file. I think it is about time to start preparing for the next Tomcat 6.0 release. Best regards, Konstantin Kolinko

svn commit: r1351687 - /tomcat/tc6.0.x/trunk/STATUS.txt

2012-06-19 Thread kkolinko
Author: kkolinko Date: Tue Jun 19 12:53:00 2012 New Revision: 1351687 URL: http://svn.apache.org/viewvc?rev=1351687&view=rev Log: Replace stale StuckThreadDetectionValve proposal (the proposed patch is no longer available at github) with a new one. Modified: tomcat/tc6.0.x/trunk/STATUS.txt

[jira] [Updated] (MTOMCAT-60) Multiple-War-Deployment in configuration section.

2012-06-19 Thread Neale Upstone (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neale Upstone updated MTOMCAT-60: - Attachment: additionalwebapps-tomcat7-unproven.patch Added patch that applies same logic as for t

[jira] [Updated] (MTOMCAT-60) Multiple-War-Deployment in configuration section.

2012-06-19 Thread Neale Upstone (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neale Upstone updated MTOMCAT-60: - Attachment: extract-AbstractWebapp.patch Added patch that extracts AbstractWebapp for use for Tom

[Bug 50306] Detect stuck threads

2012-06-19 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50306 --- Comment #11 from Konstantin Kolinko --- Created attachment 28961 --> https://issues.apache.org/bugzilla/attachment.cgi?id=28961&action=edit 2012-06-19_tc6_50306_StuckThreadDetectionValve.patch Port of StuckThreadDetectionValve to Tom

[ANN] Apache Tomcat 7.0.28 released

2012-06-19 Thread Mark Thomas
The Apache Tomcat team announces the immediate availability of Apache Tomcat 7.0.28. Apache Tomcat is an open source software implementation of the Java Servlet and JavaServer Pages technologies. This release is includes may improvements as well as a number of bug fixes compared to version 7.0.27

svn commit: r1351678 - in /tomcat/site/trunk: docs/index.html xdocs/index.xml

2012-06-19 Thread markt
Author: markt Date: Tue Jun 19 12:38:22 2012 New Revision: 1351678 URL: http://svn.apache.org/viewvc?rev=1351678&view=rev Log: Fix typo Modified: tomcat/site/trunk/docs/index.html tomcat/site/trunk/xdocs/index.xml Modified: tomcat/site/trunk/docs/index.html URL: http://svn.apache.org/vi

svn commit: r1351656 - /tomcat/tc5.5.x/trunk/container/webapps/docs/config/realm.xml

2012-06-19 Thread kkolinko
Author: kkolinko Date: Tue Jun 19 11:27:25 2012 New Revision: 1351656 URL: http://svn.apache.org/viewvc?rev=1351656&view=rev Log: CTR: docs Change formatting of the Realm configuration reference. -> , so that they are listed in Table of contents. Modified: tomcat/tc5.5.x/trunk/container/weba

svn commit: r1351652 - in /tomcat/tc6.0.x/trunk: ./ webapps/docs/config/realm.xml

2012-06-19 Thread kkolinko
Author: kkolinko Date: Tue Jun 19 11:14:18 2012 New Revision: 1351652 URL: http://svn.apache.org/viewvc?rev=1351652&view=rev Log: CTR: docs Change formatting of the Realm configuration reference. -> , so that they are listed in Table of contents. It is merge of revisions 1351636-1351640 from tom

Re: svn commit: r1351637 - in /tomcat/site/trunk/xdocs: doap_Tomcat.rdf download-70.xml index.xml migration-7.xml oldnews.xml whichversion.xml

2012-06-19 Thread Mark Thomas
On 19/06/2012 11:37, Konstantin Kolinko wrote: > 2012/6/19 : >> Author: markt >> Date: Tue Jun 19 10:09:52 2012 >> New Revision: 1351637 >> >> URL: http://svn.apache.org/viewvc?rev=1351637&view=rev >> Log: >> Prep main site for 7.0.28 release >> >> Modified: >>tomcat/site/trunk/xdocs/doap_Tomc

svn commit: r1351650 - in /tomcat/site/trunk: docs/index.html xdocs/index.xml

2012-06-19 Thread markt
Author: markt Date: Tue Jun 19 10:49:13 2012 New Revision: 1351650 URL: http://svn.apache.org/viewvc?rev=1351650&view=rev Log: Tweak wording Modified: tomcat/site/trunk/docs/index.html tomcat/site/trunk/xdocs/index.xml Modified: tomcat/site/trunk/docs/index.html URL: http://svn.apache.o

Re: svn commit: r1351637 - in /tomcat/site/trunk/xdocs: doap_Tomcat.rdf download-70.xml index.xml migration-7.xml oldnews.xml whichversion.xml

2012-06-19 Thread Konstantin Kolinko
2012/6/19 : > Author: markt > Date: Tue Jun 19 10:09:52 2012 > New Revision: 1351637 > > URL: http://svn.apache.org/viewvc?rev=1351637&view=rev > Log: > Prep main site for 7.0.28 release > > Modified: >    tomcat/site/trunk/xdocs/doap_Tomcat.rdf >    tomcat/site/trunk/xdocs/download-70.xml >    to

svn commit: r1351642 - in /tomcat/site/trunk: ./ docs/tomcat-7.0-doc/ docs/tomcat-7.0-doc/api/ docs/tomcat-7.0-doc/api/org/apache/catalina/ docs/tomcat-7.0-doc/api/org/apache/catalina/ant/ docs/tomcat

2012-06-19 Thread markt
Author: markt Date: Tue Jun 19 10:27:58 2012 New Revision: 1351642 URL: http://svn.apache.org/viewvc?rev=1351642&view=rev Log: Update docs for 7.0.28 [This commit notification would consist of 60 parts, which exceeds the limit of 50 ones, so it was shortened to the summary.] --

svn commit: r1351643 - in /tomcat/tc7.0.x/trunk: ./ webapps/docs/changelog.xml webapps/docs/config/realm.xml

2012-06-19 Thread kkolinko
Author: kkolinko Date: Tue Jun 19 10:30:47 2012 New Revision: 1351643 URL: http://svn.apache.org/viewvc?rev=1351643&view=rev Log: Merged revisions r1351636 r1351640 from tomcat/trunk: Change formatting of the Realm configuration reference. -> , so that they are listed in Table of contents. Also

svn commit: r1351640 - /tomcat/trunk/webapps/docs/config/realm.xml

2012-06-19 Thread kkolinko
Author: kkolinko Date: Tue Jun 19 10:21:10 2012 New Revision: 1351640 URL: http://svn.apache.org/viewvc?rev=1351640&view=rev Log: Replace brackets with a dash in titles, aligning with listeners.xml This improves readability of TOC (see r1200937). Modified: tomcat/trunk/webapps/docs/config/rea

svn commit: r1351639 - in /tomcat/site/trunk/docs: doap_Tomcat.rdf download-70.html index.html migration-7.html oldnews.html whichversion.html

2012-06-19 Thread markt
Author: markt Date: Tue Jun 19 10:15:43 2012 New Revision: 1351639 URL: http://svn.apache.org/viewvc?rev=1351639&view=rev Log: Prep main site for 7.0.28 release - generated Modified: tomcat/site/trunk/docs/doap_Tomcat.rdf tomcat/site/trunk/docs/download-70.html tomcat/site/trunk/docs/

svn commit: r1351637 - in /tomcat/site/trunk/xdocs: doap_Tomcat.rdf download-70.xml index.xml migration-7.xml oldnews.xml whichversion.xml

2012-06-19 Thread markt
Author: markt Date: Tue Jun 19 10:09:52 2012 New Revision: 1351637 URL: http://svn.apache.org/viewvc?rev=1351637&view=rev Log: Prep main site for 7.0.28 release Modified: tomcat/site/trunk/xdocs/doap_Tomcat.rdf tomcat/site/trunk/xdocs/download-70.xml tomcat/site/trunk/xdocs/index.xml

svn commit: r1351636 - /tomcat/trunk/webapps/docs/config/realm.xml

2012-06-19 Thread kkolinko
Author: kkolinko Date: Tue Jun 19 10:07:12 2012 New Revision: 1351636 URL: http://svn.apache.org/viewvc?rev=1351636&view=rev Log: Change formatting of the Realm configuration reference. -> , so that they are listed in Table of contents. Modified: tomcat/trunk/webapps/docs/config/realm.xml M

svn commit: r1351631 - /tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml

2012-06-19 Thread markt
Author: markt Date: Tue Jun 19 09:58:04 2012 New Revision: 1351631 URL: http://svn.apache.org/viewvc?rev=1351631&view=rev Log: Add missing changelog tags Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc7.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apach

Re: WebSocketServlet (and chat example) comments

2012-06-19 Thread Mark Thomas
On 19/06/2012 06:16, Michael Roberts wrote: > Hi, I have been playing with the web sockets support in 7.0.27. I have > some comments and, as requested in the readme, am sending them to the dev > list. Thanks. Much appreciated. > Caveat: it's been a while since .27, so perhaps some of these issue

Re: svn commit: r1351375 - /tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/RunMojo.java

2012-06-19 Thread Olivier Lamy
good catch ! Fixed. Thanks -- Olivier 2012/6/19 Konstantin Kolinko : > 2012/6/18  : >> Author: olamy >> Date: Mon Jun 18 14:57:32 2012 >> New Revision: 1351375 >> >> URL: http://svn.apache.org/viewvc?rev=1351375&view=rev >> Log: >> [MTOMCAT-162] SaxException when deploying multiple WARs >> Submi

svn commit: r1351615 - /tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/RunMojo.java

2012-06-19 Thread olamy
Author: olamy Date: Tue Jun 19 09:14:45 2012 New Revision: 1351615 URL: http://svn.apache.org/viewvc?rev=1351615&view=rev Log: must not be final Modified: tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/RunMojo.java Modified: tomcat/maven

Re: svn commit: r1351368 - in /tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6: AbstractRunMojo.java Webapp.java

2012-06-19 Thread Konstantin Kolinko
2012/6/18 : > Author: olamy > Date: Mon Jun 18 14:49:43 2012 > New Revision: 1351368 > > URL: http://svn.apache.org/viewvc?rev=1351368&view=rev > Log: > [MTOMCAT-60] Multiple-War-Deployment in configuration section. > > Added: >     > tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/or

Re: svn commit: r1351375 - /tomcat/maven-plugin/trunk/tomcat6-maven-plugin/src/main/java/org/apache/tomcat/maven/plugin/tomcat6/RunMojo.java

2012-06-19 Thread Konstantin Kolinko
2012/6/18 : > Author: olamy > Date: Mon Jun 18 14:57:32 2012 > New Revision: 1351375 > > URL: http://svn.apache.org/viewvc?rev=1351375&view=rev > Log: > [MTOMCAT-162] SaxException when deploying multiple WARs > Submitted by Neale Upstone. > > Modified: >     > tomcat/maven-plugin/trunk/tomcat6-mav

svn commit: r1351607 - in /tomcat/tc7.0.x/trunk: ./ build.xml

2012-06-19 Thread kkolinko
Author: kkolinko Date: Tue Jun 19 08:50:54 2012 New Revision: 1351607 URL: http://svn.apache.org/viewvc?rev=1351607&view=rev Log: Merged revision 1351604 from tomcat/trunk: Fix Checkstyle exclusion pattern for MANIFEST file of jdbc-pool module. The file does not pass validation because of trailing

svn commit: r1351604 - /tomcat/trunk/build.xml

2012-06-19 Thread kkolinko
Author: kkolinko Date: Tue Jun 19 08:48:54 2012 New Revision: 1351604 URL: http://svn.apache.org/viewvc?rev=1351604&view=rev Log: Fix Checkstyle exclusion pattern for MNIFEST file of jdbc-pool module. The file does not pass validation because of trailing space characters on two lines, which are r

[jira] [Updated] (MTOMCAT-162) SaxException when deploying multiple WARs

2012-06-19 Thread Neale Upstone (JIRA)
[ https://issues.apache.org/jira/browse/MTOMCAT-162?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Neale Upstone updated MTOMCAT-162: -- Attachment: tomcat7-maven-plugin-MTOMCAT-162.patch Added patch to fix issue in tomcat7 plugin