svn commit: r1162283 - /tomcat/tc5.5.x/trunk/STATUS.txt

2011-08-26 Thread kkolinko
Author: kkolinko Date: Fri Aug 26 23:03:30 2011 New Revision: 1162283 URL: http://svn.apache.org/viewvc?rev=1162283&view=rev Log: simplify the vote. I think the updated Mark's patch addresses the concerns. Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt UR

svn commit: r1162282 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt

2011-08-26 Thread kkolinko
Author: kkolinko Date: Fri Aug 26 23:00:38 2011 New Revision: 1162282 URL: http://svn.apache.org/viewvc?rev=1162282&view=rev Log: Remove a point regarding MemoryProtocolHandler. 1. MemoryProtocolHandler#process() is not part of any interface. It is just a method. 2. We do not have callers for thi

svn commit: r1162281 - /tomcat/tc5.5.x/trunk/STATUS.txt

2011-08-26 Thread kkolinko
Author: kkolinko Date: Fri Aug 26 22:49:40 2011 New Revision: 1162281 URL: http://svn.apache.org/viewvc?rev=1162281&view=rev Log: Remove points. There is no i18n in org/apache/jk/**, so there is no much need to add it. In TC6 CoyoteAdapter does not log.info() as in 5.5, but log,error(), so let's

svn commit: r1162280 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-08-26 Thread kkolinko
Author: kkolinko Date: Fri Aug 26 22:46:53 2011 New Revision: 1162280 URL: http://svn.apache.org/viewvc?rev=1162280&view=rev Log: Remove a point. There is no i18n in org/apache/jk/** Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.o

Re: svn commit: r1157874 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java

2011-08-26 Thread Filip Hanik - Dev Lists
Thank you! On 8/26/2011 7:31 AM, Konstantin Kolinko wrote: 2011/8/25 Konstantin Kolinko: URL: http://svn.apache.org/viewvc?rev=1157874&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51583 1) I think that because of this change the " while (con != null) {" loop may run infi

DO NOT REPLY [Bug 51728] error parsing valid EL expression

2011-08-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51728 Konstantin Kolinko changed: What|Removed |Added Resolution|INVALID |DUPLICATE --- Comment #2 from

DO NOT REPLY [Bug 49217] Accepting java keyword in EL

2011-08-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49217 Konstantin Kolinko changed: What|Removed |Added CC||adolfo.benede...@gmail.com --

DO NOT REPLY [Bug 51728] error parsing valid EL expression

2011-08-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51728 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 51728] error parsing valid EL expression

2011-08-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51728 --- Comment #1 from Konstantin Kolinko 2011-08-26 21:56:49 UTC --- You have not provided the full error message (have you looked into the logs?) [[[ ... with root cause javax.el.ELException: The identifier [class] is not a valid Java iden

DO NOT REPLY [Bug 51728] error parsing valid EL expression

2011-08-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51728 Adolfo Benedetti changed: What|Removed |Added Platform|PC |Macintosh -- Configure bugmail

DO NOT REPLY [Bug 51728] New: error parsing valid EL expression

2011-08-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51728 Bug #: 51728 Summary: error parsing valid EL expression Product: Tomcat 7 Version: 7.0.20 Platform: PC OS/Version: Mac OS X 10.4 Status: NEW Severity: majo

DO NOT REPLY [Bug 51727] New: Manager deploy cannot be invoked without path parameter

2011-08-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51727 Bug #: 51727 Summary: Manager deploy cannot be invoked without path parameter Product: Tomcat 6 Version: unspecified Platform: All OS/Version: All

svn commit: r1162181 - /tomcat/tc5.5.x/trunk/STATUS.txt

2011-08-26 Thread kkolinko
Author: kkolinko Date: Fri Aug 26 17:39:23 2011 New Revision: 1162181 URL: http://svn.apache.org/viewvc?rev=1162181&view=rev Log: vote Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=11

DO NOT REPLY [Bug 51704] Dubious use of mkdirs() return code in juli FileHandler

2011-08-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51704 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1162172 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/core/ java/org/apache/catalina/loader/ java/org/apache/catalina/manager/ java/org/apache/catalina/manager/host/ java/org/ap

2011-08-26 Thread markt
Author: markt Date: Fri Aug 26 17:12:33 2011 New Revision: 1162172 URL: http://svn.apache.org/viewvc?rev=1162172&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51704 Make calls to File.mkdirs() more robust and handle errors in a few places where they were ignored and should

svn commit: r1162169 - in /tomcat/trunk: java/org/apache/catalina/core/ java/org/apache/catalina/loader/ java/org/apache/catalina/manager/ java/org/apache/catalina/manager/host/ java/org/apache/catali

2011-08-26 Thread markt
Author: markt Date: Fri Aug 26 17:08:17 2011 New Revision: 1162169 URL: http://svn.apache.org/viewvc?rev=1162169&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51704 Make calls to File.mkdirs() more robust and handle errors in a few places where they were ignored and should

Re: Possible bug in Tomcat Date header handling

2011-08-26 Thread Konstantin Kolinko
2011/8/26 Mick Sear : > I also think that looking at this code, if clocks go back at, say, 2am in > a given time zone, Tomcat will report 2am in an HTTP header continually > for 1 hour. > > Am I wrong? The header is in GMT. It does not matter what timezone your OS uses. [[[ static {

Re: Possible bug in Tomcat Date header handling

2011-08-26 Thread Mick Sear
I agree that a poorly configured system clock is not something Tomcat is responsible for, per se. However, there is a problem in the following code as I see it, which can be easily fixed by checking also for a negative number. This is a small fix that caters for people being dumb: /** * Get the

DO NOT REPLY [Bug 51682] j_spring_security_check action is not available

2011-08-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51682 Mark Thomas changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|

Re: Possible bug in Tomcat Date header handling

2011-08-26 Thread Christopher Schultz
Mark and Mick, On 8/26/2011 11:45 AM, Mark Thomas wrote: > The fix is to address the root cause which appears to be a poorly > configured system clock. I am loath to add a work-around at any point in > the Tomcat source code to handle time apparently going backwards rather > than forwards. +1 Th

DO NOT REPLY [Bug 51558] Tomcat Embedded: using tomcat.addWebapp always overrides programmatic context-settings with default values for the context at start of tomcat server

2011-08-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51558 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|

svn commit: r1162152 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/startup/Tomcat.java test/org/apache/catalina/startup/TestTomcat.java webapps/docs/changelog.xml

2011-08-26 Thread markt
Author: markt Date: Fri Aug 26 16:09:44 2011 New Revision: 1162152 URL: http://svn.apache.org/viewvc?rev=1162152&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51558 No need to force the use of the StandardManager with addWebapp() since StandardContext will add it if it is n

svn commit: r1162149 - in /tomcat/trunk: java/org/apache/catalina/startup/Tomcat.java test/org/apache/catalina/startup/TestTomcat.java

2011-08-26 Thread markt
Author: markt Date: Fri Aug 26 16:03:57 2011 New Revision: 1162149 URL: http://svn.apache.org/viewvc?rev=1162149&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51558 No need to force the use of the StandardManager with addWebapp() since StandardContext will add it if it is n

DO NOT REPLY [Bug 51726] New: configure reports "cannot remove `libtoolT': No such file or directory"

2011-08-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=51726 Bug #: 51726 Summary: configure reports "cannot remove `libtoolT': No such file or directory" Product: Tomcat Connectors Version: unspecified Platform: PC

Re: Possible bug in Tomcat Date header handling

2011-08-26 Thread Henri Gomez
> The fix is to address the root cause which appears to be a poorly > configured system clock. I am loath to add a work-around at any point in > the Tomcat source code to handle time apparently going backwards rather > than forwards. +1. It's SysAdmin team responsability to ensure hosting machine

Re: Possible bug in Tomcat Date header handling

2011-08-26 Thread Mark Thomas
On 26/08/2011 16:25, Mick Sear wrote: > > Tomcat 7.0.20 > Windows XP > JDK 1.6.0_20 > > I think there is a bug in Tomcat's handling of the Date HTTP header. I disagree. > When the system clock time is advanced and then put back, with an HTTP > request being handled in between those two actions,

Possible bug in Tomcat Date header handling

2011-08-26 Thread Mick Sear
Tomcat 7.0.20 Windows XP JDK 1.6.0_20 I think there is a bug in Tomcat's handling of the Date HTTP header. I'm mailing this list because there is a minor suggested code change at the bottom to fix. When the system clock time is advanced and then put back, with an HTTP request being handled in be

Re: svn commit: r1157874 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java

2011-08-26 Thread Konstantin Kolinko
2011/8/25 Konstantin Kolinko : >> URL: http://svn.apache.org/viewvc?rev=1157874&view=rev >> Log: >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51583 > > 1) I think that because of this change the " while (con != null) {" > loop may run infinitely, because when pool.size() is 0 the con >

svn commit: r1162111 - in /tomcat/tc7.0.x/trunk: modules/ webapps/docs/changelog.xml

2011-08-26 Thread kkolinko
Author: kkolinko Date: Fri Aug 26 13:22:30 2011 New Revision: 1162111 URL: http://svn.apache.org/viewvc?rev=1162111&view=rev Log: Update jdbc-pool to r1162102 to include the fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=51583 Modified: tomcat/tc7.0.x/trunk/modules/ (props chang

svn commit: r1162102 - /tomcat/trunk/modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java

2011-08-26 Thread kkolinko
Author: kkolinko Date: Fri Aug 26 13:07:16 2011 New Revision: 1162102 URL: http://svn.apache.org/viewvc?rev=1162102&view=rev Log: Followup for r1157874 which is a Fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=51583 Break loop immediately, because con is never set to null and you'll t

svn commit: r1162096 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt

2011-08-26 Thread kkolinko
Author: kkolinko Date: Fri Aug 26 12:54:47 2011 New Revision: 1162096 URL: http://svn.apache.org/viewvc?rev=1162096&view=rev Log: proposal Modified: tomcat/tc5.5.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewv

DO NOT REPLY [Bug 50394] InternalAprInputBuffer.fill() doesn't deal correctly with EOF

2011-08-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50394 --- Comment #8 from Konstantin Kolinko 2011-08-26 12:43:33 UTC --- Proposed the patches for Tomcat 6.0 and 5.5. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because:

svn commit: r1162091 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt

2011-08-26 Thread kkolinko
Author: kkolinko Date: Fri Aug 26 12:42:43 2011 New Revision: 1162091 URL: http://svn.apache.org/viewvc?rev=1162091&view=rev Log: proposal Modified: tomcat/tc5.5.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewv

DO NOT REPLY [Bug 50394] InternalAprInputBuffer.fill() doesn't deal correctly with EOF

2011-08-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50394 --- Comment #7 from Konstantin Kolinko 2011-08-26 12:34:10 UTC --- Created attachment 27438 --> https://issues.apache.org/bugzilla/attachment.cgi?id=27438 2011-08-26_tc6_50394_InternalAprInputBuffer.patch -- Configure bugmail: https://

DO NOT REPLY [Bug 50394] InternalAprInputBuffer.fill() doesn't deal correctly with EOF

2011-08-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50394 --- Comment #6 from Konstantin Kolinko 2011-08-26 12:33:39 UTC --- Created attachment 27437 --> https://issues.apache.org/bugzilla/attachment.cgi?id=27437 2011-08-26_tc55_50394_InternalAprInputBuffer.patch -- Configure bugmail: https:/

svn commit: r1162087 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/coyote/http11/InternalAprInputBuffer.java

2011-08-26 Thread kkolinko
Author: kkolinko Date: Fri Aug 26 12:27:52 2011 New Revision: 1162087 URL: http://svn.apache.org/viewvc?rev=1162087&view=rev Log: Backport r1162082 Make the fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=50394 done in r1148815 more explicit. No functional change. Modified: tomcat

svn commit: r1162082 - /tomcat/trunk/java/org/apache/coyote/http11/InternalAprInputBuffer.java

2011-08-26 Thread kkolinko
Author: kkolinko Date: Fri Aug 26 12:24:56 2011 New Revision: 1162082 URL: http://svn.apache.org/viewvc?rev=1162082&view=rev Log: Make the fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=50394 done in r1148815 more explicit. No functional change. Modified: tomcat/trunk/java/org/ap