Author: kkolinko
Date: Fri Aug 26 23:00:38 2011
New Revision: 1162282
URL: http://svn.apache.org/viewvc?rev=1162282&view=rev
Log:
Remove a point regarding MemoryProtocolHandler.
1. MemoryProtocolHandler#process() is not part of any interface. It is just a
method.
2. We do not have callers for this method, so it is hard to justify how it is
used.
3. The method is already declared with generic "throws Exception", so those
have to be handled. So the only missing point
is whether the caller handles other Throwables. It is justified to hope that it
handles them.
Modified:
tomcat/tc5.5.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc5.5.x/trunk/STATUS.txt?rev=1162282&r1=1162281&r2=1162282&view=diff
==============================================================================
--- tomcat/tc5.5.x/trunk/STATUS.txt (original)
+++ tomcat/tc5.5.x/trunk/STATUS.txt Fri Aug 26 23:00:38 2011
@@ -49,9 +49,6 @@ PATCHES PROPOSED TO BACKPORT:
markt: See reply to kkolinko above.
+1: kkolinko: OK with the updated patch.
- It seems though that
- 1) MemoryProtocolHandler#process() should now try/catch(Throwable).
- The MemoryProtocolHandler is created in Embedded.java line 424.
-1:
* Detect incomplete AJP messages and reject the associated request if one is
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1162282&r1=1162281&r2=1162282&view=diff
==============================================================================
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Fri Aug 26 23:00:38 2011
@@ -87,11 +87,7 @@ PATCHES PROPOSED TO BACKPORT:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=51550
Display error page rather than an empty response for an IllegalStateException
https://issues.apache.org/bugzilla/attachment.cgi?id=27434
- +1: markt
- +1: kkolinko
- It seems though that
- 1) MemoryProtocolHandler#process() should now try/catch(Throwable).
- The MemoryProtocolHandler is created in Embedded.java line 424.
+ +1: markt, kkolinko
-1:
* Fix two typos in tomcat.nsi (uppercase vs. lowercase in a macro call and in
a message)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
