svn commit: r1076067 - /tomcat/tc6.0.x/trunk/STATUS.txt

2011-03-01 Thread kkolinko
Author: kkolinko Date: Wed Mar 2 00:30:49 2011 New Revision: 1076067 URL: http://svn.apache.org/viewvc?rev=1076067&view=rev Log: proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?re

svn commit: r1076059 - in /tomcat/trunk: java/org/apache/catalina/startup/ClassLoaderFactory.java webapps/docs/changelog.xml

2011-03-01 Thread kkolinko
Author: kkolinko Date: Tue Mar 1 23:59:36 2011 New Revision: 1076059 URL: http://svn.apache.org/viewvc?rev=1076059&view=rev Log: Improve the fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48863 1) Be more strict when ignoring the warning: ignore only when it is the "lib" directory and

Re: svn commit: r1075175 - /tomcat/trunk/res/findbugs/filter-false-positives.xml

2011-03-01 Thread Konstantin Kolinko
2011/2/28 sebb : > On 27 February 2011 22:59,   wrote: >> Author: markt >> Date: Sun Feb 27 22:59:10 2011 >> New Revision: 1075175 >> >> URL: http://svn.apache.org/viewvc?rev=1075175&view=rev >> Log: >> Clear remaining FindBugs issues from javax.* >> >> Modified: >>    tomcat/trunk/res/findbugs/fil

svn commit: r1076047 - in /tomcat/trunk: java/org/apache/tomcat/util/net/SecureNioChannel.java res/findbugs/filter-false-positives.xml webapps/docs/changelog.xml

2011-03-01 Thread kkolinko
Author: kkolinko Date: Tue Mar 1 23:24:33 2011 New Revision: 1076047 URL: http://svn.apache.org/viewvc?rev=1076047&view=rev Log: Correct several typos Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SecureNioChannel.java tomcat/trunk/res/findbugs/filter-false-positives.xml tom

svn commit: r1076046 - in /tomcat: tc5.5.x/trunk/STATUS.txt tc6.0.x/trunk/STATUS.txt

2011-03-01 Thread kkolinko
Author: kkolinko Date: Tue Mar 1 23:20:56 2011 New Revision: 1076046 URL: http://svn.apache.org/viewvc?rev=1076046&view=rev Log: vote Modified: tomcat/tc5.5.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/to

DO NOT REPLY [Bug 49284] Implement SSL renegotiation for the NIO connector

2011-03-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49284 Filip Hanik changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|

svn commit: r1076015 - /tomcat/trunk/test/org/apache/tomcat/util/net/TestClientCert.java

2011-03-01 Thread fhanik
Author: fhanik Date: Tue Mar 1 20:34:00 2011 New Revision: 1076015 URL: http://svn.apache.org/viewvc?rev=1076015&view=rev Log: Make sure we also validate the content that is sent and received Modified: tomcat/trunk/test/org/apache/tomcat/util/net/TestClientCert.java Modified: tomcat/trunk/t

svn commit: r1076008 - in /tomcat/trunk: java/org/apache/coyote/http11/Http11NioProcessor.java test/org/apache/tomcat/util/net/TestClientCert.java

2011-03-01 Thread fhanik
Author: fhanik Date: Tue Mar 1 20:04:26 2011 New Revision: 1076008 URL: http://svn.apache.org/viewvc?rev=1076008&view=rev Log: Implement renegotiation for SSL cert authentication Modified: tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java tomcat/trunk/test/org/apache/tom

svn commit: r1076004 - /tomcat/trunk/java/org/apache/tomcat/util/net/SecureNioChannel.java

2011-03-01 Thread fhanik
Author: fhanik Date: Tue Mar 1 19:58:55 2011 New Revision: 1076004 URL: http://svn.apache.org/viewvc?rev=1076004&view=rev Log: Correctly determine if a buffer has data or not Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SecureNioChannel.java Modified: tomcat/trunk/java/org/apache/

DO NOT REPLY [Bug 49217] Accepting java keyword in EL

2011-03-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49217 Konstantin Kolinko changed: What|Removed |Added CC||eldar.kama...@db.com --- Comm

DO NOT REPLY [Bug 50850] Accepting java keyword in EL

2011-03-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50850 Konstantin Kolinko changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1075964 - /tomcat/trunk/java/org/apache/tomcat/util/net/SecureNioChannel.java

2011-03-01 Thread fhanik
Author: fhanik Date: Tue Mar 1 18:24:03 2011 New Revision: 1075964 URL: http://svn.apache.org/viewvc?rev=1075964&view=rev Log: propagate all exceptions through IOExceptions Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SecureNioChannel.java Modified: tomcat/trunk/java/org/apache/to

svn commit: r1075956 - /tomcat/trunk/java/org/apache/tomcat/util/net/SecureNioChannel.java

2011-03-01 Thread fhanik
Author: fhanik Date: Tue Mar 1 18:13:38 2011 New Revision: 1075956 URL: http://svn.apache.org/viewvc?rev=1075956&view=rev Log: Simple implementation of a forced and blocking renegotiation with a SSL client Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SecureNioChannel.java Modified

DO NOT REPLY [Bug 49217] Accepting java keyword in EL

2011-03-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49217 eldar.kama...@db.com changed: What|Removed |Added Blocks||50850 -- Configure bugmail:

DO NOT REPLY [Bug 50850] New: Accepting java keyword in EL

2011-03-01 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50850 Summary: Accepting java keyword in EL Product: Tomcat 7 Version: 7.0.4 Platform: PC OS/Version: Windows XP Status: NEW Severity: minor Priority: P2 C

Re: svn commit: r1074675 - in /tomcat/trunk: java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ webapps/docs/

2011-03-01 Thread Filip Hanik - Dev Lists
On 2/28/2011 5:27 PM, Mark Thomas wrote: On 01/03/2011 00:16, Filip Hanik - Dev Lists wrote: On 2/28/2011 4:49 PM, Mark Thomas wrote: It isn't clear to me if you are voting -1 on the above commit, and the following commits. r1074675 Understood and agree those commits are broken. I'll get thos

svn commit: r1075823 - /tomcat/trunk/test/org/apache/catalina/startup/TestTomcat.java

2011-03-01 Thread markt
Author: markt Date: Tue Mar 1 14:13:16 2011 New Revision: 1075823 URL: http://svn.apache.org/viewvc?rev=1075823&view=rev Log: Move outside of loop as per kkolinko's review Modified: tomcat/trunk/test/org/apache/catalina/startup/TestTomcat.java Modified: tomcat/trunk/test/org/apache/catalina

svn commit: r1075816 - /tomcat/trunk/test/org/apache/tomcat/util/net/TestCustomSsl.java

2011-03-01 Thread markt
Author: markt Date: Tue Mar 1 13:35:24 2011 New Revision: 1075816 URL: http://svn.apache.org/viewvc?rev=1075816&view=rev Log: Missed a keystore in the refactoring Modified: tomcat/trunk/test/org/apache/tomcat/util/net/TestCustomSsl.java Modified: tomcat/trunk/test/org/apache/tomcat/util/net

Re: svn commit: r1075719 - /tomcat/trunk/test/org/apache/catalina/startup/TestTomcat.java

2011-03-01 Thread Konstantin Kolinko
2011/3/1 : > Author: markt > Date: Tue Mar  1 09:00:01 2011 > New Revision: 1075719 > > URL: http://svn.apache.org/viewvc?rev=1075719&view=rev > Log: > Better fix, we actually need to read 20 byres for the test to pass > > Modified: >    tomcat/trunk/test/org/apache/catalina/startup/TestTomcat.jav

svn commit: r1075811 - /tomcat/trunk/test/org/apache/catalina/core/TestStandardContextResources.java

2011-03-01 Thread markt
Author: markt Date: Tue Mar 1 13:24:31 2011 New Revision: 1075811 URL: http://svn.apache.org/viewvc?rev=1075811&view=rev Log: Fix bug in unit test due to some Lifecycle refactoring Modified: tomcat/trunk/test/org/apache/catalina/core/TestStandardContextResources.java Modified: tomcat/trunk

svn commit: r1075792 - in /tomcat/trunk: java/org/apache/catalina/authenticator/SSLAuthenticator.java java/org/apache/coyote/http11/filters/BufferedInputFilter.java webapps/docs/changelog.xml

2011-03-01 Thread markt
Author: markt Date: Tue Mar 1 12:32:25 2011 New Revision: 1075792 URL: http://svn.apache.org/viewvc?rev=1075792&view=rev Log: Improve handling of SSL renegotiation by failing earlier when the request body contains more bytes than maxSavePostSize. Modified: tomcat/trunk/java/org/apache/catal

svn commit: r1075776 - in /tomcat/trunk/java/org/apache/tomcat/util/net: NioChannel.java SecureNioChannel.java

2011-03-01 Thread markt
Author: markt Date: Tue Mar 1 11:12:22 2011 New Revision: 1075776 URL: http://svn.apache.org/viewvc?rev=1075776&view=rev Log: Remove the init from references to handshake since the same fields/methods will be used for renegotiation Modified: tomcat/trunk/java/org/apache/tomcat/util/net/NioC

svn commit: r1075762 - in /tomcat/trunk/test/org/apache: catalina/startup/TomcatBaseTest.java tomcat/util/net/TestClientCert.java tomcat/util/net/TestSsl.java tomcat/util/net/TesterSupport.java

2011-03-01 Thread markt
Author: markt Date: Tue Mar 1 10:16:36 2011 New Revision: 1075762 URL: http://svn.apache.org/viewvc?rev=1075762&view=rev Log: Extract the client-cert tests into a separate test Check maxPostSize works as expected with client-cert Added: tomcat/trunk/test/org/apache/tomcat/util/net/TestClient

svn commit: r1075742 - in /tomcat/trunk: res/findbugs/filter-false-positives.xml test/org/apache/catalina/tribes/demos/CoordinationDemo.java test/org/apache/tomcat/util/net/TesterSupport.java

2011-03-01 Thread markt
Author: markt Date: Tue Mar 1 09:33:57 2011 New Revision: 1075742 URL: http://svn.apache.org/viewvc?rev=1075742&view=rev Log: Clear remainder of current FindBugs issues in unit tests Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml tomcat/trunk/test/org/apache/catalina/trib

svn commit: r1075737 - /tomcat/trunk/res/findbugs/filter-false-positives.xml

2011-03-01 Thread markt
Author: markt Date: Tue Mar 1 09:13:18 2011 New Revision: 1075737 URL: http://svn.apache.org/viewvc?rev=1075737&view=rev Log: More entries Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml Modified: tomcat/trunk/res/findbugs/filter-false-positives.xml URL: http://svn.apache.or

svn commit: r1075736 - /tomcat/trunk/test/org/apache/catalina/tribes/demos/MembersWithProperties.java

2011-03-01 Thread markt
Author: markt Date: Tue Mar 1 09:12:51 2011 New Revision: 1075736 URL: http://svn.apache.org/viewvc?rev=1075736&view=rev Log: Remove unused code Modified: tomcat/trunk/test/org/apache/catalina/tribes/demos/MembersWithProperties.java Modified: tomcat/trunk/test/org/apache/catalina/tribes/d

svn commit: r1075725 - /tomcat/trunk/test/org/apache/catalina/startup/TestTomcatClassLoader.java

2011-03-01 Thread markt
Author: markt Date: Tue Mar 1 09:02:52 2011 New Revision: 1075725 URL: http://svn.apache.org/viewvc?rev=1075725&view=rev Log: Fix Findbugs nag Reduce visibility Modified: tomcat/trunk/test/org/apache/catalina/startup/TestTomcatClassLoader.java Modified: tomcat/trunk/test/org/apache/catalin

svn commit: r1075724 - /tomcat/trunk/test/org/apache/catalina/startup/TestTomcat.java

2011-03-01 Thread markt
Author: markt Date: Tue Mar 1 09:01:30 2011 New Revision: 1075724 URL: http://svn.apache.org/viewvc?rev=1075724&view=rev Log: Grr. This worked if 20 bytes were read in one go Modified: tomcat/trunk/test/org/apache/catalina/startup/TestTomcat.java Modified: tomcat/trunk/test/org/apache/catal

svn commit: r1075719 - /tomcat/trunk/test/org/apache/catalina/startup/TestTomcat.java

2011-03-01 Thread markt
Author: markt Date: Tue Mar 1 09:00:01 2011 New Revision: 1075719 URL: http://svn.apache.org/viewvc?rev=1075719&view=rev Log: Better fix, we actually need to read 20 byres for the test to pass Modified: tomcat/trunk/test/org/apache/catalina/startup/TestTomcat.java Modified: tomcat/trunk/tes

svn commit: r1075718 - /tomcat/trunk/test/org/apache/catalina/startup/TestTomcat.java

2011-03-01 Thread markt
Author: markt Date: Tue Mar 1 08:56:48 2011 New Revision: 1075718 URL: http://svn.apache.org/viewvc?rev=1075718&view=rev Log: Fix FindBugs warning Modified: tomcat/trunk/test/org/apache/catalina/startup/TestTomcat.java Modified: tomcat/trunk/test/org/apache/catalina/startup/TestTomcat.java

svn commit: r1075713 - /tomcat/trunk/test/org/apache/catalina/servlets/TestDefaultServlet.java

2011-03-01 Thread markt
Author: markt Date: Tue Mar 1 08:50:40 2011 New Revision: 1075713 URL: http://svn.apache.org/viewvc?rev=1075713&view=rev Log: More explicit failure message - fixed FindBugs nags Modified: tomcat/trunk/test/org/apache/catalina/servlets/TestDefaultServlet.java Modified: tomcat/trunk/test/org/

svn commit: r1075708 - /tomcat/trunk/test/org/apache/el/lang/TestELArithmetic.java

2011-03-01 Thread markt
Author: markt Date: Tue Mar 1 08:44:29 2011 New Revision: 1075708 URL: http://svn.apache.org/viewvc?rev=1075708&view=rev Log: FindBugs fixes - make constants static Modified: tomcat/trunk/test/org/apache/el/lang/TestELArithmetic.java Modified: tomcat/trunk/test/org/apache/el/lang/TestELArit

svn commit: r1075699 - /tomcat/trunk/test/org/apache/tomcat/util/net/TestSsl.java

2011-03-01 Thread markt
Author: markt Date: Tue Mar 1 08:36:57 2011 New Revision: 1075699 URL: http://svn.apache.org/viewvc?rev=1075699&view=rev Log: Comment tweaks Modified: tomcat/trunk/test/org/apache/tomcat/util/net/TestSsl.java Modified: tomcat/trunk/test/org/apache/tomcat/util/net/TestSsl.java URL: http://s