Author: markt
Date: Tue Mar  1 08:50:40 2011
New Revision: 1075713

URL: http://svn.apache.org/viewvc?rev=1075713&view=rev
Log:
More explicit failure message - fixed FindBugs nags

Modified:
    tomcat/trunk/test/org/apache/catalina/servlets/TestDefaultServlet.java

Modified: tomcat/trunk/test/org/apache/catalina/servlets/TestDefaultServlet.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/servlets/TestDefaultServlet.java?rev=1075713&r1=1075712&r2=1075713&view=diff
==============================================================================
--- tomcat/trunk/test/org/apache/catalina/servlets/TestDefaultServlet.java 
(original)
+++ tomcat/trunk/test/org/apache/catalina/servlets/TestDefaultServlet.java Tue 
Mar  1 08:50:40 2011
@@ -153,7 +153,10 @@ public class TestDefaultServlet extends 
      */
     public void testCustomErrorPage() throws Exception {
         File appDir = new File(getTemporaryDirectory(), "MyApp");
-        new File(appDir, "WEB-INF").mkdirs();
+        File webInf = new File(appDir, "WEB-INF");
+        if (!webInf.mkdirs()) {
+            fail("Unable to create directory [" + webInf + "]");
+        }
         Writer w = new OutputStreamWriter(new FileOutputStream(new File(appDir,
                 "WEB-INF/web.xml")), "UTF-8");
         try {
@@ -234,7 +237,10 @@ public class TestDefaultServlet extends 
      */
     public void testCustomErrorPageMissing() throws Exception {
         File appDir = new File(getTemporaryDirectory(), "MyApp");
-        new File(appDir, "WEB-INF").mkdirs();
+        File webInf = new File(appDir, "WEB-INF");
+        if (!webInf.mkdirs()) {
+            fail("Unable to create directory [" + webInf + "]");
+        }
         Writer w = new OutputStreamWriter(new FileOutputStream(new File(appDir,
                 "WEB-INF/web.xml")), "UTF-8");
         try {



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to