+1
2011/1/24 Jeremy Boynes
> The only bug remaining that impact the JSTL libraries is #46052 (locale
> performance on 1.6). Henri suggested releasing in its current form which
> sounds reasonable. Should we release this as 1.2.0? Is this a good version
> number - should we use something like 1.2
Author: markt
Date: Tue Mar 1 01:23:31 2011
New Revision: 1075606
URL: http://svn.apache.org/viewvc?rev=1075606&view=rev
Log:
Revert SSL renegotiation for NIO - implementation is broken
Reverts r1074675 and r1075030
Modified:
tomcat/trunk/java/org/apache/coyote/http11/Http11NioProcessor.java
Author: markt
Date: Tue Mar 1 01:15:11 2011
New Revision: 1075604
URL: http://svn.apache.org/viewvc?rev=1075604&view=rev
Log:
Start of an SSL re-negotiation test. Need to expand it to handle request bodies
and the other issues highlighted by Filip.
Switch to using a CA since it makes the code cl
On 01/03/2011 00:16, Filip Hanik - Dev Lists wrote:
> On 2/28/2011 4:49 PM, Mark Thomas wrote:
>> It isn't clear to me if you are voting -1
> on the above commit, and the following commits. r1074675
Understood and agree those commits are broken. I'll get those backed out
shortly.
> If you wish to
On 2/28/2011 4:49 PM, Mark Thomas wrote:
It isn't clear to me if you are voting -1
on the above commit, and the following commits. r1074675
If you wish to do this, it should at least include:
1. input filters need to check if they retrieved the entire body
if only partial, why even attempt a re
On 28/02/2011 22:50, Filip Hanik - Dev Lists wrote:
> Ok, I've done some research. My conclusion is that I'm -1 for this change.
> My suggestion on the other thread, that we should simply throw an
> exception if the server is not configured to handle client-auth in the
> connector still stands.
>
Ok, I've done some research. My conclusion is that I'm -1 for this change.
My suggestion on the other thread, that we should simply throw an exception if the server is not configured to handle client-auth in the
connector still stands.
Let me explain why:
1. The idea behind this code was that
On 2/28/2011 12:00 PM, Mark Thomas wrote:
On 28/02/2011 18:45, Filip Hanik - Dev Lists wrote:
On 2/28/2011 11:30 AM, Mark Thomas wrote:
On 28/02/2011 18:11, Filip Hanik - Dev Lists wrote:
[X] Broken - do not release
http://svn.apache.org/viewvc?rev=1075030&view=rev
http://svn.apache.org/viewv
Author: markt
Date: Mon Feb 28 19:03:31 2011
New Revision: 1075487
URL: http://svn.apache.org/viewvc?rev=1075487&view=rev
Log:
Should have moved the keys when I moved the SSL tests
Added:
tomcat/trunk/test/org/apache/tomcat/util/net/test-cert.pem
- copied unchanged from r1075461,
tomca
On 28/02/2011 18:45, Filip Hanik - Dev Lists wrote:
> On 2/28/2011 11:30 AM, Mark Thomas wrote:
>> On 28/02/2011 18:11, Filip Hanik - Dev Lists wrote:
>>> [X] Broken - do not release
>>>
>>> http://svn.apache.org/viewvc?rev=1075030&view=rev
>>> http://svn.apache.org/viewvc?rev=1074675&view=rev
>>>
On 2/28/2011 11:30 AM, Mark Thomas wrote:
On 28/02/2011 18:11, Filip Hanik - Dev Lists wrote:
[X] Broken - do not release
http://svn.apache.org/viewvc?rev=1075030&view=rev
http://svn.apache.org/viewvc?rev=1074675&view=rev
Are not completely correct implementations as they don't
- support a tim
Author: markt
Date: Mon Feb 28 18:43:44 2011
New Revision: 1075474
URL: http://svn.apache.org/viewvc?rev=1075474&view=rev
Log:
Fix an Eclipse nag
Modified:
tomcat/trunk/java/org/apache/tomcat/util/net/SecureNioChannel.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/SecureNioChann
Just a little bit more on this.
I'm not seeing where SSLAuthenticator.java validates that the request came in
on a SSL connection, and what if the SSL cert came from mod_jk.
I'm not sure what the requirements for CERT authentication is, but if it is that the cert MUST be validated against a trust
On 28/02/2011 18:11, Filip Hanik - Dev Lists wrote:
> [X] Broken - do not release
Cancelled. The lack of a timeout in the NIO SSL handshake is a show stopper.
Mark
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For
On 28/02/2011 18:11, Filip Hanik - Dev Lists wrote:
> [X] Broken - do not release
>
> http://svn.apache.org/viewvc?rev=1075030&view=rev
> http://svn.apache.org/viewvc?rev=1074675&view=rev
>
> Are not completely correct implementations as they don't
> - support a timeout correctly
That is an issue
https://issues.apache.org/bugzilla/show_bug.cgi?id=28852
Mark Thomas changed:
What|Removed |Added
Component|Webapps:Manager |Catalina
Version|4.1.30
Author: markt
Date: Mon Feb 28 18:21:00 2011
New Revision: 1075462
URL: http://svn.apache.org/viewvc?rev=1075462&view=rev
Log:
Proposal
Modified:
tomcat/tc5.5.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc5.5.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/t
Author: markt
Date: Mon Feb 28 18:15:48 2011
New Revision: 1075458
URL: http://svn.apache.org/viewvc?rev=1075458&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=28852
Add URL encoding where missing to parameters in URLs presented by Ant tasks to
the Manager application.
Based
https://issues.apache.org/bugzilla/show_bug.cgi?id=49284
Filip Hanik changed:
What|Removed |Added
Status|RESOLVED|REOPENED
Resolution|FIXED
[X] Broken - do not release
http://svn.apache.org/viewvc?rev=1075030&view=rev
http://svn.apache.org/viewvc?rev=1074675&view=rev
Are not completely correct implementations as they don't
- support a timeout correctly
- dont account for when a write is needed on the selector
- they potentially garb
On 2/27/2011 4:30 AM, Mark Thomas wrote:
On 25/02/2011 20:16, Filip Hanik - Dev Lists wrote:
The simplest solution is, would be to use an individual selector.
Register the socket and issue a select() on the thread you are running on.
If you want to use a shared selector (like NIO does for reads
Author: markt
Date: Mon Feb 28 17:24:00 2011
New Revision: 1075435
URL: http://svn.apache.org/viewvc?rev=1075435&view=rev
Log:
Clarify auth process for CLIENT-CERT
Modified:
tomcat/trunk/java/org/apache/catalina/authenticator/SSLAuthenticator.java
Modified:
tomcat/trunk/java/org/apache/cata
The proposed Apache Tomcat 7.0.9 release is now available for voting.
It can be obtained from:
http://people.apache.org/~markt/dev/tomcat-7/v7.0.9/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_9/
The proposed 7.0.9 release is:
[ ] Broken - do not release
[ ] Alp
Author: markt
Date: Mon Feb 28 14:14:41 2011
New Revision: 1075338
URL: http://svn.apache.org/viewvc?rev=1075338&view=rev
Log:
Prep for next release
Modified:
tomcat/trunk/build.properties.default
Modified: tomcat/trunk/build.properties.default
URL:
http://svn.apache.org/viewvc/tomcat/trunk
Author: markt
Date: Mon Feb 28 14:13:37 2011
New Revision: 1075337
URL: http://svn.apache.org/viewvc?rev=1075337&view=rev
Log:
Tag 7.0.9
Added:
tomcat/tc7.0.x/tags/TOMCAT_7_0_9/ (props changed)
- copied from r1075336, tomcat/trunk/
Removed:
tomcat/tc7.0.x/tags/TOMCAT_7_0_9/modules
https://issues.apache.org/bugzilla/show_bug.cgi?id=48863
--- Comment #8 from Mark Thomas 2011-02-28 08:51:34 EST ---
Thanks for the review. Patch updated in 7.0.x for 7.0.9 and proposal for 6.0.x
also updated.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
Author: markt
Date: Mon Feb 28 13:51:09 2011
New Revision: 1075326
URL: http://svn.apache.org/viewvc?rev=1075326&view=rev
Log:
Update patch
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?r
Author: markt
Date: Mon Feb 28 13:35:41 2011
New Revision: 1075320
URL: http://svn.apache.org/viewvc?rev=1075320&view=rev
Log:
Improve fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=48863
- consistently pass absolute paths to validateFile()
- handle non-absolute catalina home/base
Mod
28 matches
Mail list logo
