On 28/02/2011 18:11, Filip Hanik - Dev Lists wrote:
> [X] Broken - do not release
> 
> http://svn.apache.org/viewvc?rev=1075030&view=rev
> http://svn.apache.org/viewvc?rev=1074675&view=rev
> 
> Are not completely correct implementations as they don't
> - support a timeout correctly
That is an issue. Should be a relatively easy fix.

> - dont account for when a write is needed on the selector
I can't figure out what circumstances the handshake process would return
OP_WRITE since it shouldn't ever be waiting for some other process to
write data. Could you explain how this might happen?

> - they potentially garble a message body larger than the limit of the
> input buffer
This should be handled by the existing code although I didn't test it.
Should be easy to write a unit test to confirm what happens in this case.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Reply via email to