svn commit: r1059409 - in /tomcat/trunk: java/org/apache/catalina/filters/RequestFilter.java webapps/docs/changelog.xml

2011-01-15 Thread kkolinko
Author: kkolinko Date: Sat Jan 15 20:33:06 2011 New Revision: 1059409 URL: http://svn.apache.org/viewvc?rev=1059409&view=rev Log: Correct a typo in RequestFilter, that would lead to an NPE in RemoteAddrFilter, RemoteHostFilter when "allow" attribute is empty. The RequestFilterValve class is not a

svn commit: r1059404 - in /tomcat/trunk: java/org/apache/coyote/http11/AbstractHttp11Processor.java java/org/apache/coyote/http11/AbstractHttp11Protocol.java webapps/docs/config/http.xml

2011-01-15 Thread kkolinko
Author: kkolinko Date: Sat Jan 15 19:53:47 2011 New Revision: 1059404 URL: http://svn.apache.org/viewvc?rev=1059404&view=rev Log: Update documentation for restrictedUserAgents, noCompressionUserAgents attributes of HTTP connectors, because they now use a single regex. Modified: tomcat/trunk/

Re: Access log changes in 7.0.6

2011-01-15 Thread Mark Thomas
On 14/01/2011 15:20, Konstantin Kolinko wrote: > The valve already implements AccessLog interface. > If we can turn AccessLogValve#invoke() into noop (pass-through) and > let the connector to provide us with logging via the #log(..) method, > I think that won't break compatibility. Neat. I have a

DO NOT REPLY [Bug 50583] Standard error pages (e.g.404) do not work if AccessLogValve is configured on webapp

2011-01-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50583 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 50582] Small JSPs do not set Content-Length (and use chunked encoding) if AccessLogValve is configured

2011-01-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50582 --- Comment #3 from Mark Thomas 2011-01-15 14:35:18 EST --- *** Bug 50583 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail

svn commit: r1059398 - in /tomcat/trunk: java/org/apache/catalina/filters/ java/org/apache/catalina/valves/ test/org/apache/catalina/filters/ webapps/docs/config/

2011-01-15 Thread kkolinko
Author: kkolinko Date: Sat Jan 15 19:33:06 2011 New Revision: 1059398 URL: http://svn.apache.org/viewvc?rev=1059398&view=rev Log: Update JMX descriptions, tests, documentation and examples in documentation for using a single regex for attributes in RemoteIpFilter, RemoteIpValve. Modified: to

svn commit: r1059390 - in /tomcat/trunk/webapps/docs/config: context.xml engine.xml filter.xml host.xml valve.xml

2011-01-15 Thread kkolinko
Author: kkolinko Date: Sat Jan 15 18:54:46 2011 New Revision: 1059390 URL: http://svn.apache.org/viewvc?rev=1059390&view=rev Log: Update examples for RemoveAddrValve, RemoteHostValve in the docs Modified: tomcat/trunk/webapps/docs/config/context.xml tomcat/trunk/webapps/docs/config/engine

svn commit: r1059388 - in /tomcat/trunk/java/org/apache/catalina/valves: AccessLogValve.java ExtendedAccessLogValve.java JDBCAccessLogValve.java LocalStrings.properties

2011-01-15 Thread markt
Author: markt Date: Sat Jan 15 18:50:45 2011 New Revision: 1059388 URL: http://svn.apache.org/viewvc?rev=1059388&view=rev Log: Fix FindBugs warnings Modified: tomcat/trunk/java/org/apache/catalina/valves/AccessLogValve.java tomcat/trunk/java/org/apache/catalina/valves/ExtendedAccessLogVal

svn commit: r1059384 - in /tomcat/site/trunk: docs/migration.html xdocs/migration.xml

2011-01-15 Thread kkolinko
Author: kkolinko Date: Sat Jan 15 18:26:43 2011 New Revision: 1059384 URL: http://svn.apache.org/viewvc?rev=1059384&view=rev Log: List configuration options that now accept a single regex - see r1055923 Modified: tomcat/site/trunk/docs/migration.html tomcat/site/trunk/xdocs/migration.xml

DO NOT REPLY [Bug 50591] NPE in ReplicationValve in 7.0.6

2011-01-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50591 Konstantin Kolinko changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1059379 - in /tomcat/trunk: java/org/apache/catalina/ha/tcp/ReplicationValve.java webapps/docs/changelog.xml

2011-01-15 Thread kkolinko
Author: kkolinko Date: Sat Jan 15 17:43:46 2011 New Revision: 1059379 URL: http://svn.apache.org/viewvc?rev=1059379&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50591 Do not throw NullPointerException when ReplicationValve#filter is not set. Modified: tomcat/trunk/java

DO NOT REPLY [Bug 50591] New: NPE in ReplicationValve in 7.0.6

2011-01-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50591 Summary: NPE in ReplicationValve in 7.0.6 Product: Tomcat 7 Version: 7.0.6 Platform: PC OS/Version: Windows XP Status: NEW Severity: regression Priority: P2

svn commit: r1059375 - in /tomcat/trunk/webapps/docs: cluster-howto.xml config/cluster-valve.xml

2011-01-15 Thread kkolinko
Author: kkolinko Date: Sat Jan 15 17:26:58 2011 New Revision: 1059375 URL: http://svn.apache.org/viewvc?rev=1059375&view=rev Log: Updated ReplicationValve examples in the docs with the new regexp syntax. Added *.jpeg pattern to the list, as inspired by the comment in BZ 31912 https://issues.apache

Re: svn commit: r1059366 - /tomcat/trunk/java/org/apache/catalina/tribes/membership/McastServiceImpl.java

2011-01-15 Thread Konstantin Kolinko
2011/1/15 Mark Thomas : > On 15/01/2011 16:33, ma...@apache.org wrote: >> Author: markt >> Date: Sat Jan 15 16:33:05 2011 >> New Revision: 1059366 >> >> URL: http://svn.apache.org/viewvc?rev=1059366&view=rev >> Log: >> Refactor to make clearer what is going on > > Hopefully this is clearer. > >> @@

svn commit: r1059372 - /tomcat/trunk/webapps/docs/changelog.xml

2011-01-15 Thread markt
Author: markt Date: Sat Jan 15 16:47:38 2011 New Revision: 1059372 URL: http://svn.apache.org/viewvc?rev=1059372&view=rev Log: Update changelog Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/

Re: svn commit: r1059366 - /tomcat/trunk/java/org/apache/catalina/tribes/membership/McastServiceImpl.java

2011-01-15 Thread Mark Thomas
On 15/01/2011 16:33, ma...@apache.org wrote: > Author: markt > Date: Sat Jan 15 16:33:05 2011 > New Revision: 1059366 > > URL: http://svn.apache.org/viewvc?rev=1059366&view=rev > Log: > Refactor to make clearer what is going on Hopefully this is clearer. > @@ -585,22 +585,27 @@ public class Mcas

svn commit: r1059366 - /tomcat/trunk/java/org/apache/catalina/tribes/membership/McastServiceImpl.java

2011-01-15 Thread markt
Author: markt Date: Sat Jan 15 16:33:05 2011 New Revision: 1059366 URL: http://svn.apache.org/viewvc?rev=1059366&view=rev Log: Refactor to make clearer what is going on Modified: tomcat/trunk/java/org/apache/catalina/tribes/membership/McastServiceImpl.java Modified: tomcat/trunk/java/org/a

Re: svn commit: r1059346 - in /tomcat/trunk: java/org/apache/catalina/tribes/membership/McastServiceImpl.java webapps/docs/changelog.xml webapps/docs/config/cluster-membership.xml

2011-01-15 Thread Mark Thomas
On 15/01/2011 15:38, Konstantin Kolinko wrote: > 2011/1/15 Mark Thomas : >> On 15/01/2011 14:47, ma...@apache.org wrote: >>> Author: markt >>> Date: Sat Jan 15 14:47:07 2011 >>> New Revision: 1059346 >>> >>> URL: http://svn.apache.org/viewvc?rev=1059346&view=rev >>> Log: >>> Fix broken cluster memb

Re: svn commit: r1059346 - in /tomcat/trunk: java/org/apache/catalina/tribes/membership/McastServiceImpl.java webapps/docs/changelog.xml webapps/docs/config/cluster-membership.xml

2011-01-15 Thread Konstantin Kolinko
2011/1/15 Mark Thomas : > On 15/01/2011 14:47, ma...@apache.org wrote: >> Author: markt >> Date: Sat Jan 15 14:47:07 2011 >> New Revision: 1059346 >> >> URL: http://svn.apache.org/viewvc?rev=1059346&view=rev >> Log: >> Fix broken cluster membership recovery > > Just for info, I never would have com

Re: svn commit: r1059346 - in /tomcat/trunk: java/org/apache/catalina/tribes/membership/McastServiceImpl.java webapps/docs/changelog.xml webapps/docs/config/cluster-membership.xml

2011-01-15 Thread Mark Thomas
On 15/01/2011 14:47, ma...@apache.org wrote: > Author: markt > Date: Sat Jan 15 14:47:07 2011 > New Revision: 1059346 > > URL: http://svn.apache.org/viewvc?rev=1059346&view=rev > Log: > Fix broken cluster membership recovery Just for info, I never would have come across this if I hadn't been work

svn commit: r1059346 - in /tomcat/trunk: java/org/apache/catalina/tribes/membership/McastServiceImpl.java webapps/docs/changelog.xml webapps/docs/config/cluster-membership.xml

2011-01-15 Thread markt
Author: markt Date: Sat Jan 15 14:47:07 2011 New Revision: 1059346 URL: http://svn.apache.org/viewvc?rev=1059346&view=rev Log: Fix broken cluster membership recovery Modified: tomcat/trunk/java/org/apache/catalina/tribes/membership/McastServiceImpl.java tomcat/trunk/webapps/docs/changelo

svn commit: r1059342 - in /tomcat/trunk: java/org/apache/catalina/tribes/group/interceptors/ java/org/apache/catalina/tribes/membership/ java/org/apache/catalina/tribes/transport/bio/ res/findbugs/

2011-01-15 Thread markt
Author: markt Date: Sat Jan 15 14:36:01 2011 New Revision: 1059342 URL: http://svn.apache.org/viewvc?rev=1059342&view=rev Log: Fix FindBugs and Eclipse warnings Remove out-dated comments Modified: tomcat/trunk/java/org/apache/catalina/tribes/group/interceptors/TcpFailureDetector.java to

svn commit: r1059337 - in /tomcat/trunk/java/org/apache/catalina/ha/deploy: FarmWarDeployer.java FileMessageFactory.java LocalStrings.properties

2011-01-15 Thread markt
Author: markt Date: Sat Jan 15 14:00:20 2011 New Revision: 1059337 URL: http://svn.apache.org/viewvc?rev=1059337&view=rev Log: Fix FindBugs warnings Modified: tomcat/trunk/java/org/apache/catalina/ha/deploy/FarmWarDeployer.java tomcat/trunk/java/org/apache/catalina/ha/deploy/FileMessageFa

svn commit: r1059330 - /tomcat/trunk/java/org/apache/catalina/manager/JMXProxyServlet.java

2011-01-15 Thread markt
Author: markt Date: Sat Jan 15 13:53:06 2011 New Revision: 1059330 URL: http://svn.apache.org/viewvc?rev=1059330&view=rev Log: Fix FindBugs and Eclipse warnings Modified: tomcat/trunk/java/org/apache/catalina/manager/JMXProxyServlet.java Modified: tomcat/trunk/java/org/apache/catalina/manage

svn commit: r1059322 - in /tomcat/trunk: java/org/apache/tomcat/util/buf/MessageBytes.java java/org/apache/tomcat/util/digester/Digester.java res/findbugs/filter-false-positives.xml webapps/docs/chang

2011-01-15 Thread markt
Author: markt Date: Sat Jan 15 13:42:01 2011 New Revision: 1059322 URL: http://svn.apache.org/viewvc?rev=1059322&view=rev Log: Remove unused code Fix FindBugs and Eclipse warnings Correct typos Modified: tomcat/trunk/java/org/apache/tomcat/util/buf/MessageBytes.java tomcat/trunk/java/org/

Re: svn commit: r1059280 - in /tomcat/trunk/webapps/docs: changelog.xml config/context.xml

2011-01-15 Thread Pid
On 1/15/11 11:12 AM, sebb wrote: >> + The version component is treated as a String both for >> > + performance reasons and to allow flexability in versioning schemes. >> > String >> > + comparissions are used to determine version order. Therefore > s/comparissions/comparisons/ > s/flexability

Re: svn commit: r1059280 - in /tomcat/trunk/webapps/docs: changelog.xml config/context.xml

2011-01-15 Thread sebb
On 15 January 2011 10:11, wrote: > Author: markt > Date: Sat Jan 15 10:11:55 2011 > New Revision: 1059280 > > URL: http://svn.apache.org/viewvc?rev=1059280&view=rev > Log: > Additional docs on version ordering > Add 7.0.6 release date > > Modified: >    tomcat/trunk/webapps/docs/changelog.xml >  

svn commit: r1059280 - in /tomcat/trunk/webapps/docs: changelog.xml config/context.xml

2011-01-15 Thread markt
Author: markt Date: Sat Jan 15 10:11:55 2011 New Revision: 1059280 URL: http://svn.apache.org/viewvc?rev=1059280&view=rev Log: Additional docs on version ordering Add 7.0.6 release date Modified: tomcat/trunk/webapps/docs/changelog.xml tomcat/trunk/webapps/docs/config/context.xml Modifie