Re: svn commit: r1041120 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ tes

2010-12-02 Thread Mladen Turk
On 12/03/2010 07:43 AM, Konstantin Kolinko wrote: 2010/12/3 Mladen Turk: Think that single eg. EndpointState enum will cover all the states during start(),pause(),resume(),stop() replacing multiple booleans (at least running and paused) with a single enum. WDTYT? It makes sense for me. Tho

Re: svn commit: r1041120 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ tes

2010-12-02 Thread Konstantin Kolinko
2010/12/3 Mladen Turk : > On 12/01/2010 07:37 PM, ma...@apache.org wrote: >> >> Author: markt >> Date: Wed Dec  1 18:37:29 2010 >> New Revision: 1041120 >> >> URL: http://svn.apache.org/viewvc?rev=1041120&view=rev >> Log: >> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50360 >> Bind/relea

Re: svn commit: r1041120 - in /tomcat/trunk: java/org/apache/catalina/connector/ java/org/apache/coyote/ java/org/apache/coyote/ajp/ java/org/apache/coyote/http11/ java/org/apache/tomcat/util/net/ tes

2010-12-02 Thread Mladen Turk
On 12/01/2010 07:37 PM, ma...@apache.org wrote: Author: markt Date: Wed Dec 1 18:37:29 2010 New Revision: 1041120 URL: http://svn.apache.org/viewvc?rev=1041120&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50360 Bind/release socket on start()/stop() Register/deregister MB

DO NOT REPLY [Bug 50404] Configuring per-webapp logging is unjustifiably difficult

2010-12-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50404 --- Comment #2 from Konstantin Kolinko 2010-12-02 20:24:09 EST --- I mean, what you are asking is already easy to set up with the current implementation. If you have usage questions, please ask on the users@ list and look for previous answ

DO NOT REPLY [Bug 50404] Configuring per-webapp logging is unjustifiably difficult

2010-12-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50404 Konstantin Kolinko changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

Re: [ANN] New Tomcat committer: Sylvain Laurent (slaurent)

2010-12-02 Thread Keiichi Fujino
2010/12/3 Mark Thomas : > On behalf of the Tomcat committers I am pleased to announce that Sylvain > Laurent (slaurent) has been voted in as a new Tomcat committer. > > Please join me in welcoming him. > Welcome Sylvain! -- Keiichi.Fujino

DO NOT REPLY [Bug 50405] New: Null Pointer Exception at Coyote Adapter

2010-12-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50405 Summary: Null Pointer Exception at Coyote Adapter Product: Tomcat 7 Version: 7.0.5 Platform: PC Status: NEW Severity: normal Priority: P2 Component: Catalina

DO NOT REPLY [Bug 50404] New: Configuring per-webapp logging is unjustifiably difficult

2010-12-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50404 Summary: Configuring per-webapp logging is unjustifiably difficult Product: Tomcat 6 Version: unspecified Platform: PC OS/Version: Linux Status: NEW

svn commit: r1041621 - /tomcat/trunk/res/maven/mvn.properties.default

2010-12-02 Thread markt
Author: markt Date: Thu Dec 2 22:37:53 2010 New Revision: 1041621 URL: http://svn.apache.org/viewvc?rev=1041621&view=rev Log: Bump versions ready for next release Modified: tomcat/trunk/res/maven/mvn.properties.default Modified: tomcat/trunk/res/maven/mvn.properties.default URL: http://svn

Re: Automated FindBugs Reportg

2010-12-02 Thread Mark Thomas
On 02/12/2010 21:32, Christopher Schultz wrote: > All, > > I've recently been playing with FindBugs on my own projects and have it > working via ant, ignoring checks that I find legitimate, and producing > readable reports. > > Is anyone interested in me adding a "findbugs" target to the build >

Re: Automated FindBugs Reportg

2010-12-02 Thread Mark Thomas
On 02/12/2010 22:07, Henri Gomez wrote: > FindBugs, Checkstyle and many more QA tests are allready provided by > Sonar team for Tomcat :-) > > http://nemo.sonarsource.org/dashboard/index/50544 Nice. It looks liek that is for Tomcat 6.0.x. How do we get 7.0.x and 5.5.x added? Mark --

Re: My first to 7.x

2010-12-02 Thread Mark Thomas
On 02/12/2010 21:25, Christopher Schultz wrote: > All, > > So I'd like to apply my patch for bug (enhancement) 48692 > (https://issues.apache.org/bugzilla/show_bug.cgi?id=48692) to TC 7 trunk. > > It's obvious to me how I should actually apply the patch: do an svn > update, resolve any problems t

svn commit: r1041613 - in /tomcat/site/trunk: docs/whoweare.html xdocs/whoweare.xml

2010-12-02 Thread slaurent
Author: slaurent Date: Thu Dec 2 22:14:23 2010 New Revision: 1041613 URL: http://svn.apache.org/viewvc?rev=1041613&view=rev Log: added slaurent as committer Modified: tomcat/site/trunk/docs/whoweare.html tomcat/site/trunk/xdocs/whoweare.xml Modified: tomcat/site/trunk/docs/whoweare.html

Re: Automated FindBugs Reportg

2010-12-02 Thread Henri Gomez
> All, > > I've recently been playing with FindBugs on my own projects and have it > working via ant, ignoring checks that I find legitimate, and producing > readable reports. > > Is anyone interested in me adding a "findbugs" target to the build > script to invoke findbugs and produce a report? Re

Re: My first to 7.x

2010-12-02 Thread Costin Manolache
I always had this question - for trunk most of the times I just submited the change and if anyone -1 I revert. If you feel it's going to be controversial - send a mail first and ask for opinions. There is an automated svn commit message that would notify anyone interested about the change. For no

Re: [ANN] New Tomcat committer: Sylvain Laurent (slaurent)

2010-12-02 Thread Christopher Schultz
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 All, On 12/2/2010 10:47 AM, Mark Thomas wrote: > On behalf of the Tomcat committers I am pleased to announce that Sylvain > Laurent (slaurent) has been voted in as a new Tomcat committer. > > Please join me in welcoming him. Welcome to the team. -

Automated FindBugs Reportg

2010-12-02 Thread Christopher Schultz
All, I've recently been playing with FindBugs on my own projects and have it working via ant, ignoring checks that I find legitimate, and producing readable reports. Is anyone interested in me adding a "findbugs" target to the build script to invoke findbugs and produce a report? Reports can be g

My first to 7.x

2010-12-02 Thread Christopher Schultz
All, So I'd like to apply my patch for bug (enhancement) 48692 (https://issues.apache.org/bugzilla/show_bug.cgi?id=48692) to TC 7 trunk. It's obvious to me how I should actually apply the patch: do an svn update, resolve any problems that arise (shouldn't be any) and commit what I've got to svn.

DO NOT REPLY [Bug 13309] Catalina calls System.exit()

2010-12-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=13309 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution|

DO NOT REPLY [Bug 10691] staring tomcat gives indication that tomcat is starting but never that it is started

2010-12-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=10691 Mark Thomas changed: What|Removed |Added Status|ASSIGNED|RESOLVED Resolution|

DO NOT REPLY [Bug 9511] Object instantiation optimization in StandardSession.java

2010-12-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=9511 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 8705] SessionListener should extend EventListener

2010-12-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=8705 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1041578 - in /tomcat/trunk: java/org/apache/catalina/SessionListener.java webapps/docs/changelog.xml

2010-12-02 Thread markt
Author: markt Date: Thu Dec 2 20:48:41 2010 New Revision: 1041578 URL: http://svn.apache.org/viewvc?rev=1041578&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=8705 org.apache.catalina.SessionListener should extend java.util.EventListener Modified: tomcat/trunk/java/org/

DO NOT REPLY [Bug 6614] Have Bootstrap and StandardClassLoader use the same ClassLoader

2010-12-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=6614 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1041573 - in /tomcat/trunk: BUILDING.txt build.xml

2010-12-02 Thread markt
Author: markt Date: Thu Dec 2 20:35:15 2010 New Revision: 1041573 URL: http://svn.apache.org/viewvc?rev=1041573&view=rev Log: Add an embedded distribution to the release build Modified: tomcat/trunk/BUILDING.txt tomcat/trunk/build.xml Modified: tomcat/trunk/BUILDING.txt URL: http://svn

svn commit: r1041558 - /tomcat/trunk/java/org/apache/catalina/session/ManagerBase.java

2010-12-02 Thread markt
Author: markt Date: Thu Dec 2 20:03:22 2010 New Revision: 1041558 URL: http://svn.apache.org/viewvc?rev=1041558&view=rev Log: Fix Javadoc warning Modified: tomcat/trunk/java/org/apache/catalina/session/ManagerBase.java Modified: tomcat/trunk/java/org/apache/catalina/session/ManagerBase.java

Re: [ANN] New Tomcat committer: Sylvain Laurent (slaurent)

2010-12-02 Thread Pid
On 12/2/10 3:47 PM, Mark Thomas wrote: > On behalf of the Tomcat committers I am pleased to announce that Sylvain > Laurent (slaurent) has been voted in as a new Tomcat committer. > > Please join me in welcoming him. Hehey. Congrats Sylvain! p 0x62590808.asc Description: application/pgp-keys

svn commit: r1041527 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-12-02 Thread markt
Author: markt Date: Thu Dec 2 18:55:01 2010 New Revision: 1041527 URL: http://svn.apache.org/viewvc?rev=1041527&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1

Re: [ANN] New Tomcat committer: Sylvain Laurent (slaurent)

2010-12-02 Thread Rainer Jung
On 02.12.2010 16:47, Mark Thomas wrote: On behalf of the Tomcat committers I am pleased to announce that Sylvain Laurent (slaurent) has been voted in as a new Tomcat committer. Please join me in welcoming him. Welcome Sylvain, and Congratulations! Regards, Rainer ---

svn commit: r1041475 - in /tomcat/trunk/java/org/apache/coyote: ajp/AbstractAjpProtocol.java http11/AbstractHttp11Protocol.java

2010-12-02 Thread markt
Author: markt Date: Thu Dec 2 17:25:45 2010 New Revision: 1041475 URL: http://svn.apache.org/viewvc?rev=1041475&view=rev Log: Remove unnecessary code Identified by FindBugs Modified: tomcat/trunk/java/org/apache/coyote/ajp/AbstractAjpProtocol.java tomcat/trunk/java/org/apache/coyote/http

svn commit: r1041469 - in /tomcat/trunk: java/org/apache/catalina/ha/session/JvmRouteBinderValve.java java/org/apache/catalina/ha/session/LocalStrings.properties java/org/apache/tomcat/util/digester/D

2010-12-02 Thread markt
Author: markt Date: Thu Dec 2 17:15:08 2010 New Revision: 1041469 URL: http://svn.apache.org/viewvc?rev=1041469&view=rev Log: Don't pass null to log messages. Found by FindBugs Modified: tomcat/trunk/java/org/apache/catalina/ha/session/JvmRouteBinderValve.java tomcat/trunk/java/org/apach

svn commit: r1041458 - /tomcat/trunk/java/org/apache/catalina/mbeans/MBeanUtils.java

2010-12-02 Thread markt
Author: markt Date: Thu Dec 2 17:07:07 2010 New Revision: 1041458 URL: http://svn.apache.org/viewvc?rev=1041458&view=rev Log: Protect against unlikely NPE Modified: tomcat/trunk/java/org/apache/catalina/mbeans/MBeanUtils.java Modified: tomcat/trunk/java/org/apache/catalina/mbeans/MBeanUtils

svn commit: r1041448 - in /tomcat/trunk: java/org/apache/catalina/mbeans/ContainerMBean.java webapps/docs/changelog.xml

2010-12-02 Thread markt
Author: markt Date: Thu Dec 2 16:51:08 2010 New Revision: 1041448 URL: http://svn.apache.org/viewvc?rev=1041448&view=rev Log: Correct removal of LifeCycleListenters from Containers via JMX. Found with FindBugs Modified: tomcat/trunk/java/org/apache/catalina/mbeans/ContainerMBean.java tom

DO NOT REPLY [Bug 48358] JSP-unloading reloaded

2010-12-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48358 --- Comment #16 from Christian Brandel 2010-12-02 11:35:07 EST --- Update: I ran a similar test against the examples webapp with maxLoadedJsps set to 10. Right before and after a manually triggered GC there were 43 instances of org.apache

svn commit: r1041427 - /tomcat/trunk/test/org/apache/catalina/util/TestContextName.java

2010-12-02 Thread markt
Author: markt Date: Thu Dec 2 16:09:45 2010 New Revision: 1041427 URL: http://svn.apache.org/viewvc?rev=1041427&view=rev Log: Better test case Modified: tomcat/trunk/test/org/apache/catalina/util/TestContextName.java Modified: tomcat/trunk/test/org/apache/catalina/util/TestContextName.java

svn commit: r1041425 - /tomcat/trunk/java/org/apache/catalina/util/ContextName.java

2010-12-02 Thread markt
Author: markt Date: Thu Dec 2 16:07:10 2010 New Revision: 1041425 URL: http://svn.apache.org/viewvc?rev=1041425&view=rev Log: Fix error in r1041356 Modified: tomcat/trunk/java/org/apache/catalina/util/ContextName.java Modified: tomcat/trunk/java/org/apache/catalina/util/ContextName.java URL

[ANN] New Tomcat committer: Sylvain Laurent (slaurent)

2010-12-02 Thread Mark Thomas
On behalf of the Tomcat committers I am pleased to announce that Sylvain Laurent (slaurent) has been voted in as a new Tomcat committer. Please join me in welcoming him. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apa

DO NOT REPLY [Bug 48358] JSP-unloading reloaded

2010-12-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=48358 --- Comment #15 from Christian Brandel 2010-12-02 10:00:12 EST --- Tha patch applies cleanly to 6.0.29 from the src archive. However it does not work for me the way I expected it and I am still facing PermGen Out Of Memory errors. - The c

svn commit: r1041356 - in /tomcat/trunk: java/org/apache/catalina/util/ContextName.java test/org/apache/catalina/util/TestContextName.java

2010-12-02 Thread markt
Author: markt Date: Thu Dec 2 12:56:56 2010 New Revision: 1041356 URL: http://svn.apache.org/viewvc?rev=1041356&view=rev Log: HostConfig passed a context name to ContextName(String) - ensure that this is correctly parsed. ContextName(String) now accepts all variations of Context name. Modified

[g...@vmgump]: Project taglibs-parent (in module tomcat-taglibs) failed

2010-12-02 Thread Gump
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project taglibs-parent has an issue affecting its community integration. This issu

svn commit: r1041324 - /tomcat/trunk/java/org/apache/catalina/util/ContextName.java

2010-12-02 Thread markt
Author: markt Date: Thu Dec 2 10:30:17 2010 New Revision: 1041324 URL: http://svn.apache.org/viewvc?rev=1041324&view=rev Log: Make constants static Modified: tomcat/trunk/java/org/apache/catalina/util/ContextName.java Modified: tomcat/trunk/java/org/apache/catalina/util/ContextName.java URL

DO NOT REPLY [Bug 50242] Sample log4j configuration does not match default JULI-based configuration

2010-12-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50242 --- Comment #5 from Mark Thomas 2010-12-02 03:36:57 EST --- Please don't hijack similar but unrelated bugs. Anything added to an already resolved bug is almost certain to get ignored / lost. Please create a new Enhancement request for the

DO NOT REPLY [Bug 50360] Server socket still bound after Embedded.stop is invoked

2010-12-02 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50360 --- Comment #7 from Martin Grotzke 2010-12-02 03:11:32 EST --- Great, thanx a lot for fixing this! -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You

Re: [ANN] Apache Tomcat Connectors 1.2.31 released

2010-12-02 Thread Rainer Jung
On 01.12.2010 19:46, Christopher Schultz wrote: Rainer, On 11/1/2010 10:56 AM, Rainer Jung wrote: On 01.11.2010 15:32, Christopher Schultz wrote: Mladen, On 11/1/2010 7:43 AM, Mladen Turk wrote: The Apache Tomcat team announces the immediate availability of Apache Tomcat Connectors 1.2.31 st