On 12/01/2010 07:37 PM, ma...@apache.org wrote:
Author: markt
Date: Wed Dec 1 18:37:29 2010
New Revision: 1041120
URL: http://svn.apache.org/viewvc?rev=1041120&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=50360
Bind/release socket on start()/stop()
Register/deregister MBeans on init()/destroy()
Modified: tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java?rev=1041120&r1=1041119&r2=1041120&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java
(original)
+++ tomcat/trunk/java/org/apache/tomcat/util/net/AbstractEndpoint.java Wed Dec
1 18:37:29 2010
@@ -128,11 +128,6 @@ public abstract class AbstractEndpoint {
protected volatile boolean paused = false;
/**
- * Track the initialization state of the endpoint.
- */
- protected boolean initialized = false;
-
We would need that back or even better axe running and paused
and creating an "state" enum.
For example the connector will report as running on start()
even if missconfigured cause it is set before Acceptor or Pollers
are created.
So internally both for paused and running we actually have
pauseStarted -> paused, runningStarted -> running=true
For stop() we have
pausePending -> paused, runningPending -> running=false
Currently it is possible to start() while stop() is still running
which could only happen if stop() actually ended.
Think that single eg. EndpointState enum will cover all the
states during start(),pause(),resume(),stop() replacing multiple
booleans (at least running and paused) with a single enum.
WDTYT?
Regards
--
^TM
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
