Re: Documentation for file serving and WebdavServlet

2010-10-06 Thread Rainer Jung
On 07.10.2010 03:02, Tim Whittington wrote: Hi all Working through https://issues.apache.org/bugzilla/show_bug.cgi?id=50026 there appears to be a lack of broader community understanding/documentation of how to configure file/resource serving in Tomcat. In particular the fact that DefaultServlet

Re: Documentation for file serving and WebdavServlet

2010-10-06 Thread Tim Whittington
>> Hi all >> >> Working through >> https://issues.apache.org/bugzilla/show_bug.cgi?id=50026 there appears >> to be a lack of broader community understanding/documentation of how >> to configure file/resource serving in Tomcat. >> In particular the fact that DefaultServlet is a Servlet (and not a >>

Re: Missing SVN EOL-style on 2 test files

2010-10-06 Thread Tim Whittington
Fixed On Thu, Oct 7, 2010 at 12:38 PM, sebb wrote: > Current tomcat-trunk: > > URL: http://svn.apache.org/repos/asf/tomcat/trunk > Revision: 1005289 > > svn ps svn:eol-style native > test/org/apache/catalina/servlets/TestDefaultServlet.java > svn ps svn:eol-style native > test/org/apache/catalina

svn commit: r1005309 - in /tomcat/trunk/test/org/apache/catalina/servlets: TestDefaultServlet.java TestWebdavServlet.java

2010-10-06 Thread timw
Author: timw Date: Thu Oct 7 00:53:21 2010 New Revision: 1005309 URL: http://svn.apache.org/viewvc?rev=1005309&view=rev Log: Setting native line encoding. No functional change Modified: tomcat/trunk/test/org/apache/catalina/servlets/TestDefaultServlet.java (props changed) tomcat/trunk

Re: Missing AL headers in tomcat-trunk

2010-10-06 Thread Tim Whittington
> res/ide-support/eclipse/start.launch > res/ide-support/eclipse/stop.launch These 2 files have licenses in them, the same as the eclipse.* files in the same directory. Detection fail? > test/org/apache/coyote/http11/TestAbstractHttp11Processor.java > test/org/apache/coyote/http11/TestGzipOutputF

svn commit: r1005308 - in /tomcat/trunk/test/org/apache/coyote/http11: TestAbstractHttp11Processor.java TestGzipOutputFilter.java filters/TestChunkedInputFilter.java

2010-10-06 Thread timw
Author: timw Date: Thu Oct 7 00:50:28 2010 New Revision: 1005308 URL: http://svn.apache.org/viewvc?rev=1005308&view=rev Log: Adding license headers. No functional change Modified: tomcat/trunk/test/org/apache/coyote/http11/TestAbstractHttp11Processor.java tomcat/trunk/test/org/apache/coy

Missing AL headers in tomcat-trunk

2010-10-06 Thread sebb
FYI, missing AL headers in: URL: http://svn.apache.org/repos/asf/tomcat/trunk Revision: 1005289 res/ide-support/eclipse/start.launch res/ide-support/eclipse/stop.launch test/org/apache/coyote/http11/TestAbstractHttp11Processor.java test/org/apache/coyote/http11/TestGzipOutputFilter.java test/org

Missing SVN EOL-style on 2 test files

2010-10-06 Thread sebb
Current tomcat-trunk: URL: http://svn.apache.org/repos/asf/tomcat/trunk Revision: 1005289 svn ps svn:eol-style native test/org/apache/catalina/servlets/TestDefaultServlet.java svn ps svn:eol-style native test/org/apache/catalina/servlets/TestWebdavServlet.java ---

DO NOT REPLY [Bug 49965] JAASRealm uses wrong string constants

2010-10-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49965 --- Comment #1 from Mark Thomas 2010-10-06 19:08:09 EDT --- This was already fixed in trunk/7.0.x I have proposed a back-port of the fix for 6.0.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- Y

svn commit: r1005286 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-10-06 Thread markt
Author: markt Date: Wed Oct 6 23:07:30 2010 New Revision: 1005286 URL: http://svn.apache.org/viewvc?rev=1005286&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1

DO NOT REPLY [Bug 49957] Work directories of deployed webapps are deleted at shutdown

2010-10-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49957 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1005284 - in /tomcat/trunk: java/org/apache/catalina/startup/HostConfig.java java/org/apache/catalina/startup/LocalStrings.properties webapps/docs/changelog.xml

2010-10-06 Thread markt
Author: markt Date: Wed Oct 6 22:54:13 2010 New Revision: 1005284 URL: http://svn.apache.org/viewvc?rev=1005284&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49957 Correct regression due to Lifecycle re-factoring that cleared all work directories (with compiled JSPs and pe

DO NOT REPLY [Bug 49956] @Resource(name=) Normalization of JNDI Name

2010-10-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49956 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1005271 - in /tomcat/trunk: java/org/apache/catalina/core/DefaultInstanceManager.java webapps/docs/changelog.xml

2010-10-06 Thread markt
Author: markt Date: Wed Oct 6 21:58:37 2010 New Revision: 1005271 URL: http://svn.apache.org/viewvc?rev=1005271&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49956 Handle case when @Resource annotation uses the full JNDI name for a resource. Based on a patch by Gurkan Erdog

svn commit: r1005269 - /tomcat/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java

2010-10-06 Thread markt
Author: markt Date: Wed Oct 6 21:51:27 2010 New Revision: 1005269 URL: http://svn.apache.org/viewvc?rev=1005269&view=rev Log: Fix indent Modified: tomcat/trunk/java/org/apache/catalina/core/DefaultInstanceManager.java Modified: tomcat/trunk/java/org/apache/catalina/core/DefaultInstanceManag

svn commit: r1005267 - /tomcat/trunk/java/org/apache/catalina/core/StandardContext.java

2010-10-06 Thread markt
Author: markt Date: Wed Oct 6 21:50:10 2010 New Revision: 1005267 URL: http://svn.apache.org/viewvc?rev=1005267&view=rev Log: Whitespace police Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java Modified: tomcat/trunk/java/org/apache/catalina/core/StandardContext.java

DO NOT REPLY [Bug 49952] ServletContainerInitializer can't actually add listeners

2010-10-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49952 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

svn commit: r1005266 - /tomcat/trunk/java/org/apache/catalina/core/ApplicationContext.java

2010-10-06 Thread markt
Author: markt Date: Wed Oct 6 21:47:27 2010 New Revision: 1005266 URL: http://svn.apache.org/viewvc?rev=1005266&view=rev Log: Fix comment typo Better error message when a SCL can not be added since the listeners have already been called. Modified: tomcat/trunk/java/org/apache/catalina/core/

svn commit: r1005265 - in /tomcat/trunk: java/org/apache/catalina/core/LocalStrings.properties java/org/apache/catalina/core/StandardContext.java test/org/apache/catalina/startup/TestListener.java web

2010-10-06 Thread markt
Author: markt Date: Wed Oct 6 21:46:43 2010 New Revision: 1005265 URL: http://svn.apache.org/viewvc?rev=1005265&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=49952 Allow ServletContainerInitializers to add listeners to a web application. Patch provided by David Jencks. Ad

svn commit: r1005259 - /tomcat/trunk/webapps/docs/changelog.xml

2010-10-06 Thread markt
Author: markt Date: Wed Oct 6 21:25:23 2010 New Revision: 1005259 URL: http://svn.apache.org/viewvc?rev=1005259&view=rev Log: 7.0.3 not released. Missing license header in src file. Modified: tomcat/trunk/webapps/docs/changelog.xml Modified: tomcat/trunk/webapps/docs/changelog.xml URL: htt

Re: [VOTE] [RESULT] Release Apache Tomcat 7.0.3

2010-10-06 Thread Mark Thomas
On 03/10/2010 00:47, Mark Thomas wrote: > The proposed Apache Tomcat 7.0.3 release is now available for voting. > > It can be obtained from: > http://people.apache.org/~markt/dev/tomcat-7/v7.0.3/ > The svn tag is: > http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_3/ > > As with pre

Re: [VOTE] Release Apache Tomcat 7.0.3

2010-10-06 Thread Martin Dubuc
+1 Beta On Sat, Oct 2, 2010 at 7:47 PM, Mark Thomas wrote: > The proposed Apache Tomcat 7.0.3 release is now available for voting. > > It can be obtained from: > http://people.apache.org/~markt/dev/tomcat-7/v7.0.3/ > The svn tag is: > http:

DO NOT REPLY [Bug 3839] Problem bookmarking login page

2010-10-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=3839 --- Comment #14 from Mark Morris 2010-10-06 15:29:58 EDT --- I've been tracing through the Tomcat source code because of an "Invalid direct reference to form login page" error our customers frequently get and here is what was found (for Tom

svn commit: r1005192 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-10-06 Thread markt
Author: markt Date: Wed Oct 6 18:03:03 2010 New Revision: 1005192 URL: http://svn.apache.org/viewvc?rev=1005192&view=rev Log: Proposal Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=1

svn commit: r1005076 - /tomcat/trunk/test/org/apache/catalina/connector/TestCoyoteAdapter.java

2010-10-06 Thread markt
Author: markt Date: Wed Oct 6 15:09:37 2010 New Revision: 1005076 URL: http://svn.apache.org/viewvc?rev=1005076&view=rev Log: Colleague at $work reported issues path parameters and extension mapping so add some tests. Looks OK. Modified: tomcat/trunk/test/org/apache/catalina/connector/TestC

Re: Documentation for file serving and WebdavServlet

2010-10-06 Thread Rainer Jung
On 06.10.2010 10:58, Tim Whittington wrote: Hi all Working through https://issues.apache.org/bugzilla/show_bug.cgi?id=50026 there appears to be a lack of broader community understanding/documentation of how to configure file/resource serving in Tomcat. In particular the fact that DefaultServlet

DO NOT REPLY [Bug 50023] [patch] [jstl.core] confusing and complicated call with simple solution

2010-10-06 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=50023 Martin Monperrus changed: What|Removed |Added Attachment #26099|0 |1 is obsolete|

Documentation for file serving and WebdavServlet

2010-10-06 Thread Tim Whittington
Hi all Working through https://issues.apache.org/bugzilla/show_bug.cgi?id=50026 there appears to be a lack of broader community understanding/documentation of how to configure file/resource serving in Tomcat. In particular the fact that DefaultServlet is a Servlet (and not a magic engine internal)

svn commit: r1004929 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-10-06 Thread timw
Author: timw Date: Wed Oct 6 08:41:25 2010 New Revision: 1004929 URL: http://svn.apache.org/viewvc?rev=1004929&view=rev Log: Adding fix for protecting includes to proposed DefaultServlet protection of WEB-INF fix Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STAT

Re: svn commit: r1004393 - /tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java

2010-10-06 Thread Tim Whittington
> 1. In DefaultServlet#getRelativePath(..) there is >  "if (request.getAttribute(Globals.INCLUDE_REQUEST_URI_ATTR) != null)" > branch several lines above that.  I suspect that it needs the same > changes. (As it does the same things with the paths, though takes > them from attributes). Fixed. Than

svn commit: r1004928 - in /tomcat/trunk/test/org/apache/catalina/servlets: ./ TestDefaultServlet.java TestWebdavServlet.java

2010-10-06 Thread timw
Author: timw Date: Wed Oct 6 08:37:56 2010 New Revision: 1004928 URL: http://svn.apache.org/viewvc?rev=1004928&view=rev Log: Adding unit tests for DefaultServlet and WebdavServlet to test basic serving/mounting behaviour and protection of special paths Added: tomcat/trunk/test/org/apache/ca

[Tomcat Wiki] Update of "PoweredBy" by Matthieu SEDIRI

2010-10-06 Thread Apache Wiki
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "PoweredBy" page has been changed by Matthieu SEDIRI. http://wiki.apache.org/tomcat/PoweredBy?action=diff&rev1=267&rev2=268 -- {{

svn commit: r1004927 - /tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java

2010-10-06 Thread timw
Author: timw Date: Wed Oct 6 08:36:20 2010 New Revision: 1004927 URL: http://svn.apache.org/viewvc?rev=1004927&view=rev Log: Making TomcatBaseTest.getUrl() work for get requests that return 404 responses Modified: tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java Modified: t

svn commit: r1004914 - in /tomcat/trunk/java/org/apache/catalina/servlets: DefaultServlet.java WebdavServlet.java

2010-10-06 Thread timw
Author: timw Date: Wed Oct 6 07:24:46 2010 New Revision: 1004914 URL: http://svn.apache.org/viewvc?rev=1004914&view=rev Log: Correcting JavaDoc for HTTP methods. No functional change Modified: tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java tomcat/trunk/java/org/apache

svn commit: r1004912 - /tomcat/trunk/java/org/apache/catalina/servlets/DefaultServlet.java

2010-10-06 Thread timw
Author: timw Date: Wed Oct 6 07:22:46 2010 New Revision: 1004912 URL: http://svn.apache.org/viewvc?rev=1004912&view=rev Log: More fixes for https://issues.apache.org/bugzilla/show_bug.cgi?id=50026 Calculating complete resource path when accessed via RequestDispatcher.include() Modified: tomc