> 1. In DefaultServlet#getRelativePath(..) there is > "if (request.getAttribute(Globals.INCLUDE_REQUEST_URI_ATTR) != null)" > branch several lines above that. I suspect that it needs the same > changes. (As it does the same things with the paths, though takes > them from attributes).
Fixed. Thanks for the catch. > 2. The comments >> + // Mapped to '/' >> + // Mapped to '/path/*' so get entire path under context > look wrong to me. (It does not matter how the servlet is mapped, but > how it is requested) > The code is correct though. > I think those two wrong comments can be removed, as there is already a > long comment at the start of the method that explains the things. Agreed, they don't add anything. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
