DO NOT REPLY [Bug 49570] New: The CompressionFilter example should support HTTP proxies to cache gzipped content better by sending Vary: Accept-Encoding header

2010-07-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49570 Summary: The CompressionFilter example should support HTTP proxies to cache gzipped content better by sending Vary: Accept-Encoding header Product: Tomcat 7 Version: tr

Re: svn commit: r960104 - /tomcat/trunk/test/org/apache/catalina/mbeans/TestRegistration.java

2010-07-07 Thread Peter Roßbach
I totally argreed with Marc Guillemot. It is time to more invest to the cosmetic things at the tomcat code basis. Peter Am 08.07.2010 um 07:37 schrieb Marc Guillemot: Hi Mark, Mark Thomas wrote: ... There is nothing stopping you running FindBugs, Checkstyle or any other tool locally.

Re: svn commit: r960104 - /tomcat/trunk/test/org/apache/catalina/mbeans/TestRegistration.java

2010-07-07 Thread Marc Guillemot
Hi Mark, Mark Thomas wrote: ... There is nothing stopping you running FindBugs, Checkstyle or any other tool locally. I use FindBugs on the Tomact 7 code-base all the time. what about sharing the config and including it into the build? What does the other developers think? +0 providing w

DO NOT REPLY [Bug 49488] Infrequent StringIndexOutOfBoundsException in WebappClassLoader

2010-07-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49488 Konstantin Kolinko changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|

svn commit: r961541 - in /tomcat/trunk: java/org/apache/catalina/session/LocalStrings.properties java/org/apache/catalina/session/StandardSession.java webapps/docs/changelog.xml

2010-07-07 Thread markt
Author: markt Date: Thu Jul 8 00:05:38 2010 New Revision: 961541 URL: http://svn.apache.org/viewvc?rev=961541&view=rev Log: Include session ID in error message logged when trying to set an attribute on an invalid session. Modified: tomcat/trunk/java/org/apache/catalina/session/LocalStrings.

svn commit: r961535 - in /tomcat/trunk: java/org/apache/catalina/ java/org/apache/catalina/core/ java/org/apache/jasper/ java/org/apache/jasper/compiler/ java/org/apache/jasper/servlet/ webapps/docs/

2010-07-07 Thread markt
Author: markt Date: Wed Jul 7 23:33:28 2010 New Revision: 961535 URL: http://svn.apache.org/viewvc?rev=961535&view=rev Log: Improve logging of unhandled servlet exceptions by including the context name. For JasperExceptions, the JSP snippet will be logged (if enabled). Previously this was not l

Re: [VOTE] Release build 6.0.28

2010-07-07 Thread sebb
On 7 July 2010 21:19, Rainer Jung wrote: > On 07.07.2010 21:00, sebb wrote: >> >> On 7 July 2010 10:47, Rainer Jung  wrote: >>> >>> On 29.06.2010 17:17, jean-frederic clere wrote: > >>>  - build.properties: it would be nice, if you did the release changes to >>> the >>> file before tagging (and un

svn commit: r961525 - /tomcat/trunk/java/org/apache/jasper/servlet/JspServletWrapper.java

2010-07-07 Thread markt
Author: markt Date: Wed Jul 7 22:34:47 2010 New Revision: 961525 URL: http://svn.apache.org/viewvc?rev=961525&view=rev Log: Fix some Eclipse warnings Modified: tomcat/trunk/java/org/apache/jasper/servlet/JspServletWrapper.java Modified: tomcat/trunk/java/org/apache/jasper/servlet/JspServlet

Re: [VOTE] Release build 6.0.28

2010-07-07 Thread Rainer Jung
On 07.07.2010 21:00, sebb wrote: On 7 July 2010 10:47, Rainer Jung wrote: On 29.06.2010 17:17, jean-frederic clere wrote: - build.properties: it would be nice, if you did the release changes to the file before tagging (and undo after) like Mark does for TC 7 (properties version and version

DO NOT REPLY [Bug 49142] Missing serialVersionUIDs

2010-07-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49142 --- Comment #3 from dbz 2010-07-07 15:56:41 EDT --- Created an attachment (id=25730) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25730) A patch which add a serial version UID to all the classes where it is needed I have adde

Re: [VOTE] Release build 6.0.28

2010-07-07 Thread sebb
On 7 July 2010 10:47, Rainer Jung wrote: > On 29.06.2010 17:17, jean-frederic clere wrote: >> >> According to the release process, the 6.0.28 build corresponding to the >> tag TOMCAT_6_0_28 is: >> [ ] Broken >> [ ] Alpha >> [ ] Beta >> [X] Stable >> +++ >> >> Comments? > > - MD5 OK > > - signature

Re: svn commit: r960104 - /tomcat/trunk/test/org/apache/catalina/mbeans/TestRegistration.java

2010-07-07 Thread Mark Thomas
On 07/07/2010 17:53, Peter Roßbach wrote: > Then I can check my personal problem with the tab/space replacement, > before checkin code :-) > Currently we have in 144 files a tab instead a space replacement issue. There is nothing stopping you running FindBugs, Checkstyle or any other tool locally.

Re: svn commit: r960104 - /tomcat/trunk/test/org/apache/catalina/mbeans/TestRegistration.java

2010-07-07 Thread Peter Roßbach
Hi! I miss the checkstyle and findbugs quality checks in the project. Marc has contributed a good starting point at https://issues.apache.org/bugzilla/show_bug.cgi?id=49268 Then I can check my personal problem with the tab/space replacement, before checkin code :-) Currently we have in 144 f

Re: [VOTE] Release Tomcat 5.5.30 Build

2010-07-07 Thread Peter Roßbach
+1 Stable Test tar.gz with MAC OS X and it works fine. Thanks, Peter Am 01.07.2010 um 18:11 schrieb Jim Jagielski: The builds for Tomcat 5.5.30 are ready for testing and approval. The candidates binaries are available here: http://people.apache.org/~jim/tomcat-5.5/ According to the releas

Re: [VOTE] Release Tomcat 5.5.30 Build

2010-07-07 Thread Jim Jagielski
On Jul 7, 2010, at 9:59 AM, Rainer Jung wrote: > On 01.07.2010 18:11, Jim Jagielski wrote: >> According to the release process, the 5.5.30 build corresponding to the >> tag TOMCAT_5_5_30 [1] is: >> >> [ ] Broken >> [ ] Alpha >> [ ] Beta >> [X] Stable > > - MD5 OK > - Signatures OK > - Mostly ex

Re: Undeploying webapp programatically

2010-07-07 Thread Afkham Azeez
I was able to resolve this. It may be helpful for somebody looking for this information. After calling host.removeChild(context), you need to call, ((StandardContext)context).destroy(); Only when destroy is called the context gets completely removed. Thanks Azeez On Wed, Jul 7, 2010 at 7:12 PM,

svn commit: r961383 - in /tomcat/sandbox/tomcat-oacc/trunk: RELEASE-NOTES RUNNING.txt docs/oacc-howto.xml

2010-07-07 Thread rjung
Author: rjung Date: Wed Jul 7 14:13:29 2010 New Revision: 961383 URL: http://svn.apache.org/viewvc?rev=961383&view=rev Log: Fix docu bug. No need to set Manager class explicitely if the cluster class is correct. Modified: tomcat/sandbox/tomcat-oacc/trunk/RELEASE-NOTES tomcat/sandbox/tomc

Re: [VOTE] Release Tomcat 5.5.30 Build

2010-07-07 Thread Rainer Jung
On 01.07.2010 18:11, Jim Jagielski wrote: According to the release process, the 5.5.30 build corresponding to the tag TOMCAT_5_5_30 [1] is: [ ] Broken [ ] Alpha [ ] Beta [X] Stable - MD5 OK - Signatures OK - Mostly expected differences between tag and src archives, except: - Did you include

DO NOT REPLY [Bug 49528] HttpServletRequest.isAsyncStarted() returns false when a Runnable is started

2010-07-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49528 Konstantin Kolinko changed: What|Removed |Added Status|VERIFIED|CLOSED -- Configure bugmail:

Re: Undeploying webapp programatically

2010-07-07 Thread Mark Thomas
On 07/07/2010 14:26, Afkham Azeez wrote: > Hi, > I'm using embedded Tomcat 5.5.23. I undeploy the webapps > programmatically using the following code segment: > > host.removeChild(context); > > Now, when I send a request to the context which was undeployed, I get > an HTTP 503. But I expect to g

DO NOT REPLY [Bug 49567] when starting a new thread from a startAsync Runnable, an infinite amount of doPosts is generated

2010-07-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49567 Pieter Libin changed: What|Removed |Added CC||pie...@emweb.be -- Configure bugma

DO NOT REPLY [Bug 49528] HttpServletRequest.isAsyncStarted() returns false when a Runnable is started

2010-07-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49528 Pieter Libin changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #11 from Piete

DO NOT REPLY [Bug 49567] New: when starting a new thread from a startAsync Runnable, an infinite amount of doPosts is generated

2010-07-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49567 Summary: when starting a new thread from a startAsync Runnable, an infinite amount of doPosts is generated Product: Tomcat 7 Version: trunk Platform: PC OS/Version: Linux

Re: Undeploying webapp programatically

2010-07-07 Thread Afkham Azeez
Hi, I'm using embedded Tomcat 5.5.23. I undeploy the webapps programmatically using the following code segment: host.removeChild(context); Now, when I send a request to the context which was undeployed, I get an HTTP 503. But I expect to get an HTTP 404 since that resource is not actually availa

svn commit: r961351 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-07-07 Thread markt
Author: markt Date: Wed Jul 7 11:33:33 2010 New Revision: 961351 URL: http://svn.apache.org/viewvc?rev=961351&view=rev Log: Update patch Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev

DO NOT REPLY [Bug 49217] Accepting java keyword in EL

2010-07-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49217 Mark Thomas changed: What|Removed |Added Attachment #25726|0 |1 is obsolete|

Re: svn commit: r960864 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-07-07 Thread Mark Thomas
On 07/07/2010 11:36, Konstantin Kolinko wrote: > 1) There is no direct example/evidence in the EL spec itself, Then I guess you missed the following: Identifier ::= Java language identifier That definition appears in both the 2.1 and 2.2 specification. > and I understand that TCK passes without

svn commit: r961348 - /tomcat/tc5.5.x/trunk/STATUS.txt

2010-07-07 Thread rjung
Author: rjung Date: Wed Jul 7 11:06:59 2010 New Revision: 961348 URL: http://svn.apache.org/viewvc?rev=961348&view=rev Log: Add trivial proposal (close to C-T-R). Modified: tomcat/tc5.5.x/trunk/STATUS.txt Modified: tomcat/tc5.5.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc

Re: svn commit: r960864 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-07-07 Thread Konstantin Kolinko
2010/7/6 Mark Thomas : > On 06/07/2010 12:40, kkoli...@apache.org wrote: >> >> Author: kkolinko >> Date: Tue Jul  6 10:40:16 2010 >> New Revision: 960864 >> >> URL: http://svn.apache.org/viewvc?rev=960864&view=rev >> Log: >> vote >> >> Modified: >>     tomcat/tc6.0.x/trunk/STATUS.txt >> >> Modified

Re: [VOTE] Release build 6.0.28

2010-07-07 Thread Rainer Jung
On 29.06.2010 17:17, jean-frederic clere wrote: According to the release process, the 6.0.28 build corresponding to the tag TOMCAT_6_0_28 is: [ ] Broken [ ] Alpha [ ] Beta [X] Stable +++ Comments? - MD5 OK - signatures OK - as Konstantin noted: it would be nice if you added your key to the

DO NOT REPLY [Bug 49566] NullpointerException if /webapps/ROOT is deleted or removed

2010-07-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49566 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

DO NOT REPLY [Bug 49217] Accepting java keyword in EL

2010-07-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49217 --- Comment #5 from Mark Thomas 2010-07-07 05:19:44 EDT --- Created an attachment (id=25726) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25726) Patch for 6.0.x Back port of changes to 7.0.x with an additional option to disab

DO NOT REPLY [Bug 49536] If no webapps deployed, accessing a URL returns 200 OK with no content instead of 404

2010-07-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49536 Mark Thomas changed: What|Removed |Added CC||lff0...@gmail.com --- Comment #4 fro

svn commit: r961317 - /tomcat/tc6.0.x/trunk/STATUS.txt

2010-07-07 Thread markt
Author: markt Date: Wed Jul 7 09:20:23 2010 New Revision: 961317 URL: http://svn.apache.org/viewvc?rev=961317&view=rev Log: Update proposal, respond to valid parts of veto Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/

svn commit: r961313 - in /tomcat/trunk/java/org/apache/el/parser: AstDotSuffix.java AstIdentifier.java

2010-07-07 Thread markt
Author: markt Date: Wed Jul 7 09:10:38 2010 New Revision: 961313 URL: http://svn.apache.org/viewvc?rev=961313&view=rev Log: Better error message Modified: tomcat/trunk/java/org/apache/el/parser/AstDotSuffix.java tomcat/trunk/java/org/apache/el/parser/AstIdentifier.java Modified: tomcat/

DO NOT REPLY [Bug 49566] New: NullpointerException if /webapps/ROOT is deleted or removed

2010-07-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=49566 Summary: NullpointerException if /webapps/ROOT is deleted or removed Product: Tomcat 7 Version: 7.0.0 Platform: PC OS/Version: Windows XP Status: NEW

Re: [VOTE] Release build 6.0.28

2010-07-07 Thread Keiichi Fujino
2010/6/30 jean-frederic clere : > Due to bugs (49445 and 49424) and as I was not able to finish the > release process quickly (because of working remotely) and as releases > are cheap we would like to abandon 6.0.27 and propose the vote for 6.0.28 > > The candidates binaries are available here: > h

DO NOT REPLY [Bug 40114] Session inadvertently "hijacked" by different after server restart

2010-07-07 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=40114 --- Comment #5 from Denis A. 2010-07-07 03:01:23 EDT --- (In reply to comment #4) > There is a discrepancy between the version the bug was filed under (5.0.26), > and what you declare above; which is it? Sorry about that. It's Tomcat versi