On 07/07/2010 11:36, Konstantin Kolinko wrote: > 1) There is no direct example/evidence in the EL spec itself,
Then I guess you missed the following: Identifier ::= Java language identifier That definition appears in both the 2.1 and 2.2 specification. > and I understand that TCK passes without a fix for BZ 49217, The TCKs are well known not to provide 100% spec coverage. Passing the TCK is necessary but not sufficient to prove complete adherence to the specification. > because we have released 6.0.26 and 7.0.0 > 2) There is a separate chapter "Reserved Words" in EL spec, > which explicitly lists words that are forbidden as identifiers. The current implementation handles those. > It is not mentioned there that Java language keywords are > also reserved. Yes it is. Section 1.19 in the EL 2.2 spec. > 3) I agree, that it is possible to read the spec in your way, > so it makes sense to have such a check, > but I think that there must be a way to turn it off. For 6.0.x, I have no issue with providing an option to disable the check since Tomcat 6.0.x up to this point has been not been fully enforcing the spec. For Tomcat 7, which has only had a single beta release, I see no need to provide the same option. > Re: > https://issues.apache.org/bugzilla/attachment.cgi?id=25726 > The patch is incomplete. The "SKIP_IDENTIFIER_CHECK" property is mentioned > in documentation only. It is not used in the code. Thanks. I was having issues generating the correct patch for 6.0.x and tried to work around them by copying a file from Tomcat 7. I'll update the patch. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
